-----Original Message----- From: Jasper van de Gronde [mailto:th.v.d.gronde@...528...] Sent: Tuesday, September 29, 2009 14:03 To: Engelen, J.B.C. (Johan) Cc: inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] Failed 17 of 176 tests on cxxtests
J.B.C.Engelen@...1578... wrote:
Thanks for pointing it out to us Aurium. I fixed 3 errors. Some errors are not too bad I think (e.g.
the ones
about reading matrices where it should actually fail to read them)
If the latter occurs the test is wrong! A test should only fail if the behaviour is wrong, and it is customary (and good practice) to also test some cases that should normally result in some kind of failure condition (thus resulting in a pass result in your test).
I think the tests are correct. The tests I was refering to test whether Inkscape accepts strange input. "matrix(1,2,3,4,5,6,)" (note the extra comma) is apparently invalid input, and Inkscape should not accept that. The test checks if Inkscape rejects it ("fails to read" it). But since Inkscape does accept it, the test fails. So I meant: "the ones where Inkscape reads matrices that are invalid input, where it should actually not read them"
Ciao, Johan