Hi Papoj. I do the original function :( and your fix is good,. Anyway when you create a new branch in launchpad web you can mark the branch for review.
All the best, Jabier.
El mié, 16-12-2015 a las 21:28 -0500, Papoj Thamjaroenporn escribió:
Dear Inkscape-devel,
I would like to fix a simple bug I found in src/helper/geom.cpp::pathv_to_cubicbezier(). The control points are not set correctly:
Geom::CubicBezier b(cit->initialPoint(), cit-
pointAt(0.3334) + Geom::Point(cubicGap,cubicGap), cit->finalPoint(),
cit->finalPoint());
where it should have been:
Geom::CubicBezier b(cit->initialPoint(), cit-
pointAt(0.3333) + Geom::Point(cubicGap,cubicGap), cit- pointAt(0.6667) + Geom::Point(cubicGap,cubicGap), cit- finalPoint());
or more precisely:
Geom::CubicBezier b(cit->initialPoint(), cit-
pointAt(1./3.) + Geom::Point(cubicGap,cubicGap), cit->pointAt(2./3.)
- Geom::Point(cubicGap,cubicGap), cit->finalPoint());
(The Geom::Point(cubicGap,cubicGap) shouldn’t really be there, but that’s a separate issue I described in another email.)
I am not sure how to properly submit this. Do I follow the practice for bzr here http://wiki.inkscape.org/wiki/index.php/Working_with_Ba zaar#Test_branches_before_committing_merges and simply merge my fix (without a need for someone to review)?
Regards, _______________________ Papoj "Hua" Thamjaroenporn papojt@...3117...
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel