2 Feb
2006
2 Feb
'06
11:44 p.m.
Quoting Gustav Broberg <broberg@...370...>:
I have recently uploaded a patch[1] which provides an undo history dialog.
Hey, this is cool, Gustav!
It's not been talked about much, but it would be nice to have.
- To get the type of an event I rely entirely on the current event context. This obviously not (always) a correct assumption. An example of this problem: setting an object's color while the node tool is the current context.
Probably we'll need to add an extra argument to sp_document_done() to help you out with this.
- There are bugs lurking which I have not been able to reproduce. Some seem to be the result of problems with undoing of certain types of events; i.e. the bugs are in the current code. I'm looking into this... For now, here is at least one I managed to nail down and put in the tracker:
You may also be running into lifecycle issues with the history items. We may need to make them refcounted or something, as it's quite easy for e.g. a ListModel entry to outlast the underlying history item otherwise.
To the list: I'll not have time to review the patch today ... someone else want to do the honors? I'd like to see this get into the tree in some form.
-mental