Hi all, Now with the change to C++ objects (very happy about it!), is it OK to change this
if (SP_IS_LPE_ITEM(item)) { SPLPEItem *lpeitem = SP_LPE_ITEM(item);
to this:
A. if (SPLPEItem *lpeitem = dynamic_cast<SPLPEItem *>(item)) {
I prefer it over the two other options I can think of:
B. SPLPEItem *lpeitem = dynamic_cast<SPLPEItem *>(item); if (lpeitem) {
or
C. if (dynamic_cast<SPLPEItem *>(item)) { SPLPEItem *lpeitem = dynamic_cast<SPLPEItem *>(item);
I like A (more than B or C) because it limits the scope of lpeitem, and avoids duplicating the long dynamic_cast<> thing. Downside is that it makes the if-statement rather long. We use option A in 2geom if I remember correctly.
Please discuss, or add better implementations! I think it is worthwhile to add the outcome to the coding style page for reference.
Thanks, Johan