Anyone willing to help with testing/reviewing? IMHO this would fix an annoying issue with linked offsets.
It would be great to have it merged into trunk before another pending merge (gsoc-cairo) possibly requires yet again a rewrite, as well as backporting the fix to the 0.48.x branch for 0.48.2 (if doable).
~suv
-------- Original Message -------- Subject: [Merge] lp:~ado-papas/inkscape/bug_167419 into lp:inkscape Date: Thu, 10 Mar 2011 18:26:38 -0000 From: Adonis Papaderos <ado.papas@...1244...> Reply-To: mp+52899@...2499... To: mp+52899@...2499...
Adonis Papaderos has proposed merging lp:~ado-papas/inkscape/bug_167419 into lp:inkscape.
Requested reviews: Adonis Papaderos (ado-papas) ~suv (suv-lp) Related bugs: Bug #167419 in Inkscape: "square/circle/polygon/spiral and linked offset misbehaviours" https://bugs.launchpad.net/inkscape/+bug/167419 Bug #184341 in Inkscape: "Linked offsets ignore clone movement preferences" https://bugs.launchpad.net/inkscape/+bug/184341 Bug #239430 in Inkscape: "linked offset ungroup issue" https://bugs.launchpad.net/inkscape/+bug/239430
For more details, see: https://code.launchpad.net/~ado-papas/inkscape/bug_167419/+merge/52899
Fix some issues with linked offsets. Changed the rendering of the offset to take into account the transformation of the source object, as is the case with the use element, and copied the move compensation logic from uses to offsets. There is a speed penalty though because of this, since I cannot find a reliable method to predict whether there is a change to the source object data or a transformation applied to it.
The second patch removes an optimization I implemented using the transform event, since this event is not emitted on undo and redo actions.