Hi all, Just found a case of duplicate variable naming that looks very error-prone. In IconImpl::imageMapNamedCB in src/widgets/icon.cpp, line 1617, variable iconName appeared twice, so I renamed the second case so it is clear what the compiler is doing. Also a near duplicate naming (size and iconSize) caused for buggy code. It all worked because I think the two variables are filled with the same data, the functions appears to be doing the same work twice (getting the icon info). Finally, there is also a pointer comparison in the code. (should be a string comparison?)
Have a look at my changes in rev. 12870.
I hope someone who knows that piece of code better can have a look, see if the code is doing what is intended, and fix the pointer comparison.
Thanks, Johan