On Wed, 2010-08-04 at 09:31 -0700, Vaughn Spurlin wrote:
I agree with ~suv that "coverity" is a good tag for these bugs. I'm OK with any other tag the bug team prefers.
I think that tag is good as well.
I'll just start filing bugs as soon I find out what tag to use. After filing a bunch, I'll come back and add comments with a suggested fix. I don't expect to fix them all, so anyone else is welcome to contribute their fix first. I'll alternate between adding bugs and adding fixes.
While filing bugs, if you are going to change the "importance", please be sure to read the following wiki page to know how we rank things. Since what you are doing is from the inside out, the rankings may differ. However, if there is anything that has the potential to cause crashes or memory leaks, I would just go with High for those. http://wiki.inkscape.org/wiki/index.php/Bug_management
I don't have the broad knowledge of Inkscape that's needed to verify and test my suggested fixes. Others with that knowledge should review my suggested source changes, apply or reject the changes, and test them. For example, if I find code that's never executed, the programmer probably intended a very different result. Instead of simply deleting the dead code, someone with broader knowledge might make a different change that would make the code serve its correct purpose.
When adding the fixes to the bug reports, please try to attach diffs if it's convenient.
Also, the Inkscape code base continues to evolve rapidly. The Google Summer of Code projects will make some bug reports moot, while adding new code that needs review. The Coverity tools are designed to keep track of the same bug when code around it changes, and to remove bugs that belong to code that was removed. So I'll just go ahead with what I've got, and others can decide whether or not to proceed with the bug fixes I suggest. I'll update and reanalyze the source occasionally.
The merges will be coming in the near future (I imagine in the next month it should all be merged), so it will be interesting to see. :)
That's my plan for now. As soon as I get a tag approved by the bug team, I'll start adding bugs.
You are approved. :)
Cheers, Josh