http://inkscape.13.x6.nabble.com/Incomplete-switch-statement-tp4969823.html
On 22-3-2014 18:02, Markus Engel wrote:
Now even our automatic builds by Launchpad fail: CXX ui/dialog/input.o ../../src/ui/dialog/input.cpp: In member function 'bool Inkscape::UI::Dialog::InputDialogImpl::eventSnoop(GdkEvent*)': ../../src/ui/dialog/input.cpp:1917:16: error: enumeration value 'GDK_SOURCE_KEYBOARD' not handled in switch [-Werror=switch] ../../src/ui/dialog/input.cpp:1917:16: error: enumeration value 'GDK_SOURCE_TOUCHSCREEN' not handled in switch [-Werror=switch] ../../src/ui/dialog/input.cpp:1917:16: error: enumeration value 'GDK_SOURCE_TOUCHPAD' not handled in switch [-Werror=switch] cc1plus: some warnings being treated as errors
Did you check this in before fixing it? Receiving tons of mail by the build bots is annoying.
Regards, Markus
-----Ursprüngliche Nachricht----- Von: Johan Engelen [mailto:jbc.engelen@...2592...] Gesendet: Samstag, 22. März 2014 13:25 An: su_v; Inkscape-Devel Betreff: Re: [Inkscape-devel] Warnings check
With clang, can you try again without (after bzr up) -Wno-error=return-type -Wno-error=self-assign -Wno-error=parentheses-equality
Thanks, Johan
On 22-3-2014 12:42, su_v wrote:
On 2014-03-21 19:39 +0100, Johan Engelen wrote:
Hi all, I'd like people to check what compiler errors are reported for trunk on their system (Windows I can do myself), with these flags:
-Wall -Wformat -Werror=format-security -W -Wpointer-arith -Wcast-align -Wsign-compare -Woverloaded-virtual -Werror=switch -Werror=return-type -Werror -Wno-error=pointer-sign -Wno-error=unused-parameter -Wno-error=unused-but-set-variable -Wno-error=strict-overflow -Wno-error=write-strings -Wno-error=format -Wno-error=format-extra-args
Please no comments about whether you like these flags or not, just what build *errors* you get. (don't send me the warnings please!)
Attached are two diffs which allowed to compile successfully with:
- clang 3.1 (based on LLVM 3.1svn)
- GCC 4.2.1 (llvm-gcc-4.2)
(don't use both at the same time)
Notes:
clang diff was tested with dbus enabled, llvm-gcc-4.2 without.
cast-align warnings from boost headers are suppressed with #pragma
I failed to disable Werror for the warnings from lcms1 with
llvm-gcc-4.2, so the build was allowed to use lcms2 instead.
No tests have been run with experimental GTK3.
The warnings which had to be turned off have comments referring to
the files where the error occurred. If you need more detailed error logs, let me now.
- Ideally, the section in configure.ac would be converted into a loop
so that each flag gets tested individually whether the compiler supports it or not. I didn't spend time trying to figure out how to do that. For testing, those that fail can be individually commented out.
-- Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel