Hi Vlada!
I reply to the list to get more opinions. Reply you inline:
On Thu, 2016-10-27 at 14:35 +0200, Vladimir Savic wrote:
Hi Jabier,
Tested! I am speechless! It works better then I anticipated! Great work!!!
There i one really serious drawback of selected method for entering rotation mode. I don't use spacebar for panning. So I can't even start rotating. Here is a little analyze.
Bugs:
- If I use CTRL while rotating, and release CTRL, I leave rotation
mode. It is unwanted behavior, I suppose.
Yes need to fix it
- If I Right mouse button (RMB) click at any object (with Spacebar
panning turned on) I am being presented with Contextual menu. That would be the same one that appears when RMB clicked at any object in regular editing mode. You can see that briefly in a video I'll mention later.
Need to fix, if finnaly could do, rotation mode start on click, not on mouse move
- The video I have attached shows a few problems I have experienced
during testing phase. Don't know from where it comes from, but I see some crazy tiles being wrongly redrawn. See the video for yourself.
Is strange, could you provide me the SVG?
Minor bug: 4) With transparency checkerboard pattern turned on (Document Properties...->Checkerboard background), the checkerboard rotates too. Nothing urgent.
To fix
Some of my ideas. Please, at least consider them.
Facts:
- Middle mouse button (MMB) is already used for panning.
- MMB + SHIFT brings you into "clumsy" zoom mode. I say clumsy
because you could only zoom in marking the area you want to see zoomed-in. This is relevant for what I've written later... 3) CTRL and ALT are unused.
Here is my proposition: For entering Rotate view, I propose ALT + MMB or ALT + Spacebar- panning
Not sure maybe I need more opinions
Make ALT default modifier for constraining to whole degrees (1-2-3-4-etc.) since it will already be pressed. If user releases ALT, then go to subdivision of degrees. No need for another shortcut only for that. With CTRL + ALT you could then go to reset rotation. Additionally, with SHIFT + CTRL + ALT you could reset to 0 degrees.
Also we need the 5 degree modifier
All covered. :)
Additional features you could cover and it is something that I felt would be great if implemented. You could also make quick zoom mode using SHIFT + MMB. Take a rendering of surface (as you already do for rotation screen drawing and if user moves (while holding both SHIFT + MMB down) mouse upwards or right - zoom-in and if he/she moves it downwards or left zoom out using the fastest to redraw method (nearest neighbor, would be enough). After that, redraw the whole screen, as you already do in rotate on-screen widget.
Is cool but: Zoom in loose resolution, Zoom out couldent render outside the original view.
BTW, I really like the music on top of which you demonstrate your achievements. Keep on rocking! :)
Rock On
Regards, Vlada
https://www.dropbox.com/s/vfrun9s1gwubg09/Rotation_test.ogv?dl=0
On Wed, Oct 26, 2016 at 4:45 PM, Jabier Arraiza <jabier.arraiza@...2893...> wrote:
You are welcome!
On Wed, 2016-10-26 at 14:33 +0000, Vladimir Savic wrote:
Thanks Jabier!
This is indeed much better. I'm now really prepared to test this. Will try your brach ASAP.
Thanks again. :-)
On Wed, Oct 26, 2016, 16:14 Jabier Arraiza <jabier.arraiza@...3394... .es> wrote:
Here are: https://youtu.be/wKY-6OwjELI
Cheers, Jabier.
On Wed, 2016-10-26 at 13:37 +0200, Vladimir Savic wrote:
May I see how does that look like? Do you have a video?
Vlada
On Wed, Oct 26, 2016 at 12:32 PM, Jabier Arraiza <jabier.arraiza@...2893...> wrote:
Forget me! Now the circle is fadding to result progresive like usual redraw, so you keep visual reference to the result.
Cheers, Jabier.
On Wed, 2016-10-26 at 10:05 +0200, Vladimir Savic wrote: > Hi, Jabier. > > I somehow suspected it is like that, unfortunately. > Thanks > for > your > answer, though. > > Regards, > Vlada