On Feb 19, 2012, at 10:35 AM, Jon Cruz wrote:
On Feb 19, 2012, at 9:23 AM, Krzysztof Kosiński wrote:
action.h: can be remplaced with Gtk::Action if the icon cache system is slightly modified, so that the icon cache matches the directory structure of icon themes. The only reason this exists is because icons pulled from icons.svg need special handling. However, thanks to Jon's work on caching the icons as PNG, this is no longer necessary.
Minor point.
The reason also comes from legacy where Inkscape added the 'action' concept before GTK+ itself added GtkAction.
Gives you a clue as to how much some of this stuff needs a cleanup pass, huh?
:-)
Oh, the pertinent information for anyone wanting to clean this one up is to focus on the integration with a 'Verb'.
One should look at if it is better to create a simple subclass of GtkAction that is verb aware, or if we should go with some form of factory/helper that creates a GtkAction instance given a Verb, and then wires it up to the Verb using additional callbacks and helpers. Going with the latter, one might even integrate it with the Verb class itself.