On Tue, 28 Mar 2006 02:42:45 -0800, "Jon A. Cruz" <jon@...18...> wrote:
Next rough, kludgy update has been committed.
Now if objects have a "HOTFill" or "HOTStroke" attribute that matches the color's index and palette name, those objects will get their stroke and fill updated when the color changes.
This isn't acceptable. Please revert the commit or at least move the attributes into our namespace.
Do not knowingly commit stuff that is broken (in this case violating our SVG compliance policy) to trunk. Incomplete, fine, but not broken, and especially not violating core SVG practices.
Again, the mechanism here is a temporary kludge.
I'm going to be a little stronger than bulia: no more major kludges please. Try to stick to prototyping.
There is a difference between prototyping/scaffolding (which may be incomplete, but works as far as it goes and whose design is provisionally good [i.e. comitting may be needed to evaluate it]) and a kludge (which has severe known flaws from the beginning, with the advance expectation of backing it out later).
Despite your best intentions, you've got a history of comitting "temporary" stuff that you subsequently fail to clean up. I think you need to be realistic: when committing, take into account the possibility that you may get interrupted.
I do _not_ want to see yet another release blocked waiting for you to clean up something you comitted knowingly broken, only to eventually have to excise it myself and then get bug reports when people find lingering bits I missed removing.
-mental