-----Original Message----- From: Jasper van de Gronde [mailto:th.v.d.gronde@...528...] Sent: 20 April, 2009 22:54 To: Preben Soeberg Cc: inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] bugfix for divisor default (was: The bias property for feConvolveMatrix)
Preben Soeberg wrote:
I have posted a patch for
https://bugs.launchpad.net/inkscape/+bug/193926
The patch fixes the divisor to be calculated automatically by default.
Could you take a look at it and commit it?
I've had a look and in principle the fix to the sp-feconvolvematrix code seems fine. But:
- Could you perhaps base the fix on a more recent version?
sp-feconvolvematrix.cpp no longer exists (it is now src/filters/convolvematrix.cpp).
- I have hardly any experience with the UI code, so if someone else
could take a look at that part that would be great. (Otherwise, if you'll update the patch I'll just try it and commit it if it seems to work.)
Thanks for your efforts.
The patches are made on the correct and newest files, and I have tested them thoroughly.
I made a mistake, when editing in the patch (removed irrelevant changes in other files), so I have updated and posted it again.