Hi,
Not sure if I qualify as maintainer, but I guess my main concern is that we don't unnecessarily increase the delta against upstream. We may be better off just suppressing harmless warnings (unused args/variables etc) than fixing them in-tree. If we do fix things, we should try to follow GNOME style etc, and submit patches upstream where possible.
Really, the best "solution" is to work towards closing bug #648246 [1]. The next task is to strip out all the non-essential fixes from the Libcroco_0.6.8 -> Inkscape_trunk patch [2] and forward the remaining chunks. After that, we can build against an external lib and we won't have to worry about maintaining the fork any more :)
AV
[1] https://bugs.launchpad.net/inkscape/+bug/648246 [2] https://launchpadlibrarian.net/155708206/inkscape-changes-0.6.8.diff
On 22 March 2014 12:33, Johan Engelen <jbc.engelen@...2592...> wrote:
On 22-3-2014 13:27, Krzysztof Kosiński wrote:
2014-03-21 18:48 GMT+01:00 Johan Engelen <jbc.engelen@...2592...>:
To the maintainer of our libcroco copy,
Please have a look at rev. 13178, where I fixed errors in pointer type signed-ness (Glib functions like g_strdup want a gchar*, not a guchar*).
I guess you'd want to upstream the small change.
I don't think there is a "maintainer" on our side for any of the in-tree libraries.
We do. lib2geom and libuemf I am certain about. Alex Valavanis has been working on synchronizing libgdl, and also libcroco recently.
- Johan
Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel