On 26/01/2013 17:37, Alexandre Prokoudine wrote:
On Sat, Jan 26, 2013 at 6:07 PM, Kris De Gussem <kris.degussem@...400...> wrote:
Hi all
Upon crawling through the source code for memory related issues, I noticed some serious issues in the dxf2svg code. Modifying the code (at least in entities2elements.cpp) did not result in recompilation and apparently the code has not been looked after for years (see [1]) and was since long excluded from the building system ([2], [3] and [4]). Is there still some purpose for the code or could we drop the dxf2svg extension code from the source tree?
Excuse me, but do you realize that you are looking at the SVN code repository which we haven't used for, like, 4 years? :)
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/changes?filter_file...
Excuse me - do you realize that the references to the SVN repository are there because 'src/extension/dxf2svg' doesn't appear to have been touched in years, certainly not after the move to bazaar and launchpad (beyond some recent changes based on cppcheck warnings and a few other global changes to header files)? http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/files/head:/src/extension/dxf2svg/ http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/view/head:/src/extension/dxf2svg/README
Since the commit history in bazaar is not going back far enough, one needs to undig the changes in SVN…
The file your link refers to is a python-based input extension script which AFAICT is unrelated to the C++ code in 'src/extension/dxf2svg', originating from an earlier GSoC project (2005) aiming to implement dxf import as library (internally):
- DXF Import / Export - Matthew Squires http://wiki.inkscape.org/wiki/index.php/SOC_Accepted_Proposals