Ted,
I noticed you made some changes to the effects UI, and I tested them. Here are the problems I found. I think they are quite serious, especially the crash, and must be fixed before the release, so I also made a critical bug https://bugs.launchpad.net/inkscape/+bug/191772
On Oct 15, 2007 1:35 PM, bulia byak <buliabyak@...400...> wrote:
When "Dialogs for Export and extension effects stay open after Apply" in prefs is on (default), the behavior is:
I didn't find this setting - did you find it? I assume it work as if it's on, as the default should be.
Replace close/ok/execute buttons with two buttons: Apply and Close (in that order). Remove "pin" checkbox. When live preview is off, make dialog non-modal and allow to change selection at any time; Apply would then just apply to the current selection but not close.
This is correctly done, but the button says OK, not Apply. This is misleading - can you please rename it to Apply?
Bug: if I use Close button to close dialog, I can then open the same extension dialog again. But if I just click the X button in the title bar, next attempt to call the extension does nothing - the window does not show (linux, kde). Only restarting the program fixes this.
When live preview is on, dialog is modal, but you can preview the effect of parameters on the current selection; and when you click Apply it not only applies the effect but _also_ unsets the Live preview, unlocking the dialog to enable new selections.
This does not quite work. I check preview box, and it starts to preview, but pressing OK does not uncheck it. Moreover, now even Close does not close the dialog! Only the titlebar button closes it, after which it cannot be open again (see bug above).
Worst bug of all: do this:
- launch
- draw a path with pencil
- effects/modify path/add nodes
- turn on preview checkbox
- click close (it does not)
- click preview checkbox again - crash:
** (inkscape:14033): CRITICAL **: void Inkscape::GC::Anchored::release() const: assertion `_anchor' failed
Program received signal SIGSEGV, Segmentation fault. [Switching to Thread -1235330848 (LWP 14033)] IA__g_main_loop_quit (loop=0x2f656c61) at gmain.c:2920 2920 g_return_if_fail (g_atomic_int_get (&loop->ref_count) > 0); (gdb) bt #0 IA__g_main_loop_quit (loop=0x2f656c61) at gmain.c:2920 #1 0xb7c00a17 in Glib::MainLoop::quit (this=0xb75648ef) at main.cc:614 #2 0x0850a1cc in Inkscape::Extension::ExecutionEnv::livePreview (this=0xad28d30, state=false) at extension/execution-env.cpp:302 #3 0x0850bc35 in Inkscape::Extension::PrefDialog::preview_toggle (this=0xa7d90a8) at extension/prefdialog.cpp:161 #4 0x08500ac4 in Inkscape::Extension::ParamBoolCheckButton::on_toggle (this=0xac638b0) at signal.h:544 #5 0xb7c05986 in Glib::SignalProxyNormal::slot0_void_callback (self=0xb75648ef, data=0xaabf3f8) at slot.h:440 #6 0xb7776e33 in IA__g_cclosure_marshal_VOID__VOID (closure=0xaabf428, return_value=0x0, n_param_values=1, param_values=0xbfae3e7c, invocation_hint=0xbfae3d6c, marshal_data=0x8082770) at gmarshal.c:77 #7 0xb776af6f in IA__g_closure_invoke (closure=0xaabf428, return_value=0xb75648ef, n_param_values=3075885295, param_values=0xb75648ef, invocation_hint=0xb75648ef) at gclosure.c:490 #8 0xb777a22c in signal_emit_unlocked_R (node=0x9246468, detail=0, instance=0x95c5008, emission_return=0x0, instance_and_params=0xbfae3e7c) at gsignal.c:2510 #9 0xb777b559 in IA__g_signal_emit_valist (instance=0x95c5008, signal_id=139, detail=0, var_args=<value optimized out>) at gsignal.c:2199 #10 0xb777b8c9 in IA__g_signal_emit (instance=0xb75648ef, signal_id=3075885295, detail=3075885295) at gsignal.c:2243 #11 0xb7a85421 in IA__gtk_toggle_button_toggled (toggle_button=0x95c5008) at gtktogglebutton.c:305 #12 0xb7a857be in gtk_toggle_button_clicked (button=0x95c5008) at gtktogglebutton.c:438 #13 0xb7e3a031 in Gtk::Button::on_clicked (this=0xac638b0) at button.cc:758 #14 0xb7e3904d in Gtk::Button_Class::clicked_callback (self=0x95c5008) at button.cc:268 #15 0xb7776e33 in IA__g_cclosure_marshal_VOID__VOID (closure=0x8d64330, return_value=0x0, n_param_values=1, param_values=0xbfae43ec, invocation_hint=0xbfae42dc, marshal_data=0xb7e38fc2) at gmarshal.c:77