Hi all, Yesterday I changed the compiler flags to now error on incomplete switch statements (-Werror=switch). Because of this, a buildbot found a tiny bug with GTK3:
CXX ui/dialog/input.o ../../src/ui/dialog/input.cpp: In member function 'bool Inkscape::UI::Dialog::InputDialogImpl::eventSnoop(GdkEvent*)': ../../src/ui/dialog/input.cpp:1917:16: error: enumeration value 'GDK_SOURCE_KEYBOARD' not handled in switch [-Werror=switch] ../../src/ui/dialog/input.cpp:1917:16: error: enumeration value 'GDK_SOURCE_TOUCHSCREEN' not handled in switch [-Werror=switch] ../../src/ui/dialog/input.cpp:1917:16: error: enumeration value 'GDK_SOURCE_TOUCHPAD' not handled in switch [-Werror=switch]
First: jay! for buildbots!
The actual error is not too bad, just needs someone to look over the new GDK_SOURCE_s and figure out how to handle them there, with an #ifdef for GTK3.
Jon, can you have a look?
Thanks for fixing this, Johan