On 2011-04-09 0:12, Krzysztof Kosiński wrote:
W dniu 8 kwietnia 2011 23:46 użytkownik Johan Engelen <jbc.engelen@...2592...> napisał:
Cool. I have committed my build fixing changes. One final required thing I did not commit: I disabled some code in win32.cpp to get a complete build. But it really needs to be fixed, instead of disabled. Can you look into this Krzysztof?
/src/extension/internal/win32.cpp line 316 line 334 etc, use pixblocks, and should be converted to cairo stuff.
This has something to do with printing. I thought we were using Cairo and GtkPrint for this. Does anyone know how printing is done on Windows?
I just had a look (on Windows of course) and as far I can tell this code is unused. I can cut it out (as well as all relevant references and id's that I've been able to find) and I can still print. Apparently it used to have some function, and we even had a print preview and such, but I think at some point this was superseded by a new system and the old stuff was just left. In file.h there is even a comment that some print(preview) related functions are probably redundant, which apparently dates back to SVN(!!!) revision 1600-something.
In short: I'd like to try and cut out some of this apparently unused code, cleaning up our code base and "fixing" an issue with the cairo branch at the same time. But, it seems a little scary to just remove a whole lot of code that apparently at least used to have some function, so if anyone has a reason to keep this code around, please let me know.