On Mon, 2007-09-03 at 16:59 -0300, bulia byak wrote:
On 9/3/07, Ted Gould <ted@...11...> wrote:
The reason that I used the term "pin" is because I think it's been widely used previously. Many window managers allow you to do things like pin menus or pin windows on all desktops.
I may be wrong, but it seems to be something specific to X Window. I never used that, but I always thought it's something that fixes the _position_ of the dialog. How is this relevant here?
Well, the concept of a Window Manager in general is pretty specific to X Windows ;) I was thinking of the concept as pinning the dialog is locking it. For instance, pinning a menu keeps it open no matter what you do -- here we're pinning the dialog open. Making it "sticky" per se.
Some even have an icon of a push pin in the title bar. I'm not stuck on this terminology, but I thought it described what was happening well :)
I'm not sure. What is being pinned here and how? From my viewpoint, the only effect of this checkbox is that it allows me to change selection without closing it (and disables preview). The dialog itself does not change in the slightest.
Well, the buttons change name also :)
I think the significant change, is what happens when you hit "OK" (or "Execute"). In the case where the dialog is unpinned the results are: the effect is executed and the dialog is closed. In the pinned case: the effect is executed and the dialog is left open.
But, do we need this at all? Can we make it non-modal always, and still allow live preview? That would be the perfect solution.
I'm not quite sure how that'd work. In essence we'd have to have some sort of document locking as the undo buffers would end up in a weird state. Plus, I'm not sure how it'd work with effects that require the selection of multiple objects.
OK, here's an idea. If your "pin" diables preview anyway, then why not make the Preview checkbox control both modes:
when it's on, you get live preview and the dialog is modal.
when it's off, you get no preview but the dialog is not modal and
you can change selection.
I think this would be the best functionality compromise without confusing UI.
I'm not against this but I'm not sure about it. My beef is that I think there might be a use case for someone who doesn't want live preview but does want the dialog to close on execution. What do you think? You were against automatic live preview before, I'm not sure that's not what we're pushing people towards with this change.
I think that it's very funny that you're questioning this Mr. "I don't want my export dialog to close when I hit 'export'" :) It's basically the same feature that I'm cloning here.
Of course I'm all for the _feature_ itself. I'm just against the extraneous and confusingly labelled UI :)
Well, we can change the text, what ever makes the most sense. Here's some other ideas:
"Close on Execute" "Lock Document" "Control Document" "Dialog on Top" "Effect Control" "Bulia Only" :)
--Ted