On 03/02/2012 14:28, ~suv wrote:
On 01/02/2012 22:06, ~suv wrote:
On 01/02/2012 21:46, Krzysztof Kosiński wrote:
2012/1/30 Alex Valavanis <valavanisalex@...400...>:
There are only two remaining open bugs that are tagged for 0.48.3 milestone[1,2]. Are we planning to backport any of the remaining "backport-proposed" bugs?[3] Is it worth having a mini backporting-sprint? (...) [3] https://bugs.launchpad.net/inkscape/+bugs?field.tag=backport-proposed
There are 7 remaining "backport-proposed" bugs. One of them is the unfixed bug about extensions on OSX, which I can't work on.* The other 6 are related WMF/EMF export and all have fixes in trunk. I will try to backport the WMF/EMF fixes shortly.
The report has a patch which I have verified to work with the official package (0.48.2) on OS X Lion as well tested on Mac OS X Leopard to not have a negative effect on other platforms. The patch inserts a single line of code into a shell script inside the application bundle (no recompiling and repackaging needed to test).
It has been confirmed by two other users as well.
Committing to trunk should be save, and back-porting as well (I'd rather have raised importance to 'High' because it also affects several input/output extensions).
Done (r10951 in trunk, r9866 in 0.48.x)
What is still missing in the 0.48.x branch and needs confirmation by Michael IMHO are the changes (in trunk) to one of the packaging scripts (packaging/macosx/osx-app.sh), used to fill the bundle with files from MacPorts (due to changed locations of the gdk-pixbuf configuration files and loaders): https://bugs.launchpad.net/inkscape/+bug/819209/comments/13 http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/10026
Done (r9868 in 0.48.x)
Other issues related to OS X packaging only:
- GTK+ 2.24.9 (current version in MacPorts)
Due to a recent regression in GTK+ 2.24.9: Bug 543520 – Cups custom options are not sent properly: https://bugzilla.gnome.org/show_bug.cgi?id=543520#c39 Inkscape 0.48.2, 0.48.x and trunk crash with GTK+ 2.24.9 when trying to print (print preview and printing to file seem ok).
Before building and bundling the application package, I would recommend to revert to gtk2 @2.24.8 in MacPorts or rebuild and test the port using a local patch from the gtk-2.24 branch: http://git.gnome.org/browse/gtk+/commit/?h=gtk-2-24&id=66c99016d3d063aee0e00793da8f087c80172012
GTK+ 2.24.10 has been released in the meantime and is available in MacPorts. It includes the fix to avoid the crash when printing, but now instead of crashing, Inkscape (stable and trunk) fails to print at all for me (printing works in gtk-demo, and when printing a PDF file saved in Inkscape with Evince, all using the same GTK+ stack). Based on my (limited) tests [1] I would still recommend to use 2.24.8 for the application package - if printing directly from Inkscape is considered as important.
[1] GTK+/X11 2.24.10 on Lion, GTK+/Quartz 2.24.10 on Leopard Brother HL-2035 B&W Laser Printer (A4)
- Cairo 1.10.2 in MacPorts
Cairo (and cairo-devel) in MacPorts have xcb and xlib-xcb enabled unconditionally (the variant is fake for legacy reasons) while the cairo developers do not consider it as stable yet (planned for cairo 0.12 AFAIU). This is the reason why Inkscape.app crashes for users on Mac OS X 10.5.8 Leopard with Apple's default X11 installed (no xcb support) even though the bundle was built and packaged on Leopard [2].
'xlib-xcb' also causes rendering errors in the GUI (text overspilling into other widgets if auto-hinting is enabled [1], incorrect rendering of shades and gradients e.g. for scrollbar sliders and button states on Lion (not reported)). I would recommend to rebuild the cairo port locally and disable all xcb options before creating the application bundle.
(Personally, I'm using cairo 1.10.2 with '--enable-xlib-xcb' removed from the portfile (local repo) on OS X Lion, and haven't noticed any drawbacks due to the change).
- gdk-pixbuf.loaders (from gdk-pixbuf-2.22.1)
Inkscape.app (0.48.2) has a small regression compared to 0.48.1: it appears that due to a missing entry for SVG in the gdk-pixbuf.loaders file, Inkscape fails to load external SVG files linked to with the <image> tag (works ok with Inkscape.app (0.48.1)). For details please see comments #31 and #32 in Bug #168244 “image tag does not find SVG source” [3].
- outdated custom theme file
Bug #875577 “[osx] Clearlooks configuration option "menuitemstyle" is not supported and will be ignored” [4] has a patch for the custom theme file used by the bundled application, updating it to the newer version of the Clearlooks engine (certain old settings are no longer supported). Patch was done with intention to keep visual appearance unchanged.
I also disabled the button and menu icons (not used in native apps, AFAICT) - both can be re-enabled by changing the value to '1' for 'gtk-button-images' and 'gtk-menu-images', at the bottom of pre_gtkrc.
Please test and consider for inclusion.
[1] https://bugs.launchpad.net/inkscape/+bug/625668 [2] https://bugs.launchpad.net/inkscape/+bug/878368 [3] https://bugs.launchpad.net/inkscape/+bug/168244 [4] https://bugs.launchpad.net/inkscape/+bug/875577