I've also added a few points to the "issues", and added a new section for "deferred changes", which would probably be too messy to implement before we completely kill our Gtk+ 2 support.

AV

On 3 May 2016 at 08:43, Krzysztof Kosiński <tweenk.pl@...400...> wrote:

I added some more information.

I think the icon clipping bug may be related to the use of SPIcon. If we can replace that with GtkImage, it might go away.

2016-05-02 0:19 GMT-07:00 Olof Bjarnason <olof.bjarnason@...400...>:

...

Hi Martin,

I added a couple of issues.

http://wiki.inkscape.org/wiki/index.php/Gtk_issues#Issues

Mvh

/Olof

Är du systemutvecklare? Spana in https://cilamp.se

On 2 May 2016 at 01:44, Martin Owens <doctormo@...400...> wrote:

...

This is a reminder about the Gtk3 issues page:

http://wiki.inkscape.org/wiki/index.php/Gtk_issues

We need all developers who do anything with gtk to help fill in the page to document what we've learned and communicate to gnome developers how it could be better.

Thank you for listening to this reminder.

Best Regards, Martin Owens

---

Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel

---

Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel

---

Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel

Thanks Tav, that's great news. Completely agreed that we should unify a lot of our icon handling code. Krzysztof and I discussed this briefly at the Hackfest. I think we should seriously consider moving towards a more standard way of installing our icon theme.

Our current method of pulling multiple icons in from a single SVG document is perhaps a more "Inkscape-esque" way of doing things than reading from individual SVG/bitmap icon files. However, it's not very friendly for GNOME theme designers and requires quite a lot of custom code rather than being handled simply through a GtkIconTheme instance.

AV

On 4 May 2016 at 10:35, Tavmjong Bah <tavmjong@...8...> wrote:

On Tue, 2016-05-03 at 00:43 -0700, Krzysztof Kosiński wrote:

...

I added some more information.

I think the icon clipping bug may be related to the use of SPIcon. If we can replace that with GtkImage, it might go away.

I fixed this in r14870. The icon clipping is due to wrapping the icon in a widget where the preferred width/height of the widget was calculated by adding the preferred width/height of the icon to the border width. By also adding the padding width the icons are no longer clipped.

I am not sure why we need to be concerned with border/padding widths. In a style sheet based framework, border/padding/margin should be taken care of automatically.

One thing I observed in tracking this problem down is that we have many ways to turn icons into buttons. We should try to unify these as we move to GTK3.

Tav

---

Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel

On Wed, 2016-05-04 at 14:23 +0200, Tavmjong Bah wrote:

We use gtk_icon_size_register() to add a custom logical icon size to the GtkIconSize enum. This is deprecated. The documentation says to use GtkIconTheme instead. But GtkIconTheme (using physical icon sizes) returns a GdkPixbuf. To get a GtkImage widget, one can use gtk_image_new_from_pixbuf() but the comment states that this widget will not react to state changes. If you want it to react to state changes use gtk_image_new_from_icon_name()... which requires passing a GtkIconSize.

Would it work if you packed the GtkImage into a GtkEventBox?

src/widgets/desktop-widget.cpp:448

Martin,