Re: [Inkscape-devel] Cppify Branch Review
That's the same problem as with the clipboard, but thistime, Krzysztofs return-solution won't work ;) . The patch is essentially the same I appended in this bugreport, I attached the version adjusted for grids.
Regards, Markus
-----Ursprüngliche Nachricht----- Von: suv@...2204... [mailto:suv@...2204...] Im Auftragvon su_v Gesendet: Freitag, 20. September 2013 13:56 An: Krzysztof Kosiński Cc: Markus Engel; inkscape-devel Betreff: Re: [Inkscape-devel] Cppify Branch Review
On 2013-09-19 04:09 +0200, Krzysztof Kosiński wrote:
There are basically two issues which stand out:
- Inconsistent whitespace
- Use of explicit this-> instead of markingmember variables with a
leading underscore.
However, I think these two stylistic problems can befixed later and it's better to commit now than to wait and let thisimportant work get out of sync with trunk.
I committed the merge as revision 12532.
After the merge in r12532 'File > Document Properties> Grids' no longer display the settings for defined grids (works withr12531, fails with r12532).
Steps to reproduce: 1) launch Inkscape (default prefs, default new doc) 2) toggle on grid (menu 'View > Grid') to create adefault grid 3) open 'File > Document Properties > Grids' toedit the settings
Expected result: The settings for the new grid are accessible on the'Grids' page
Actual result: The 'Defined grids' section is empty.
Warning on the console: ** (inkscape-12532:13355): WARNING **: TypeNotRegisteredexception: inkscape:grid
(tested and confirmed on Ubuntu 12.10 and OS X 10.7.5)
Patch tested successfully with r12550 on OS X 10.7.5 (GTK+/Quartz 2.24.21, gtkmm 2.24.4, glib 2.36.4, glibmm 3.36.2):
Using STR described earlier, the settings for defined grids are visible again and work as expected.
On 2013-09-20 14:21 +0200, Markus Engel wrote:
That's the same problem as with the clipboard, but this time, Krzysztofs return-solution won't work ;) . The patch is essentially the same I appended in this bug report, I attached the version adjusted for grids.
Regards, Markus
-----Ursprüngliche Nachricht----- Von: <!-- snip --> Im Auftrag von su_v Gesendet: Freitag, 20. September 2013 13:56 An: Krzysztof Kosiński Cc: Markus Engel; inkscape-devel Betreff: Re: [Inkscape-devel] Cppify Branch Review
On 2013-09-19 04:09 +0200, Krzysztof Kosiński wrote:
There are basically two issues which stand out:
- Inconsistent whitespace
- Use of explicit this-> instead of marking member variables with a
leading underscore.
However, I think these two stylistic problems can be fixed later and it's better to commit now than to wait and let this important work get out of sync with trunk.
I committed the merge as revision 12532.
After the merge in r12532 'File > Document Properties > Grids' no longer display the settings for defined grids (works with r12531, fails with r12532).
Steps to reproduce:
- launch Inkscape (default prefs, default new doc)
- toggle on grid (menu 'View > Grid') to create a default grid
- open 'File > Document Properties > Grids' to edit the settings
Expected result: The settings for the new grid are accessible on the 'Grids' page
Actual result: The 'Defined grids' section is empty.
Warning on the console: ** (inkscape-12532:13355): WARNING **: TypeNotRegistered exception: inkscape:grid
(tested and confirmed on Ubuntu 12.10 and OS X 10.7.5)
2013/9/20 Markus Engel <p637777@...1081...>:
That's the same problem as with the clipboard, but this time, Krzysztofs return-solution won't work ;) . The patch is essentially the same I appended in this bug report, I attached the version adjusted for grids.
Applied in r12552.
I have two comments:
1. The hack is still in use for RDF metadata, since we would require lots of objects which aren't really useful (all manipulation of RDF is via XML)
2. It should be possible for the object tree not to correspond 1:1 to the XML tree. For example, some should be capable of maintaining a SVG-compliant fallback using svg:switch, but this svg:switch should not appear in the SP tree.
Regards, Krzysztof
participants (3)
-
Krzysztof Kosiński -
Markus Engel -
su_v