Hey Devs,
In r12550 I had to do more changes then I expected fixing bug lp:1199192 and I want to FYI them here.
At first I thought the broken collection status was from my previous work. But it turned out the functionality had been gutted by refactoring work from elsewhere. (C++ification I think)
So I decided to continue the work and re-factored this too. Each object now has a new display_name() method which returns a translated const char* for use in the status bar. description() now returns everything but the display_name (some fixes in consistency here too) and getDetailedDescription returns the whole lot plus mask/clip info.
This getDetailedDescription is used in the single item status bar and replaces the vanilla description(). This should improve information about clip/mask and give more consistency for single items.
display_name() is used to get a list of types. That code was shorted too, made more dynamic.
-200 Lines +171 Lines
Best regards, Martin Owens
2013/9/20 Martin Owens <doctormo@...400...>:
Hey Devs,
In r12550 I had to do more changes then I expected fixing bug lp:1199192 and I want to FYI them here.
At first I thought the broken collection status was from my previous work. But it turned out the functionality had been gutted by refactoring work from elsewhere. (C++ification I think)
So I decided to continue the work and re-factored this too. Each object now has a new display_name() method which returns a translated const char* for use in the status bar. description() now returns everything but the display_name (some fixes in consistency here too) and getDetailedDescription returns the whole lot plus mask/clip info.
This getDetailedDescription is used in the single item status bar and replaces the vanilla description(). This should improve information about clip/mask and give more consistency for single items.
display_name() is used to get a list of types. That code was shorted too, made more dynamic.
I think you should use displayName() and detailedDescription() to have some sort of consistency in the method names.
Regards, Krzysztof
participants (2)
-
Krzysztof Kosiński
-
Martin Owens