-----Original Message----- From: Gustav Broberg [mailto:broberg@...370...] Sent: woensdag 16 januari 2008 4:00 To: Engelen, J.B.C. (Johan) Subject: Re: [Inkscape-devel] Dockable dialog bugs

On Tue, Jan 15, 2008 at 05:17:45PM +0100, J.B.C.Engelen@...1578... wrote:

...

OK, I just came up with a solution for our problems and

tested it on

...

one of the parameter types. This seems to work very very nicely and can be generalized to all "registered widgets". I will try

to do this asap.

That's great news Johan! After your changes I'm not able to reproduce #179982 anymore.

I'm not familiar enough with the registered widgets to evaluate the class design, but just looking diffs themselves, I can't see any problems with it. One minor nit though, couldn't the static cast line in RegisterRandom::setValue be replaced with just "Scalar::setValue (val);"?.

First I had "setValue(val)" there without any cast, but the compiler could not find the Scalar function. I can try what you say as it seems better.

Do you think you'll be able to rewrite the remaining widgets and completely deprecate the old RegisteredWdg in time for the release?

Just tell me if I should prepare a Plan B, e.g. to make just the Document Properties and LPE dialog singleton as you suggested...

I hope I can finish the work today, luckily it will not show up in the bug fixing points scheme, so there's still some time. I often stumble upon bugs that still need reporting/fixing :(, was really glad this one turned out to be fixable pretty fast.

Regards, Johan