Fix for #601336 (Pattern rotation crash)
![](https://secure.gravatar.com/avatar/05c543fd064cf80de43fcaaf05a528c8.jpg?s=120&d=mm&r=g)
Hi all,
I came up with a fix for this week's bug of the week ( https://bugs.launchpad.net/inkscape/+bug/601336 ). However, I'm bringing it up here for two reasons:
1. It's a fairly large patch (and it modifies sp-item.h) 2. It introduces new, little-tested functionality
I'm more concerned about the second item on the list. The fix was to introduce separate knots for stroke and fill patterns, and to make stroke pattern transformations independent of fill transformations. If anyone has time, I'd appreciate any feedback.
The diff is attached. If for some reason you can't download it, I've also pastebinned it here: http://paste.debian.net/113020/
Thanks, Liam
![](https://secure.gravatar.com/avatar/05c543fd064cf80de43fcaaf05a528c8.jpg?s=120&d=mm&r=g)
Due to total silence, I went ahead and committed this fix in lp:inkscape r13489 to get it some exposure.
![](https://secure.gravatar.com/avatar/516640127f084752aaf5f23c7119f1be.jpg?s=120&d=mm&r=g)
On Mon, 2014-08-04 at 12:15 -0400, Liam White wrote:
Due to total silence, I went ahead and committed this fix in lp:inkscape r13489 to get it some exposure.
That is sometimes the best way. We should review each other's code more, but often fixes will bitrot without a push into trunk or experimental (at this point). Get that code in other people's way! :-D
Keep up the good work Liam!
Martin,
participants (2)
-
Liam White
-
Martin Owens