With Bryce's permission, I have merged the experimental branch into trunk.
Trunk is now open for development. Please do not make further commits to experimental.
If you do not use a separate directory for build and source:
$ bzr pull lp:inkscape
…
Conflict: can't delete src/dialogs because it is not empty. Not deleting. 1 conflicts encountered. Now on revision 13641. $ rm -rf src/dialogs $ bzr revert
This should fix your local copy.
Great! I have immediately triggered a new build on Jenkins, let's see what happens with our warnings! :) http://ec2-54-69-235-61.us-west-2.compute.amazonaws.com:8080
cheers, Johan
On 30-10-2014 0:10, Liam White wrote:
With Bryce's permission, I have merged the experimental branch into trunk.
Trunk is now open for development. Please do not make further commits to experimental.
If you do not use a separate directory for build and source:
$ bzr pull lp:inkscape
…
Conflict: can't delete src/dialogs because it is not empty. Not deleting. 1 conflicts encountered. Now on revision 13641. $ rm -rf src/dialogs $ bzr revert
This should fix your local copy.
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Wed, Oct 29, 2014, at 05:45 PM, Johan Engelen wrote:
Great! I have immediately triggered a new build on Jenkins, let's see what happens with our warnings! :) http://ec2-54-69-235-61.us-west-2.compute.amazonaws.com:8080
FYI, Coverity reported
"102 new defect(s) introduced to inkscape found with Coverity Scan. 11 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan."
I think I see a rough correlation in the latest report on Jenkins, so that seems good. In a bit I'll be going over the newly added items to see if any new patterns emerge.
This sounds (and looks in the log) as an important step. I've never taken a look at the experimental branch but only heard about it in the mailing list. Is there a light list of major modifications and added features to look for and check out? I've just launched a clean build under Windows XP. Luca
-- View this message in context: http://inkscape.13.x6.nabble.com/Merge-of-experimental-branch-tp4971954p4971... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
On Thu, Oct 30, 2014 at 02:14:57AM -0700, LucaDC wrote:
This sounds (and looks in the log) as an important step. I've never taken a look at the experimental branch but only heard about it in the mailing list. Is there a light list of major modifications and added features to look for and check out?
We ought to have a list like this captured on the ReleaseNotes page for 0.92, while all the new stuff is fresh on folks minds. Could someone please set up a new page for our new development notes?
http://wiki.inkscape.org/wiki/index.php/Release_notes
Bryce
Updated and new page added. Liam and Jabiertxo should really tackle filling out info on the things they were responsible for creating or getting merged.
Cheers, Josh
On Thu, Oct 30, 2014 at 11:57 AM, Bryce Harrington <bryce@...961...> wrote:
On Thu, Oct 30, 2014 at 02:14:57AM -0700, LucaDC wrote:
This sounds (and looks in the log) as an important step. I've never taken a look at the experimental branch but only heard about it in the mailing list. Is there a light list of major modifications and added features to look for and check out?
We ought to have a list like this captured on the ReleaseNotes page for 0.92, while all the new stuff is fresh on folks minds. Could someone please set up a new page for our new development notes?
http://wiki.inkscape.org/wiki/index.php/Release_notes
Bryce
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Could anyone send me acces to the wiki. Prefered user "jabiertxof" Also the whiki sitem and any document created for editing inkspace wiki.
Thanks in advance. Jabiertxo.
El jue, 30-10-2014 a las 13:32 -0700, Josh Andler escribió:
Updated and new page added. Liam and Jabiertxo should really tackle filling out info on the things they were responsible for creating or getting merged.
Cheers, Josh
On Thu, Oct 30, 2014 at 11:57 AM, Bryce Harrington <bryce@...961...> wrote:
On Thu, Oct 30, 2014 at 02:14:57AM -0700, LucaDC wrote:
This sounds (and looks in the log) as an important step. I've never taken a look at the experimental branch but only heard about it in the mailing list. Is there a light list of major modifications and added features to look for and check out?
We ought to have a list like this captured on the ReleaseNotes page for 0.92, while all the new stuff is fresh on folks minds. Could someone please set up a new page for our new development notes?
http://wiki.inkscape.org/wiki/index.php/Release_notes
Bryce
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Done. You should receive an email from the wiki with your info.
The 0.92 page is http://wiki.inkscape.org/wiki/index.php/Release_notes/0.92 and http://wiki.inkscape.org/wiki/index.php/Release_notes/0.91 is a good reference for how the markup in the wiki works (if you go to edit the page you can see how the formatting works).
Cheers, Josh
On Thu, Oct 30, 2014 at 3:56 PM, Jabiertxo Arraiza Cenoz <jabier.arraiza@...2893...> wrote:
Could anyone send me acces to the wiki. Prefered user "jabiertxof" Also the whiki sitem and any document created for editing inkspace wiki.
Thanks in advance. Jabiertxo.
El jue, 30-10-2014 a las 13:32 -0700, Josh Andler escribió:
Updated and new page added. Liam and Jabiertxo should really tackle filling out info on the things they were responsible for creating or getting merged.
Cheers, Josh
On Thu, Oct 30, 2014 at 11:57 AM, Bryce Harrington <bryce@...961...> wrote:
On Thu, Oct 30, 2014 at 02:14:57AM -0700, LucaDC wrote:
This sounds (and looks in the log) as an important step. I've never taken a look at the experimental branch but only heard about it in the mailing list. Is there a light list of major modifications and added features to look for and check out?
We ought to have a list like this captured on the ReleaseNotes page for 0.92, while all the new stuff is fresh on folks minds. Could someone please set up a new page for our new development notes?
http://wiki.inkscape.org/wiki/index.php/Release_notes
Bryce
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
I'm on. thanks.
El jue, 30-10-2014 a las 16:03 -0700, Josh Andler escribió:
Done. You should receive an email from the wiki with your info.
The 0.92 page is http://wiki.inkscape.org/wiki/index.php/Release_notes/0.92 and http://wiki.inkscape.org/wiki/index.php/Release_notes/0.91 is a good reference for how the markup in the wiki works (if you go to edit the page you can see how the formatting works).
Cheers, Josh
On Thu, Oct 30, 2014 at 3:56 PM, Jabiertxo Arraiza Cenoz <jabier.arraiza@...2893...> wrote:
Could anyone send me acces to the wiki. Prefered user "jabiertxof" Also the whiki sitem and any document created for editing inkspace wiki.
Thanks in advance. Jabiertxo.
El jue, 30-10-2014 a las 13:32 -0700, Josh Andler escribió:
Updated and new page added. Liam and Jabiertxo should really tackle filling out info on the things they were responsible for creating or getting merged.
Cheers, Josh
On Thu, Oct 30, 2014 at 11:57 AM, Bryce Harrington <bryce@...961...> wrote:
On Thu, Oct 30, 2014 at 02:14:57AM -0700, LucaDC wrote:
This sounds (and looks in the log) as an important step. I've never taken a look at the experimental branch but only heard about it in the mailing list. Is there a light list of major modifications and added features to look for and check out?
We ought to have a list like this captured on the ReleaseNotes page for 0.92, while all the new stuff is fresh on folks minds. Could someone please set up a new page for our new development notes?
http://wiki.inkscape.org/wiki/index.php/Release_notes
Bryce
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Hi, i just end filling the 0.92 page, but my english is not so good. Any body help me improving it? Not sure if is too big this LPE sections, maybe too much movement or pics...
Best regards, Jabier.
El jue, 30-10-2014 a las 13:32 -0700, Josh Andler escribió:
Updated and new page added. Liam and Jabiertxo should really tackle filling out info on the things they were responsible for creating or getting merged.
Cheers, Josh
On Thu, Oct 30, 2014 at 11:57 AM, Bryce Harrington <bryce@...961...> wrote:
On Thu, Oct 30, 2014 at 02:14:57AM -0700, LucaDC wrote:
This sounds (and looks in the log) as an important step. I've never taken a look at the experimental branch but only heard about it in the mailing list. Is there a light list of major modifications and added features to look for and check out?
We ought to have a list like this captured on the ReleaseNotes page for 0.92, while all the new stuff is fresh on folks minds. Could someone please set up a new page for our new development notes?
http://wiki.inkscape.org/wiki/index.php/Release_notes
Bryce
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Nov 1, 2014 12:58 PM, "Jabiertxo Arraiza Cenoz" <jabier.arraiza@...2893...> wrote:
Hi, i just end filling the 0.92 page, but my english is not so good. Any body help me improving it? Not sure if is too big this LPE sections, maybe too much movement or pics...
I will look over it more in-depth over the weekend, but it's definitely not too much for each LPE. It looks good from a quick glance at your changes.
Cheers, Josh
Sorry, I realized just now that there is a problem when opening an old document (90 dpi) with the new 96 dpi value: the whole drawing is resized to 90/96 (93.75%), page size included but not the grids. In fact I noticed the problem for not having the objects aligned to the grid anymore.
How is this supposed to be dealt with? Should one have to manually resize the page and the drawing to 106.666666...%? Which is the best way to accomplish this?
What about our old documents drawn in scale 1:1 and now marked as read-only as they have been archived? I think we need a way to tell Inkscape to still consider them @ 90 dpi, being everything inside them stored as px @ 90 dpi, or provide a quick conversion at loading time. Of course there must be a way for Inkscape to recognize whether a document is using the old or the new value. I think this is essential for not having big troubles in the future.
Also, care is needed for all the cases where this conversion is useless: if the document has been drawn in px, then the dpi are irrelevant (e.g. an icon) and no scaling should be applied. The problem is only in those documents that have mm or inches or so on as document unit.
Hence, user intervention is always required to fix the situation; better if it's reduced to answer "Fix-scale" or "Fix-only" or "Do nothing" to a question like "Fix this old document?" after loading.
Thanks. Luca
-- View this message in context: http://inkscape.13.x6.nabble.com/Merge-of-experimental-branch-tp4971954p4972... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
Hi LucaDC.
A point about, could you read this -full- thread in devel list? Last message: Re: [Inkscape-devel] Legacy 90 to 96 extension Wed, 15 Oct 2014 15:54:04 +0200
Regards, Jabier.
El mar, 04-11-2014 a las 01:14 -0800, LucaDC escribió:
Sorry, I realized just now that there is a problem when opening an old document (90 dpi) with the new 96 dpi value: the whole drawing is resized to 90/96 (93.75%), page size included but not the grids. In fact I noticed the problem for not having the objects aligned to the grid anymore.
How is this supposed to be dealt with? Should one have to manually resize the page and the drawing to 106.666666...%? Which is the best way to accomplish this?
What about our old documents drawn in scale 1:1 and now marked as read-only as they have been archived? I think we need a way to tell Inkscape to still consider them @ 90 dpi, being everything inside them stored as px @ 90 dpi, or provide a quick conversion at loading time. Of course there must be a way for Inkscape to recognize whether a document is using the old or the new value. I think this is essential for not having big troubles in the future.
Also, care is needed for all the cases where this conversion is useless: if the document has been drawn in px, then the dpi are irrelevant (e.g. an icon) and no scaling should be applied. The problem is only in those documents that have mm or inches or so on as document unit.
Hence, user intervention is always required to fix the situation; better if it's reduced to answer "Fix-scale" or "Fix-only" or "Do nothing" to a question like "Fix this old document?" after loading.
Thanks. Luca
-- View this message in context: http://inkscape.13.x6.nabble.com/Merge-of-experimental-branch-tp4971954p4972... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Thanks Jabier. By the way, for reference the right thread title is "Release Status (Frost)". I already read that thread and I knew that you had developed something related but I don't have a "Document" entry in the Extensions menu so I can't use what you are talking about nor check if it's useful to me. I supposed it's something related to the experimental branch only.
Anyway, I see your efforts to address this problem. But I think that this deserves much more attention.
I don't agree that this is an "expected behavior": also a bug is an expected behavior as seen from the the code point of view, it's just doing what it's been told to do; but we don't like it.
From the user point of view it's a BIG bug and I don't think that providing
a buried-in-menus extension (for those who have it) is the right approach. If the page is resized too, it's difficult to notice that a 10 mm long line is now 9,375 mm long until you measure it. If you open an old document for modifications, you may have already drawn new objects before realizing the problem, and then? You have half wrong document and half correct: no extension can fix this -> work lost.
Please, pay attention to this because as soon as "normal" users that never bothered with 90 or 96 DPI are going to have this release in their hands, something really bad is going to happen. Users must be warned about this and given an automatic way to fix it as soon as they open an old document. It's some internals that has been changed so you can't expect final users to understand and be already informed on what's going on. This is something that can corrupt documents! It can't be silent unless everything is automatically fixed without user intervention (and I don't think it's possible).
Luca
-- View this message in context: http://inkscape.13.x6.nabble.com/Merge-of-experimental-branch-tp4971954p4972... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
Hi LucaDC. El mié, 05-11-2014 a las 00:06 -0800, LucaDC escribió:
I already read that thread and I knew that you had developed something related but I don't have a "Document" entry in the Extensions menu so I can't use what you are talking about nor check if it's useful to me. I supposed it's something related to the experimental branch only.
Are you sure you instaled the extension correctly? document submenu is auto-generated.
Anyway, I see your efforts to address this problem. But I think that this deserves much more attention.
Adverts about diferent DPI of the file, to use the extension for example could be enought, but for the moment, this extension solve the problem opening 90DPI svg files in trunk. Maybe could be useful a 96to90DPI extension.
I don't agree that this is an "expected behavior": also a bug is an expected behavior as seen from the the code point of view, it's just doing what it's been told to do; but we don't like it.
From the user point of view it's a BIG bug and I don't think that providing
a buried-in-menus extension (for those who have it) is the right approach. If the page is resized too, it's difficult to notice that a 10 mm long line is now 9,375 mm long until you measure it. If you open an old document for modifications, you may have already drawn new objects before realizing the problem, and then? You have half wrong document and half correct: no extension can fix this -> work lost.
Please, pay attention to this because as soon as "normal" users that never bothered with 90 or 96 DPI are going to have this release in their hands, something really bad is going to happen. Users must be warned about this and given an automatic way to fix it as soon as they open an old document. It's some internals that has been changed so you can't expect final users to understand and be already informed on what's going on. This is something that can corrupt documents! It can't be silent unless everything is automatically fixed without user intervention (and I don't think it's possible).
Again advert to use the extension from the "advert" or from the extensions menu, or both. thats the question. Extension menu is need in my point of view because we can do a reverse extension to change the file to a SVG of 90DPI.
Cheers, Jabier.
- two quick comments: I would recommend filing a formal bug report so this does not get lost. This will likely become an issue for a lot of people and the best way to deal with it is in a public bug report.
Secondly I tried the attached extension legacy90to96, but the behavior was unexpected. - first of all I was using default units of px, as usual, so I expected a size change of about 6%. What I got was a size change from about 224 pixels to 793 pixels, which is a factor of 3, which is unexpected. - secondly, I expected that the coordinates of the individual elements in the drawing would be recalculated. Instead I see a change in the viewbox, which would not have been my preferred solution. - in any event, I would suggest a bug report. This needs public exposure.
Alvin
-- View this message in context: http://inkscape.13.x6.nabble.com/Merge-of-experimental-branch-tp4971954p4972... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
I see now that the unexpected behavior I saw was due to the fact that the original document had actually been created in trunk, not in Inkscape 0.48.5. In that case probably a warning should have been issued to indicate that this particular operation should not be performed.
Alvin
-- View this message in context: http://inkscape.13.x6.nabble.com/Merge-of-experimental-branch-tp4971954p4972... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
On Wed, 2014-11-05 at 02:59 -0800, alvinpenner wrote:
I see now that the unexpected behavior I saw was due to the fact that the original document had actually been created in trunk, not in Inkscape 0.48.5. In that case probably a warning should have been issued to indicate that this particular operation should not be performed.
I agee about the warning, the same can use at open a 90DPI doc in trunk. I have a question, whats the best way to know if a document is created at 90DPI? Is posibol in a secure/sure way?
Regards, Jabier.
alvinpenner wrote
- in any event, I would suggest a bug report. This needs public exposure.
Submitted bug report: https://bugs.launchpad.net/bugs/1389723
-- View this message in context: http://inkscape.13.x6.nabble.com/Merge-of-experimental-branch-tp4971954p4972... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
Hello Alvin.
Secondly I tried the attached extension legacy90to96, but the behavior was unexpected.
- first of all I was using default units of px, as usual, so I expected a
size change of about 6%. What I got was a size change from about 224 pixels to 793 pixels, which is a factor of 3, which is unexpected.
Sure we need an alert.
- secondly, I expected that the coordinates of the individual elements in
the drawing would be recalculated. Instead I see a change in the viewbox, which would not have been my preferred solution.
- in any event, I would suggest a bug report. This needs public exposure.
The change to viewbox is just fit a 0.92 document. The real scale is preformed in a group on top of all layers. You can flattern this group to remove this extra group and retain the transformations.
About this, is easy to me apply the transformation to each element disctint than a group instead transform a group container. Whats better for all?
Regards, Jabier.
I took the liberty of adding a reference to your extension in Bug 1389723, as well as adding a comment there about its behavior in 0.48.5. Perhaps this discussion could be continued there. Also, with respect to detecting Inkscape version, perhaps you could read the following property of the svg file?
inkscape:version="0.48.5 r10040" = 90 dpi inkscape:version="0.91+devel r13646" = 96 dpi
Alvin
-- View this message in context: http://inkscape.13.x6.nabble.com/Merge-of-experimental-branch-tp4971954p4972... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
Hi Alvin.
On Wed, 2014-11-05 at 16:17 -0800, alvinpenner wrote:
I took the liberty of adding a reference to your extension in Bug 1389723, as well as adding a comment there about its behavior in 0.48.5. Perhaps this discussion could be continued there.
Good.
Also, with respect to detecting Inkscape version, perhaps you could read the following property of the svg file?
inkscape:version="0.48.5 r10040" = 90 dpi inkscape:version="0.91+devel r13646" = 96 dpi
I reply on bug report.
Regards, Jabier
Jabiertxo Arraiza Cenoz wrote
Are you sure you instaled the extension correctly? document submenu is auto-generated.
I didn't installed anything, I just thought your extension was already in trunk. That's why I couldn't find it.
-- View this message in context: http://inkscape.13.x6.nabble.com/Merge-of-experimental-branch-tp4971954p4972... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
participants (9)
-
alvinpenner -
Bryce Harrington -
Jabier Arraiza -
Jabiertxo Arraiza Cenoz -
Johan Engelen -
Jon A. Cruz -
Josh Andler -
Liam White -
LucaDC