3. Frost. √ Experimental Branch is forked √ Mainline Branch focuses on stabilization √ Only production-ready code committed to Mainline √ Post inkscape-0.91-pre0.tar.gz √ Finalize any major changes to platform packaging √ Release Notes should be >90% filled in. √ Inkscape must pass >90% of 'make distcheck' √ Start an About Screen contest √ General Bug Hunt: 1500 points √ Post additional inkscape-0.91-pre*.tar.gz releases √ Packagers test creating pkgs of the -pre* releases
4. Feature Freeze √ Stable Branch is forked from Mainline Regular development resumes on Mainline. Avoid major refactorings on Mainline. Only bug fixes committed to Stable Branch. Bug fixes are cherrypicked from Mainline. Inkscape must pass 'make distcheck' String Freeze No further string changes allowed on Stable Branch. Finalize tutorials to be shipped with release Finalize other docs included in the release Finalize about screen Finalize Release Notes except Known Issues Translators work on translations. Recruit Release Wardens for Hard Freeze
Inkscape has completed the Frost phase and is moving into Freeze.
Translators, please fire up your engines! You have (at least) until Nov 18th to commit translation updates to the stable branch.
------------------------------------------------------------------------ A stable branch lp:inkscape/0.91.x has been split off of trunk. Only strict bug fixes and translations may be committed to this branch; for anything else please seek release manager approval (Josh or Bryce).
# Stable branch bzr clone lp:inkscape/0.91.x inkscape-0.91-stable
You will need to check this out only if you intend to check in fixes to the stable branch.
IMPORTANT: Do not make changes to translatable strings in the stable branch. If it is critical that a string change be made, please get approval from the release managers first!
------------------------------------------------------------------------ The lp:inkscape branch (trunk) is now open for regular development towards the 0.92.x series.
# Development branch bzr clone lp:inkscape
You don't need to do anything with your current branch if you just want to keep committing to the development branch.
Congrats to everyone that helped us get this far, Bryce
Hi,
The lp:inkscape branch (trunk) is now open for regular development towards the 0.92.x series.
# Development branch bzr clone lp:inkscape
You don't need to do anything with your current branch if you just want to keep committing to the development branch.
I'd like to point out that lp:inkscape/experimental can be merged back into trunk with zero conflicts.
Should we do this now?
On Sun, Oct 19, 2014 at 01:50:29AM -0400, Liam White wrote:
Hi,
The lp:inkscape branch (trunk) is now open for regular development towards the 0.92.x series.
# Development branch bzr clone lp:inkscape
You don't need to do anything with your current branch if you just want to keep committing to the development branch.
I'd like to point out that lp:inkscape/experimental can be merged back into trunk with zero conflicts.
Should we do this now?
My initial assumption when we started the experimental branch was that it would quickly turn into a wild west show with lots of craziness, and so we'd need to cherrypick the good contribs and shrug off the bad. But in practice it seems experimental has been handled in a professional way and is actually pretty sane.
I've told Liam that before we merge experimental into devel trunk, we need at least 3-4 supporters from the active developer base, with no one expressing a hard block.
IOW, now's your turn to give Liam your votes!
Bryce
On Sat, 2014-10-18 at 23:40 -0700, Bryce Harrington wrote:
On Sun, Oct 19, 2014 at 01:50:29AM -0400, Liam White wrote:
Hi,
The lp:inkscape branch (trunk) is now open for regular development towards the 0.92.x series.
# Development branch bzr clone lp:inkscape
You don't need to do anything with your current branch if you just want to keep committing to the development branch.
I'd like to point out that lp:inkscape/experimental can be merged back into trunk with zero conflicts.
Should we do this now?
My initial assumption when we started the experimental branch was that it would quickly turn into a wild west show with lots of craziness, and so we'd need to cherrypick the good contribs and shrug off the bad. But in practice it seems experimental has been handled in a professional way and is actually pretty sane.
I've told Liam that before we merge experimental into devel trunk, we need at least 3-4 supporters from the active developer base, with no one expressing a hard block.
IOW, now's your turn to give Liam your votes!
Go for it. I don't want to now have three branches to worry about.
Tav
PS. To build up excitement... should we announce on the Inkscape homepage/G+ the 0.91 branch?
On 19-10-2014 7:17, Bryce Harrington wrote:
A stable branch lp:inkscape/0.91.x has been split off of trunk. Only strict bug fixes and translations may be committed to this branch; for anything else please seek release manager approval (Josh or Bryce).
# Stable branch bzr clone lp:inkscape/0.91.x inkscape-0.91-stableYou will need to check this out only if you intend to check in fixes to the stable branch.
I'd very much like to see trunk revs 13623 http://bazaar.launchpad.net/%7Einkscape.dev/inkscape/trunk/revision/13623 and 13627 http://bazaar.launchpad.net/%7Einkscape.dev/inkscape/trunk/revision/13627 applied to 0.91. See the "Powerstroke - interpolation change" devel mail thread.
Thanks, Johan
Ported to 0.91.x
On Sun, Oct 19, 2014 at 3:55 PM, Johan Engelen <jbc.engelen@...2592...> wrote:
On 19-10-2014 7:17, Bryce Harrington wrote:
A stable branch lp:inkscape/0.91.x has been split off of trunk. Only strict bug fixes and translations may be committed to this branch; for anything else please seek release manager approval (Josh or Bryce).
# Stable branch bzr clone lp:inkscape/0.91.x inkscape-0.91-stable
You will need to check this out only if you intend to check in fixes to the stable branch.
I'd very much like to see trunk revs 13623 and 13627 applied to 0.91. See the "Powerstroke - interpolation change" devel mail thread.
Thanks, Johan
Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Thanks!
On 21-10-2014 1:19, Josh Andler wrote:
Ported to 0.91.x
On Sun, Oct 19, 2014 at 3:55 PM, Johan Engelen <jbc.engelen@...2592...> wrote:
On 19-10-2014 7:17, Bryce Harrington wrote:
A stable branch lp:inkscape/0.91.x has been split off of trunk. Only strict bug fixes and translations may be committed to this branch; for anything else please seek release manager approval (Josh or Bryce).
# Stable branch bzr clone lp:inkscape/0.91.x inkscape-0.91-stableYou will need to check this out only if you intend to check in fixes to the stable branch.
I'd very much like to see trunk revs 13623 and 13627 applied to 0.91. See the "Powerstroke - interpolation change" devel mail thread.
Thanks, Johan
Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
3. Frost. √ Experimental Branch is forked √ Mainline Branch focuses on stabilization √ Only production-ready code committed to Mainline √ Post inkscape-0.91-pre0.tar.gz √ Finalize any major changes to platform packaging √ Release Notes should be >90% filled in. √ Inkscape must pass >90% of 'make distcheck' √ Start an About Screen contest √ General Bug Hunt: 1500 points √ Post additional inkscape-0.91-pre*.tar.gz releases √ Packagers test creating pkgs of the -pre* releases
4. Feature Freeze √ Stable Branch is forked from Mainline √ Regular development resumes on Mainline. √ Avoid major refactorings on Mainline. √ Only bug fixes committed to Stable Branch. Bug fixes are cherrypicked from Mainline. Inkscape must pass 'make distcheck' String Freeze √ No further string changes allowed on Stable Branch. Finalize tutorials to be shipped with release Finalize other docs included in the release Finalize about screen Finalize Release Notes except Known Issues Translators work on translations. √ Recruit Release Wardens for Hard Freeze
Johan, would you be willing to hammer on getting 'make distcheck' to be passing 100% clean? Last I checked it was pretty close but there's a few warnings and other cleanups of the sort you like to tackle.
Are there any changes under way for the in-app tutorials or other documentation included in the tarball? If not, I'd like to call these tasks final on the 22nd so translators that want to work on them can do so safely.
Josh, thanks for providing status on the About Screen contest, aside from any fixes to the image itself, and adding the svg to trunk, are there any other follow-up tasks we'll need to track for the release?
Release_notes seems to have not received very many edits the last few months. Ryan Lerch, Tavmjong and suv (and anyone else who'd like to pitch in), can I task you three with combing through the Release Notes and ensuring they cover all features added in the last 6 months or so? Also, please give some attention to what should be said in the Known Issues section.
Liam, you've been very active in development on the experimental branch, would you mind establishing a new Release_notes page in wiki for the 0.92 work, and listing there the features you've been working on, as those features get merged to trunk? Having the 0.92 changes documented early will both set us up with good habits for 0.92, and help us make decisions about cherrypicks for 0.91 going forward.
In the past we've named someone as Translation Coordinator to act as a contact point for translators and updating the inkscape.pot file. Jazzy Nico, you've been most active in this area lately, would you mind serving in this role for 0.91?
Josh and I will act as release wardens for this release.
Bryce
On Mon, Oct 20, 2014 at 5:34 PM, Bryce Harrington <bryce@...961...> wrote:
Josh, thanks for providing status on the About Screen contest, aside from any fixes to the image itself, and adding the svg to trunk, are there any other follow-up tasks we'll need to track for the release?
There's nothing anyone else will need to track regarding this, I'll be sending a more formal request to the author on Wednesday (I already sent a congrats message along). One item not included in our release process that should be in the future is the screenshots of the release. I will just need to document it a little better to add it for 0.92. I've already contacted a handful of people for it, so they will come together over the next month.
Release_notes seems to have not received very many edits the last few months. Ryan Lerch, Tavmjong and suv (and anyone else who'd like to pitch in), can I task you three with combing through the Release Notes and ensuring they cover all features added in the last 6 months or so? Also, please give some attention to what should be said in the Known Issues section.
Speaking of this, we got a last minute fixup to trunk for font loading just prior to 0.91 branching... was this properly reflected in any relevant bug reports? The font loading thing might merit a mention in the release notes.
Cheers, Josh
On 21-10-2014 21:06, Johan Engelen wrote:
On 21-10-2014 2:34, Bryce Harrington wrote:
Johan, would you be willing to hammer on getting 'make distcheck' to be passing 100% clean? Last I checked it was pretty close but there's a few warnings and other cleanups of the sort you like to tackle.
OK :)
I was hoping to work on this during some downtime at the mentor summit, but...
It is the first time I ran 'make distcheck', on my Mac, and... it just works? :) I see that the unit tests are set to "expect to fail", so that obviously always passes (I don't know why it is set to xfail).
In short: do I need to do anything here? Or is it already good?
cheers, Johan
The xfail stuff was just a hack I made to stop old tests from killing the PPA builds... they are definitely not supposed to fail, so it's a bit of an abuse of the xfail flag and should be fixed before the release. As I understand it, they're mostly failures that appeared with changes in 2geom... I suspect they're very easy to fix for people who are familiar with the code. The relevant bug reports I made are here:
https://bugs.launchpad.net/inkscape/+bug/1249324
Hope it's of some use!
AV
On 30 October 2014 15:05, Johan Engelen <jbc.engelen@...2592...> wrote:
On 21-10-2014 21:06, Johan Engelen wrote:
On 21-10-2014 2:34, Bryce Harrington wrote:
Johan, would you be willing to hammer on getting 'make distcheck' to be passing 100% clean? Last I checked it was pretty close but there's a few warnings and other cleanups of the sort you like to tackle.
OK :)
I was hoping to work on this during some downtime at the mentor summit, but...
It is the first time I ran 'make distcheck', on my Mac, and... it just works? :) I see that the unit tests are set to "expect to fail", so that obviously always passes (I don't know why it is set to xfail).
In short: do I need to do anything here? Or is it already good?
cheers, Johan
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
In fact, while we're at it, it may be worth bumping the version of cxxtest in trunk. There's a much newer upstream version (4.4) at http://sourceforge.net/projects/cxxtest/files/cxxtest/
Upstream changelog ==== * Version 4.4 (2014-06-03) - Fixed compilation error on Windows (MSVC) in XmlFormatter.h (#86) - Fix to ensure that tearDown() is called (#89) - Add option run test with a user defined command in scons (#91) - Use a Python path relative to the cxxtestgen script (#88) - Add defensive guard in ErrorFormatter.h (#96) - Fixed bug with "None" appearing in CXXTEST_CPPATH (#99) - Added CXXTEST_LIBPATH to properly use shared libraries (#100) - Added guards when XmlFormatter.h data is not initialize (#87)
* Version 4.3 (2013-07-05) - Changes to assess code coverage of the cxxtestgen command - Standardizing C++ file formats (using astyle) - Bug fixes that led to the test runner hanging - Adding special assertions for floating point values - Added date to XML output - Added support for comparison of C strings
* Version 4.2.1 (2013-03-22) - Fixing documentation of LGPL version
* Version 4.2 (2013-03-16) - Changes to support test fixtures in namespaces - Adding logic to support test skipping - Change to create self-contained HTML documentation - Fixed inheritance issue in GlobalFixture (#69) - Update LGPL version - Changes to try/catch to avoid ambiguities withn catching std::exception (#53) - Fixed TS_ASSERT_DELTA to work on integer types (#65) - Changed output format to print world-name (#70)
* Version 4.1 (2012-11-30) - Added absolute paths to resolve bug when relative path links are provided. - Bug fix when files contain unicode characters - Fix for --no-static-init: Changed how non-static tests are created - Updated user guide to include SCons build system - Closing out Tigris and SourceForge tickets - Added valgrind tests.
* Version 4.0.3 (2012-01-07) - Adding support for Python 2.4 - 3.2 - Various cleanup of CxxTest root directory - Adding patch that allows the cxxtestgen script to be used when symlinked.
* Version 4.0.2 (2012-01-02) - Bug fix to enable installation of cxxtestgen without the 'setuptools' package
* Version 4.0.1 (2012-01-01) - Documentation updates - Bug fix for installation of cxxtestgen script
* Version 4.0 (2011-12-28) - Perl is no longer used to support CxxTest scripts. Python is now the only scripting language used by CxxTest. - The testing scripts have been rewritten using the PyUnit framework. - The installation process for CxxTest now leverages and integrates with the system Python installation. - A more comprehensive C++ parser is now available, which supports testing of templates. - The CxxTest GUI is no longer supported. - The <<ts_trace,TS_TRACE>> and <<ts_warn,TS_WARN>> macros have the same behavior now. - CxxTest runners now have a command-line interface that facilitates interactive use of the test runner. - A new user guide is now available in PDF, HTML and Ebook formats.
On 30 October 2014 15:48, Alex Valavanis <valavanisalex@...400...> wrote:
The xfail stuff was just a hack I made to stop old tests from killing the PPA builds... they are definitely not supposed to fail, so it's a bit of an abuse of the xfail flag and should be fixed before the release. As I understand it, they're mostly failures that appeared with changes in 2geom... I suspect they're very easy to fix for people who are familiar with the code. The relevant bug reports I made are here:
https://bugs.launchpad.net/inkscape/+bug/1249324
Hope it's of some use!
AV
On 30 October 2014 15:05, Johan Engelen <jbc.engelen@...2592...> wrote:
On 21-10-2014 21:06, Johan Engelen wrote:
On 21-10-2014 2:34, Bryce Harrington wrote:
Johan, would you be willing to hammer on getting 'make distcheck' to be passing 100% clean? Last I checked it was pretty close but there's a few warnings and other cleanups of the sort you like to tackle.
OK :)
I was hoping to work on this during some downtime at the mentor summit, but...
It is the first time I ran 'make distcheck', on my Mac, and... it just works? :) I see that the unit tests are set to "expect to fail", so that obviously always passes (I don't know why it is set to xfail).
In short: do I need to do anything here? Or is it already good?
cheers, Johan
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Hi Alex, Actually, Krzysz and I are thinking about moving towards GTest.
regards, Johan
On 30-10-2014 16:58, Alex Valavanis wrote:
In fact, while we're at it, it may be worth bumping the version of cxxtest in trunk. There's a much newer upstream version (4.4) at http://sourceforge.net/projects/cxxtest/files/cxxtest/
Upstream changelog
Version 4.4 (2014-06-03)
- Fixed compilation error on Windows (MSVC) in XmlFormatter.h (#86)
- Fix to ensure that tearDown() is called (#89)
- Add option run test with a user defined command in scons (#91)
- Use a Python path relative to the cxxtestgen script (#88)
- Add defensive guard in ErrorFormatter.h (#96)
- Fixed bug with "None" appearing in CXXTEST_CPPATH (#99)
- Added CXXTEST_LIBPATH to properly use shared libraries (#100)
- Added guards when XmlFormatter.h data is not initialize (#87)
Version 4.3 (2013-07-05)
- Changes to assess code coverage of the cxxtestgen command
- Standardizing C++ file formats (using astyle)
- Bug fixes that led to the test runner hanging
- Adding special assertions for floating point values
- Added date to XML output
- Added support for comparison of C strings
Version 4.2.1 (2013-03-22)
- Fixing documentation of LGPL version
Version 4.2 (2013-03-16)
- Changes to support test fixtures in namespaces
- Adding logic to support test skipping
- Change to create self-contained HTML documentation
- Fixed inheritance issue in GlobalFixture (#69)
- Update LGPL version
- Changes to try/catch to avoid ambiguities withn catching std::exception (#53)
- Fixed TS_ASSERT_DELTA to work on integer types (#65)
- Changed output format to print world-name (#70)
Version 4.1 (2012-11-30)
- Added absolute paths to resolve bug when relative path links are provided.
- Bug fix when files contain unicode characters
- Fix for --no-static-init: Changed how non-static tests are created
- Updated user guide to include SCons build system
- Closing out Tigris and SourceForge tickets
- Added valgrind tests.
Version 4.0.3 (2012-01-07)
- Adding support for Python 2.4 - 3.2
- Various cleanup of CxxTest root directory
- Adding patch that allows the cxxtestgen script to be used when symlinked.
Version 4.0.2 (2012-01-02)
- Bug fix to enable installation of cxxtestgen without the 'setuptools' package
Version 4.0.1 (2012-01-01)
- Documentation updates
- Bug fix for installation of cxxtestgen script
Version 4.0 (2011-12-28)
- Perl is no longer used to support CxxTest scripts. Python is now
the only scripting language used by CxxTest.
- The testing scripts have been rewritten using the PyUnit framework.
- The installation process for CxxTest now leverages and integrates
with the system Python installation.
- A more comprehensive C++ parser is now available, which supports
testing of templates.
- The CxxTest GUI is no longer supported.
- The <<ts_trace,TS_TRACE>> and <<ts_warn,TS_WARN>> macros have the
same behavior now.
- CxxTest runners now have a command-line interface that facilitates
interactive use of the test runner.
- A new user guide is now available in PDF, HTML and Ebook formats.
On 30 October 2014 15:48, Alex Valavanis <valavanisalex@...400...> wrote:
The xfail stuff was just a hack I made to stop old tests from killing the PPA builds... they are definitely not supposed to fail, so it's a bit of an abuse of the xfail flag and should be fixed before the release. As I understand it, they're mostly failures that appeared with changes in 2geom... I suspect they're very easy to fix for people who are familiar with the code. The relevant bug reports I made are here:
https://bugs.launchpad.net/inkscape/+bug/1249324
Hope it's of some use!
AV
On 30 October 2014 15:05, Johan Engelen <jbc.engelen@...2592...> wrote:
On 21-10-2014 21:06, Johan Engelen wrote:
On 21-10-2014 2:34, Bryce Harrington wrote:
Johan, would you be willing to hammer on getting 'make distcheck' to be passing 100% clean? Last I checked it was pretty close but there's a few warnings and other cleanups of the sort you like to tackle.
OK :)
I was hoping to work on this during some downtime at the mentor summit, but...
It is the first time I ran 'make distcheck', on my Mac, and... it just works? :) I see that the unit tests are set to "expect to fail", so that obviously always passes (I don't know why it is set to xfail).
In short: do I need to do anything here? Or is it already good?
cheers, Johan
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Thu, Oct 30, 2014, at 08:58 AM, Alex Valavanis wrote:
In fact, while we're at it, it may be worth bumping the version of cxxtest in trunk. There's a much newer upstream version (4.4) at http://sourceforge.net/projects/cxxtest/files/cxxtest/
While I'm glad to see cxxtest finally getting some updates, we really should just switch to either Boost Test or Google Test. Both are far ahead of the current alternatives for C++ unit testing.
Having evaluated these and helping with adoption at work (including needing to switch some projects back and forth between them as one project's lead kept changing his mind) I've seen that Boost Test has several technical points where it edges out Google Test.
However, in general discussions about switching a few different Inkscape developers expressed a preference for Google Test as they were already familiar with it. Given that the differences between them (in abilities, usability, etc) are very minor compared to their differences from other frameworks, either is a good choice.
Now that 0.91 has been branched, my personal working plan was to fix the 600-800 issues with our outdated GTKish casting macros then shift to updating our tests to a newer framework.
On 30-10-2014 17:37, Jon A. Cruz wrote:
On Thu, Oct 30, 2014, at 08:58 AM, Alex Valavanis wrote:
In fact, while we're at it, it may be worth bumping the version of cxxtest in trunk. There's a much newer upstream version (4.4) at http://sourceforge.net/projects/cxxtest/files/cxxtest/
While I'm glad to see cxxtest finally getting some updates, we really should just switch to either Boost Test or Google Test. Both are far ahead of the current alternatives for C++ unit testing.
Having evaluated these and helping with adoption at work (including needing to switch some projects back and forth between them as one project's lead kept changing his mind) I've seen that Boost Test has several technical points where it edges out Google Test.
However, in general discussions about switching a few different Inkscape developers expressed a preference for Google Test as they were already familiar with it. Given that the differences between them (in abilities, usability, etc) are very minor compared to their differences from other frameworks, either is a good choice.
I do not have a preference, as I am pretty much unfamiliar with either. But I do think that Google Test is more widely used, and so more people are familiar with it? Perhaps my searches have been biased. An important feature for me is how well it integrates into Jenkins; a clear test report on a website will greatly contribute to its usefulness I think.
Now that 0.91 has been branched, my personal working plan was to fix the 600-800 issues with our outdated GTKish casting macros then shift to updating our tests to a newer framework.
Same here :) (well, I am working on the render tests first :))
- Johan
On 30-10-2014 18:30, Johan Engelen wrote:
On 30-10-2014 17:37, Jon A. Cruz wrote:
On Thu, Oct 30, 2014, at 08:58 AM, Alex Valavanis wrote:
In fact, while we're at it, it may be worth bumping the version of cxxtest in trunk. There's a much newer upstream version (4.4) at http://sourceforge.net/projects/cxxtest/files/cxxtest/
While I'm glad to see cxxtest finally getting some updates, we really should just switch to either Boost Test or Google Test. Both are far ahead of the current alternatives for C++ unit testing.
Having evaluated these and helping with adoption at work (including needing to switch some projects back and forth between them as one project's lead kept changing his mind) I've seen that Boost Test has several technical points where it edges out Google Test.
However, in general discussions about switching a few different Inkscape developers expressed a preference for Google Test as they were already familiar with it. Given that the differences between them (in abilities, usability, etc) are very minor compared to their differences from other frameworks, either is a good choice.
I do not have a preference, as I am pretty much unfamiliar with either. But I do think that Google Test is more widely used, and so more people are familiar with it? Perhaps my searches have been biased. An important feature for me is how well it integrates into Jenkins; a clear test report on a website will greatly contribute to its usefulness I think.
lib2geom uses Google Test, btw.
-Johan
On 30-10-2014 16:48, Alex Valavanis wrote:
The xfail stuff was just a hack I made to stop old tests from killing the PPA builds... they are definitely not supposed to fail, so it's a bit of an abuse of the xfail flag and should be fixed before the release. As I understand it, they're mostly failures that appeared with changes in 2geom... I suspect they're very easy to fix for people who are familiar with the code. The relevant bug reports I made are here:
Thanks for the explanation Alex.
Browsing through our history, the matrix writing tests ("translate(1)", "skew...") never passed. There is no code anywhere that would output such strings. So what to do? Change the bug report to a wishlist item, change title to "implement special matrix shorthand output" and remove/comment the tests?
-Johan
Hope it's of some use!
AV
On 30 October 2014 15:05, Johan Engelen <jbc.engelen@...2592...> wrote:
On 21-10-2014 21:06, Johan Engelen wrote:
On 21-10-2014 2:34, Bryce Harrington wrote:
Johan, would you be willing to hammer on getting 'make distcheck' to be passing 100% clean? Last I checked it was pretty close but there's a few warnings and other cleanups of the sort you like to tackle.
OK :)
I was hoping to work on this during some downtime at the mentor summit, but...
It is the first time I ran 'make distcheck', on my Mac, and... it just works? :) I see that the unit tests are set to "expect to fail", so that obviously always passes (I don't know why it is set to xfail).
In short: do I need to do anything here? Or is it already good?
cheers, Johan
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Browsing through our history, the matrix writing tests ("translate(1)", "skew...") never passed. There is no code anywhere that would output such strings. So what to do? Change the bug report to a wishlist item, change title to "implement special matrix shorthand output" and remove/comment the tests?
-Johan
Or implement them. :P
On 9-11-2014 3:19, Liam White wrote:
Browsing through our history, the matrix writing tests ("translate(1)", "skew...") never passed. There is no code anywhere that would output such strings. So what to do? Change the bug report to a wishlist item, change title to "implement special matrix shorthand output" and remove/comment the tests?
-Johan
Or implement them. :P
:)
Thanks, Johan
Can I remove the "XFAIL" line in trunk?
- Johan
On 30-10-2014 16:48, Alex Valavanis wrote:
The xfail stuff was just a hack I made to stop old tests from killing the PPA builds... they are definitely not supposed to fail, so it's a bit of an abuse of the xfail flag and should be fixed before the release. As I understand it, they're mostly failures that appeared with changes in 2geom... I suspect they're very easy to fix for people who are familiar with the code. The relevant bug reports I made are here:
https://bugs.launchpad.net/inkscape/+bug/1249324
Hope it's of some use!
AV
On 30 October 2014 15:05, Johan Engelen <jbc.engelen@...2592...> wrote:
On 21-10-2014 21:06, Johan Engelen wrote:
On 21-10-2014 2:34, Bryce Harrington wrote:
Johan, would you be willing to hammer on getting 'make distcheck' to be passing 100% clean? Last I checked it was pretty close but there's a few warnings and other cleanups of the sort you like to tackle.
OK :)
I was hoping to work on this during some downtime at the mentor summit, but...
It is the first time I ran 'make distcheck', on my Mac, and... it just works? :) I see that the unit tests are set to "expect to fail", so that obviously always passes (I don't know why it is set to xfail).
In short: do I need to do anything here? Or is it already good?
cheers, Johan
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (8)
-
Alex Valavanis -
Bryce Harrington -
Jabiertxo Arraiza Cenoz -
Johan Engelen -
Jon A. Cruz -
Josh Andler -
Liam White -
Tavmjong Bah