Hi all,
With su_v, we recently compiled some items left to do for CMake builds, so here it is.
Feel free to take and fix anything on this list, or add anything that would be missing from it.
---------------
CMake todolist
-> add -std=c++11 to CXXFLAGS /if needed/ (by libsigc++>2.5.1 for instance)https://bugs.launchpad.net/inkscape/+bug/1488079 ->make sure "make check" works and also checks extensions
->port options from configure to cmake : - WITH_GTK3_EXPERIMENTAL - WITH_DBUS - WITH_LOCAL_INSTALL (if dbus is ON) - WITH_LCMS - OSXAPPhttps://bugs.launchpad.net/inkscape/+bug/1502774 - STATIC_BUILD - WITH_SILENT_RULES - WITH_SVG2 / WITH_LPETOOLS https://gist.github.com/su-v/79199ba0ac5df2e2ac7c --enable-strict-build
-> use pkgconfig for imagemagick so that it correctly sets MAGICKCORE_HDRI_ENABLE and MAGICKCORE_QUANTUM_DEPTH. Also do the proper thing for pango and fontconfig. -> install man pages ->check remaining FIXME -> (automatically update author dialog from authors file?) -> set the version string if not built from a bzr directory
- check that all cmake option variables //actually do/ /what they claim
Windows : -> Add a variable to devlibs, and more generally get cmake to work as expected with "cmake .; make" on windows
-> check dependencies
--------------
-- Mc
2015-10-13 0:36 GMT+02:00 Marc Jeanmougin <marc@...3062...>:
Hi all,
With su_v, we recently compiled some items left to do for CMake builds, so here it is.
[snip]
- WITH_DBUS
- WITH_LOCAL_INSTALL (if dbus is ON)
I am not sure about the future of the DBus binding. As I said before on the list, I think a simpler approach with an embedded Python interpreter and Cython-based bindings to Inkscape internals would be more useful with less effort. To that end, I've been working on reviving the Cython-based binding in 2Geom, which would be a prerequisite to exposing Inkscape internals via Python. However I won't push for removing this until there's a replacement.
- WITH_LCMS
I think this should be an unconditional dependency.
- WITH_SILENT_RULES
This is completely unnecessary in CMake since it has its own pretty printing when building.
Windows : -> Add a variable to devlibs, and more generally get cmake to work as expected with "cmake .; make" on windows
Is CMake capable of modifying the shell's environment variables? Because otherwise this is impossible.
Best regards, Krzysztof
On Tue, Oct 13, 2015 at 02:50:09AM +0200, Krzysztof Kosiński wrote:
2015-10-13 0:36 GMT+02:00 Marc Jeanmougin <marc@...3062...>:
Hi all,
With su_v, we recently compiled some items left to do for CMake builds, so here it is.
[snip]
Windows : -> Add a variable to devlibs, and more generally get cmake to work as expected with "cmake .; make" on windows
Is CMake capable of modifying the shell's environment variables? Because otherwise this is impossible.
Best regards, Krzysztof
I am known for my loathing of cmake (reinventing a wheel), but recent versions seem to have become "good enough" for linux, as well as required for a few packages I need, so I looked at the cmake build of inkscape about six months ago, and I guess the original list of issues covers all the things I noticed (primarily, I wanted to build without some of the optional dependencies, and I also recall the missing man pages), except for this point : *every* other cmake package I have tried to build in the last 3+ years uses a separate build directory.
My guess is that using 'cmake .' is poorly tested. But I could not offer potential fixes for the inkscape cmake files, either for this or for the man pages issue - as we say in English "it's all greek to me" (except, I can read a very few words of greek, and use google translation). The only references I could find for moving from configure to cmake were for *very* basic projects.
Your project, your rules, so please disregard this comment if it will upset you.
ĸen
On Tue, Oct 13, 2015 at 12:36:43AM +0200, Marc Jeanmougin wrote:
Hi all,
With su_v, we recently compiled some items left to do for CMake builds, so here it is.
Feel free to take and fix anything on this list, or add anything that would be missing from it.
Thanks for posting this Marc.
Once this list is cleared, I can finalize the release.
Bryce
CMake todolist-> add -std=c++11 to CXXFLAGS /if needed/ (by libsigc++>2.5.1 for instance)https://bugs.launchpad.net/inkscape/+bug/1488079 ->make sure "make check" works and also checks extensions
->port options from configure to cmake :
- WITH_GTK3_EXPERIMENTAL
- WITH_DBUS
- WITH_LOCAL_INSTALL (if dbus is ON)
- WITH_LCMS
- OSXAPPhttps://bugs.launchpad.net/inkscape/+bug/1502774
- STATIC_BUILD
- WITH_SILENT_RULES
- WITH_SVG2 / WITH_LPETOOLS
https://gist.github.com/su-v/79199ba0ac5df2e2ac7c --enable-strict-build
-> use pkgconfig for imagemagick so that it correctly sets MAGICKCORE_HDRI_ENABLE and MAGICKCORE_QUANTUM_DEPTH. Also do the proper thing for pango and fontconfig. -> install man pages ->check remaining FIXME -> (automatically update author dialog from authors file?) -> set the version string if not built from a bzr directory
- check that all cmake option variables //actually do/ /what they claim
Windows : -> Add a variable to devlibs, and more generally get cmake to work as expected with "cmake .; make" on windows
-> check dependencies
-- Mc
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2
iEYEARECAAYFAlYcNhgACgkQX8sgTviCsHpYegCePHoGvcdrP26GXiTkzP1SjeMP hCkAoKsdaK9ptj2opBUP9J9QoUiNTS2o =JndQ -----END PGP SIGNATURE-----
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On 2015-10-13 23:46 (+0200), Bryce Harrington wrote:
On Tue, Oct 13, 2015 at 12:36:43AM +0200, Marc Jeanmougin wrote:
With su_v, we recently compiled some items left to do for CMake builds, so here it is.
Feel free to take and fix anything on this list, or add anything that would be missing from it.
Thanks for posting this Marc.
Once this list is cleared, I can finalize the release.
JFYI - A bug-fix release (0.91.1) of the stable release branch could be done rather quickly in the meantime, I guess ... * Quite a number of backports from trunk to the current stable release branch 0.91.x have happened [1]. * A draft version for release notes listing some of the relevant bug fixes/backports is available in the wiki [2]. * Mostly missing [3] at the moment are backports of fixes for (viewBox-related) regressions wrt precision (several commits not linked to bug reports), and fixes/updates for EMF/WMF input/output.
Personally, I'm not sure current trunk is ready to be released as is as new stable version [4], but then again of course I always have that impression before a new release branch is created (since I mostly deal with the bugs and regressions, not with what actually works) ;-)
Re cmake: I don't recall seeing any reports/feedback about (successful or not) usage of cmake with current trunk on Windows (32bit or 64bit devlibs); all I know at the moment is that 64bit Windows builds of trunk are broken anyway - unrelated to cmake (a patch was recently proposed [5]).
Regards, V
[1] https://launchpad.net/inkscape/+milestone/0.91.1 [2] http://wiki.inkscape.org/wiki/index.php/Release_notes/0.91.1 [3] https://bugs.launchpad.net/inkscape/+bugs?field.tag=backport-proposed [4] https://launchpad.net/inkscape/+milestone/0.92 (Note: bugs already backported to the 0.91.x branch are not listed on the 0.92 milestone page) [5] https://bugs.launchpad.net/inkscape/+bug/1500087
On Wed, Oct 14, 2015 at 11:12 AM, su_v <suv@...2204...> wrote:
Personally, I'm not sure current trunk is ready to be released as is as new stable version [4], but then again of course I always have that impression before a new release branch is created (since I mostly deal with the bugs and regressions, not with what actually works) ;-)
I will throw out there that while it's a platform specific issue, I've seen enough complaints on various forums/discussions to merit saying the following bug should be high priority: https://bugs.launchpad.net/inkscape/+bug/1416674
Re cmake: I don't recall seeing any reports/feedback about (successful or not) usage of cmake with current trunk on Windows (32bit or 64bit devlibs); all I know at the moment is that 64bit Windows builds of trunk are broken anyway - unrelated to cmake (a patch was recently proposed [5]).
Cmake builds are currently broken on Ubuntu Wily, it looks like it's "finding" a library in a location where it doesn't exist. Just figured I'd throw it out there as a heads up. 2geom has the same issue for the record and it's regarding libgsl.
Cheers, Josh
Am Mittwoch, 14. Oktober 2015, 11:25:53 schrieb Josh Andler:
[...]
Cmake builds are currently broken on Ubuntu Wily, it looks like it's "finding" a library in a location where it doesn't exist. Just figured I'd throw it out there as a heads up. 2geom has the same issue for the record and it's regarding libgsl.
That sounds as if CMake cached something that is no longer reflecting the system. Did you try removing your build directory?
Cheers, Josh
Tobias
On Wed, 2015-10-14 at 20:12 +0200, su_v wrote:
JFYI - A bug-fix release (0.91.1) of the stable release branch could be done rather quickly in the meantime, I guess ...
The more releases we do in the year, the more likely users are to get comfortable with updating their inkscape version to fix issues. I'm not sure how visible minor-minor numbers are to most users.
Once we're past 1.0 though, we can have the minor version be a proper minor version :-)
Martin,
participants (8)
-
Bryce Harrington -
Josh Andler -
Ken Moffat -
Krzysztof Kosiński -
Marc Jeanmougin -
Martin Owens -
su_v -
Tobias Ellinghaus