Hi Max,
I noticed that you now add a default inkscape:perspective element to a document even if it does not used any 3D boxes. I'm sure a lot of people will not be happy about it. Can you fix it to only add it when necessary?
On Wed, 2008-02-13 at 15:42 -0400, bulia byak wrote:
Hi Max,
I noticed that you now add a default inkscape:perspective element to a document even if it does not used any 3D boxes. I'm sure a lot of people will not be happy about it. Can you fix it to only add it when necessary?
This part of the element can also be found when one saves as plain SVG.
<inkscape:perspective id="perspective3243" />
Tav
Tavmjong Bah wrote:
On Wed, 2008-02-13 at 15:42 -0400, bulia byak wrote:
Hi Max,
I noticed that you now add a default inkscape:perspective element to a document even if it does not used any 3D boxes. I'm sure a lot of people will not be happy about it. Can you fix it to only add it when necessary?
This part of the element can also be found when one saves as plain SVG.
<inkscape:perspective id="perspective3243" />
That's true, but LPEs (for example, maybe other things as well) are also not removed when saving as plain SVG. For some reason I made it so that perspectives show the same behaviour, although on second thought it certainly doesn't make sense.
Can anyone give me a hint where the appropriate code must be placed so that saving as plain SVG removes this from the defs?
Thanks, Max
On Feb 16, 2008 8:03 AM, Maximilian Albert <Anhalter42@...173...> wrote:
Can anyone give me a hint where the appropriate code must be placed so that saving as plain SVG removes this from the defs?
This check is done in write methods, which are passed a special flag telling them if we're writing Inkscape SVG or plain.
bulia byak schrieb:
On Feb 16, 2008 8:03 AM, Maximilian Albert <Anhalter42@...173...> wrote:
Can anyone give me a hint where the appropriate code must be placed so that saving as plain SVG removes this from the defs?
This check is done in write methods, which are passed a special flag telling them if we're writing Inkscape SVG or plain.
Thanks (and sorry for asking something so obvious - I simply thought that perspectives need a different treatment than most objects because they are stored in the defs, which is of course nonsense). The adapted code is now in SVN.
I also had a quick glance at the corresponding LPE code, but making analogous changes for them either resulted in crashes or still left the path-effect attributes in plain SVG. Johan, could you have a look?
Max
bulia byak schrieb:
Hi Max,
I noticed that you now add a default inkscape:perspective element to a document even if it does not used any 3D boxes. I'm sure a lot of people will not be happy about it. Can you fix it to only add it when necessary?
Certainly. Would it be enough to remove it when the document is saved? I added some code which achieves this, but I'm hesitating to commit it because now the following error message is triggered each time an unused perspective is removed:
** (inkscape:23926): CRITICAL **: void Inkscape::GC::Anchored::release() const: assertion `_anchor' failed
I don't really know what's causing this. What does the _anchor refer to and what could be the reason for this warning? I'd be grateful for any enlightenment. :)
Thanks, Max
On Feb 16, 2008 8:12 AM, Maximilian Albert <Anhalter42@...173...> wrote:
Certainly. Would it be enough to remove it when the document is saved? I added some code which achieves this, but I'm hesitating to commit it because now the following error message is triggered each time an unused perspective is removed:
** (inkscape:23926): CRITICAL **: void Inkscape::GC::Anchored::release() const: assertion `_anchor' failed
I've seen this message a lot lately, so this may be some other bug. I'll look into it.
participants (3)
-
bulia byak -
Maximilian Albert -
Tavmjong Bah