Hey all!
Any blockers left? Things look pretty ripe right now imho and it seems like momentum has slowed. Better question... any opposition to moving forward?
Cheers, Josh
On 4/11/10 04:37, Josh Andler wrote:
Any blockers left? Things look pretty ripe right now imho and it seems like momentum has slowed. Better question... any opposition to moving forward?
the list I still hope to get addressed in 0.48.1:
1) remove "Cairo PNG" as output file format? [1] 2) node tool: restore old behavior (or compromise) for 'Shift+C' [2] 3) osx: extensions on Snow Leopard? (no answer from Micheal so far) [3] 4) backport DXF R13 fixes from trunk [4]
unlikely, but still:
5) no one answered or commented the issue with masks in cairo-based exports... [5]
~suv
[1] please test the system clipboard usage on other platforms for possible side-effects if the output extension is not loaded, as mentioned in http://thread.gmane.org/gmane.comp.graphics.inkscape.user/13065/focus=35299
Can someone who knows the code for the system clipboard support confirm that a) the "Cairo PNG" output extension is currently used instead of the internal renderer, and b) the quality of clipboard copies pasted as bitmaps in other applications is better if the internal renderer is used (which is the case, at least in my tests, if 'Cairo PNG' doesn't exist)
To me it seems that the code for the clipboard needs to be fixed to use an internal output extension for PNG as fallback, not as first choice.
[2] node tool: retract handles http://thread.gmane.org/gmane.comp.graphics.inkscape.devel/35231/focus=35288
[3] extensions on Snow Leopard http://thread.gmane.org/gmane.comp.graphics.inkscape.devel/35261/focus=35268
[4] backport DXF R13 fixes http://thread.gmane.org/gmane.comp.graphics.inkscape.devel/35231/focus=35288
[5] masks in cairo-based exports: http://thread.gmane.org/gmane.comp.graphics.inkscape.devel/35231/focus=35278
On Thu, 2010-11-04 at 05:35 +0100, ~suv wrote:
On 4/11/10 04:37, Josh Andler wrote:
Any blockers left? Things look pretty ripe right now imho and it seems like momentum has slowed. Better question... any opposition to moving forward?
the list I still hope to get addressed in 0.48.1:
- remove "Cairo PNG" as output file format? [1]
- node tool: restore old behavior (or compromise) for 'Shift+C' [2]
- osx: extensions on Snow Leopard? (no answer from Micheal so far) [3]
- backport DXF R13 fixes from trunk [4]
unlikely, but still:
- no one answered or commented the issue with masks in cairo-based exports... [5]
I would second all of these, especially number 5 as this, I think, is a serious regression. A Cairo expert could probably fix this pretty quick.
One additional problem I would add is while it is now possible to adjust patterns for text (thanks Krzysztof!) each adjustment is adding a new <pattern> node rather than updating the previous one leading to tons of <pattern> defs.
I can have a look at both these problems but not till next week.
Tav
On 04/11/2010, at 3:35 PM, ~suv wrote:
On 4/11/10 04:37, Josh Andler wrote:
Any blockers left? Things look pretty ripe right now imho and it seems like momentum has slowed. Better question... any opposition to moving forward?
the list I still hope to get addressed in 0.48.1:
[...] 3) osx: extensions on Snow Leopard? (no answer from Micheal so far) [3]
This one, bug #482993, is fixed in revision 9883. Please apply it to the release branch.
Cheers, Michael
------ Dr. Michael Wybrow, Research Fellow Clayton School of Information Technology Monash University Wellington Rd, Clayton, Vic 3800, Australia Phone: +613 9905 2479 Mobile: +614 2577 2053
On 4/11/10 05:35, ~suv wrote:
On 4/11/10 04:37, Josh Andler wrote:
Any blockers left? Things look pretty ripe right now imho and it seems like momentum has slowed. Better question... any opposition to moving forward?
current status (2010-11-15):
A -- open issues:
1) ruler redraw issue with GTK+ 2.22 (bug #627134) https://bugs.launchpad.net/inkscape/+bug/627134 -- no progress
2) stock icons with GTK+ 2.22 in non-gnome env (bug #651678, bug #658055) https://bugs.launchpad.net/inkscape/+bug/651678 https://bugs.launchpad.net/inkscape/+bug/658055 Various workarounds reported in the bug comments. Inkscape is basically unusable after upgrading GTK+ on Kubuntu (KDE) and on Mac OS X: more critical than the ruler issue (IMHO). See also [1] -- no progress
3) remove "Cairo PNG" as output file format? [1] (bug #669267) https://bugs.launchpad.net/inkscape/+bug/669267 https://bugs.launchpad.net/inkscape/+bug/404826 Any feedback on this issue? Can anyone confirm that disabling the internal output extension will not have side-effects other than forcing the system clipboard support to use the internal bitmap export instead of 'Cairo PNG' when pasting raster graphics into other applications? The code for the clipboard must be looked at nevertheless (bug #404826). -- needs feedback
4) masks in cairo-based exports (bug #597974) https://bugs.launchpad.net/inkscape/+bug/597974 -- no progress
5) pattern definition spam with pattern-filled text (bug #674109) https://bugs.launchpad.net/inkscape/+bug/674109 -- analyzed by Tav, no further progress reported
B -- fixed issues:
*) node tool: restore old behavior (or compromise) for 'Shift+C' -- done and backported to 0.48.x
*) osx: extensions on Snow Leopard? -- done and backported to 0.48.x
*) backport DXF R13 fixes from trunk -- done
~suv
[1] earlier message with summary of GTK+ 2.22 issues: <http://sourceforge.net/mailarchive/message.php?msg_name=4CDAD2E1.1040902%40users.sourceforge.net>
~suv <suv-sf@...360...> writes:
- remove "Cairo PNG" as output file format? [1] (bug #669267) https://bugs.launchpad.net/inkscape/+bug/669267 https://bugs.launchpad.net/inkscape/+bug/404826
Any feedback on this issue? Can anyone confirm that disabling the internal output extension will not have side-effects other than forcing the system clipboard support to use the internal bitmap export instead of 'Cairo PNG' when pasting raster graphics into other applications? -- needs feedback
But Cairo PNG is useful because it render fonts hinted and LCD filtered, which is good for UI mockups, etc.
Did somebody say "font hinting" and "inkscape" in the same voice?
Wow, please don't get rid of this feature -- I've been wanting something like it for a long time, and never thought to look at the "Save as" dialog.
Though I understand that it just adds UI confusion to have 2 ways to output PNGs.
What can I do to achieve font hinting via the bitmap-export dialogue? A simple checkbox would be very nice, and an export hint to say "always export this object with font-hinting/cairo". I'm a skilled programmer, but have no experience with the Inkscape core (and not heaps of spare time, but that's another story...). Where should I start?
- Bryan
On Tue, Nov 16, 2010 at 08:24, Tobias Wolf <towolf@...400...> wrote:
~suv <suv-sf@...360...> writes:
- remove "Cairo PNG" as output file format? [1] (bug #669267) https://bugs.launchpad.net/inkscape/+bug/669267 https://bugs.launchpad.net/inkscape/+bug/404826
Any feedback on this issue? Can anyone confirm that disabling the internal output extension will not have side-effects other than forcing the system clipboard support to use the internal bitmap export instead of 'Cairo PNG' when pasting raster graphics into other applications? -- needs feedback
But Cairo PNG is useful because it render fonts hinted and LCD filtered, which is good for UI mockups, etc.
Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On 2010-11-15 21:19, Bryan Hoyt | Brush Technology wrote:
Did somebody say "font hinting" and "inkscape" in the same voice?
Wow, please don't get rid of this feature -- I've been wanting something like it for a long time, and never thought to look at the "Save as" dialog.
Though I understand that it just adds UI confusion to have 2 ways to output PNGs.
You're right that for at leas some applications this kind of feature would be cool to have. However, at the moment (as far as I understand) this export method is far from feature complete (and wasn't really meant to be used for serious work). In combination with the UI confusion this leads to people getting stuck on exporting things that should be no problem exporting.
So it might be better to remove the option from the save as dialog for now (I'm thinking a hidden option if it's still needed for testing or something).
What can I do to achieve font hinting via the bitmap-export dialogue? A simple checkbox would be very nice, and an export hint to say "always export this object with font-hinting/cairo". I'm a skilled programmer, but have no experience with the Inkscape core (and not heaps of spare time, but that's another story...). Where should I start?
Personally I'm really looking forward to the GSoC cairo branch (you can check it out from Launchpad to test it if you like), and I'd recommend seeing if that already does what you want by default. If not, it might be easier to modify it so that it does do what you want.
- Bryan
On Tue, Nov 16, 2010 at 08:24, Tobias Wolf <towolf@...400... mailto:towolf@...400...> wrote:
~suv <suv-sf@...360...> writes: > 3) remove "Cairo PNG" as output file format? [1] (bug #669267) > <https://bugs.launchpad.net/inkscape/+bug/669267> > <https://bugs.launchpad.net/inkscape/+bug/404826> > Any feedback on this issue? Can anyone confirm that disabling the > internal output extension will not have side-effects other than forcing > the system clipboard support to use the internal bitmap export instead > of 'Cairo PNG' when pasting raster graphics into other applications? > -- needs feedback But Cairo PNG is useful because it render fonts hinted and LCD filtered, which is good for UI mockups, etc....
On Tue, Nov 16, 2010 at 2:01 AM, Jasper van de Gronde <th.v.d.gronde@...528...> wrote:
On 2010-11-15 21:19, Bryan Hoyt | Brush Technology wrote:
Did somebody say "font hinting" and "inkscape" in the same voice?
Wow, please don't get rid of this feature -- I've been wanting something like it for a long time, and never thought to look at the "Save as" dialog.
Though I understand that it just adds UI confusion to have 2 ways to output PNGs.
You're right that for at leas some applications this kind of feature would be cool to have. However, at the moment (as far as I understand) this export method is far from feature complete (and wasn't really meant to be used for serious work). In combination with the UI confusion this leads to people getting stuck on exporting things that should be no problem exporting.
So it might be better to remove the option from the save as dialog for now (I'm thinking a hidden option if it's still needed for testing or something).
I'll say that I really don't think this is an issue for 0.48.1 personally. When the Save vs Export paradigm changes (much like it has in the GIMP) is the appropriate time to address this, provided nobody has the interest otherwise atm. I admit, it obviously both confuses some and benefits some, but for 0.48 we can chalk it up to a "known issue" imho.
What can I do to achieve font hinting via the bitmap-export dialogue? A simple checkbox would be very nice, and an export hint to say "always export this object with font-hinting/cairo". I'm a skilled programmer, but have no experience with the Inkscape core (and not heaps of spare time, but that's another story...). Where should I start?
Personally I'm really looking forward to the GSoC cairo branch (you can check it out from Launchpad to test it if you like), and I'd recommend seeing if that already does what you want by default. If not, it might be easier to modify it so that it does do what you want.
The Cairo branch is wonderful on many levels. It fixes our seam & pattern issues where gaps and other precision problems have plagued us forever. It's a bit faster and less resource hungry in my limited testing. There are also small other benefits here and there that are like "Yeah, that feels more right" too (feel in a visual sense). However, there are upstream fixes that need to take place for it to even be considered (gradient problems and raster image scaling problems are the big ones as far as I know). To me it's a shame that we can't get more extensive testing in trunk to potentially find other issues, but as things stand, the rule of "don't commit obviously broken stuff" is what prevents that. So yes, lets encourage testing of the branch but know that it just may tease people for now. :)
Cheers, Josh
2010/11/16 Josh Andler <scislac@...400...>:
The Cairo branch is wonderful on many levels. It fixes our seam & pattern issues where gaps and other precision problems have plagued us forever. It's a bit faster and less resource hungry in my limited testing. There are also small other benefits here and there that are like "Yeah, that feels more right" too (feel in a visual sense). However, there are upstream fixes that need to take place for it to even be considered (gradient problems and raster image scaling problems are the big ones as far as I know). To me it's a shame that we can't get more extensive testing in trunk to potentially find other issues, but as things stand, the rule of "don't commit obviously broken stuff" is what prevents that. So yes, lets encourage testing of the branch but know that it just may tease people for now. :)
Cheers, Josh
The gradient precision problems are fixed upstream now. The only remaining big task is converting Pixman to optionally use doubles or floats instead of fixed point to store transformation matrices and gradient coordinates. It's quite a big task unfortunately.
Regards, Krzysztof
2010/11/4 Josh Andler <scislac@...400...>:
Hey all!
Any blockers left? Things look pretty ripe right now imho and it seems like momentum has slowed. Better question... any opposition to moving forward?
There's also the ruler redraw issue on recent Ubuntu. I guess it requires rewriting the ruler drawing functions to use Cairo instead of GDK.
Regards, Krzysztof
Op 05-11-10 06:56, Krzysztof Kosiński schreef:
2010/11/4 Josh Andler<scislac@...400...>:
Hey all!
Any blockers left? Things look pretty ripe right now imho and it seems like momentum has slowed. Better question... any opposition to moving forward?
There's also the ruler redraw issue on recent Ubuntu. I guess it requires rewriting the ruler drawing functions to use Cairo instead of GDK.
Regards, Krzysztof
The Next 800 Companies to Lead America's Growth: New Video Whitepaper David G. Thomson, author of the best-selling book "Blueprint to a Billion" shares his insights and actions to help propel your business during the next growth cycle. Listen Now! http://p.sf.net/sfu/SAP-dev2dev _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
The ruler redraw issue exits also on OpenSuse 11.4 milestone 2, Inkscape 0.48.0 r9654
regards, Jogchum
Do you have the willingness and inclination to address this (evil ruler issue)? To put it lightly, it's super aggravating. This would be king of .1 fixes that I can see and getting that LP thread in my mailbox killed would win tons of random jabber praise points. On Nov 4, 2010 10:56 PM, "Krzysztof Kosiński" <tweenk.pl@...400...> wrote:
2010/11/4 Josh Andler <scislac@...400...>:
Hey all!
Any blockers left? Things look pretty ripe right now imho and it seems like momentum has slowed. Better question... any opposition to moving forward?
There's also the ruler redraw issue on recent Ubuntu. I guess it requires rewriting the ruler drawing functions to use Cairo instead of GDK.
Regards, Krzysztof
W dniu 5 listopada 2010 09:40 użytkownik Josh Andler <scislac@...400...> napisał:
Do you have the willingness and inclination to address this (evil ruler issue)? To put it lightly, it's super aggravating. This would be king of .1 fixes that I can see and getting that LP thread in my mailbox killed would win tons of random jabber praise points.
Fixed in trunk 9905 / branch 9725.
Regards, Krzysztof
On 5/11/10 06:56, Krzysztof Kosiński wrote:
2010/11/4 Josh Andler <scislac@...400...>:
Any blockers left? Things look pretty ripe right now imho and it seems like momentum has slowed. Better question... any opposition to moving forward?
There's also the ruler redraw issue on recent Ubuntu. I guess it requires rewriting the ruler drawing functions to use Cairo instead of GDK.
Also affects Inkscape on Mac OS X [1] after upgrading MacPorts to the most current versions of the required dependencies (2010-11-09).
The relevant upgrades to trigger the ruler redraw issue seem to be among gtk2: 2.20.1 -> 2.22.0 gtkmm: 2.18.2 -> 2.20.3 glib2: 2.24.1 -> 2.26.0 glibmm: 2.22.2 -> 2.24.2 gdk-pixbuf2: - -> 2.22.1
[1] tested on Mac OS X 10.5.8 (i386), with XQuartz 2.4.0, MacPorts 1.9.2 and inkscape 0.48.0.
~suv
On 5/11/10 06:56, Krzysztof Kosiński wrote:
2010/11/4 Josh Andler <scislac@...400...>:
Any blockers left? Things look pretty ripe right now imho and it seems like momentum has slowed. Better question... any opposition to moving forward?
There's also the ruler redraw issue on recent Ubuntu. I guess it requires rewriting the ruler drawing functions to use Cairo instead of GDK.
Inkscape's issues with current GTK+ 2.22:
--- all platforms:
1) ruler redraw issue --------------------- https://bugs.launchpad.net/inkscape/+bug/627134
--- non-gnome environments [1]:
2) Recent files --------------- https://bugs.launchpad.net/inkscape/+bug/651678
The fallback icon 'gtk-file' (GTK_STOCK_FILE) for the items in 'File > Open Recent' is not found (if mime-type lookup fails?), Inkscape crashes in
Gtk:ERROR:gtkrecentmanager.c:1942:get_icon_fallback: assertion failed: (retval != NULL)
Workarounds: a) install the gnome or tango icon theme and use 'gtk-icon-theme-name="gnome"' or 'gtk-icon-theme-name="tango"' b) put a 'gtk-file.svg' in '~/.local/share/inkscape/icons' [2]
3) Document Properties ---------------------- https://bugs.launchpad.net/inkscape/+bug/658055
If no files are listed in 'File > Open Recent' (e.g. new user, or new account), Inkscape crashes when opening the 'Document Properties' dialog (the icon used for the dockable dialog can't be found, whereas the same icon is used without errors in the commands bar) [3]:
terminate called after throwing an instance of 'Gtk::IconThemeError'
Workarounds: a) install the gnome or tango icon theme and use 'gtk-icon-theme-name="gnome"' or 'gtk-icon-theme-name="tango"' b) put a 'gtk-properties.svg' in '~/.local/share/inkscape/icons' [2]
4) Text tool: font selector --------------------------- Alert icon for missing fonts is not found, but Inkscape doesn't crash.
Workaround: unknown
5) Blurry icons return ---------------------- If gtk-icon-theme-name is set to 'gnome' or 'tango' (in ~/.gtkrc-2.0), Inkscape's toolbar icons appear blurried: the icons on the commands bar render sharply when opening a second window, the icons on the controls bar of the individual tools however remain slightly blurry.
Icons taken from the gnome or tango icon theme are crisp, but apparently cause Inkscape's SVG icons to be scaled (blurried). [4]
~suv
[1] tested with Inkscape 0.48.0 and 0.48+devel r9888 in MacPorts 1.9.2 on Mac OS X 10.5.8; from the bug reports: also applies to KDE/Kubuntu
[2] for the test, the gtk stock icons have been used from http://git.gnome.org/browse/gtk+/tree/gtk/stock-icons/16
[3] backtrace with Inkscape 0.48+devel r9888 attached (crash when opening document properties window)
[4] more screenshots available, if needed: screenshot of Inkscape r9888 with gnome icon theme and default gtk theme (fallback, raleigh) attached.
terminate called after throwing an instance of 'Gtk::IconThemeError'
Program received signal SIGABRT, Aborted. 0x901cbe42 in __kill () (gdb) bt #0 0x901cbe42 in __kill () #1 0x901cbe34 in kill$UNIX2003 () #2 0x9023e23a in raise () #3 0x9024a679 in abort () #4 0x90e85005 in __gnu_cxx::__verbose_terminate_handler () #5 0x90e8310c in __gxx_personality_v0 () #6 0x90e8314b in std::terminate () #7 0x90e83261 in __cxa_throw () #8 0x01140d1e in Gtk::IconThemeError::throw_func () #9 0x015a228f in Glib::Error::throw_exception () #10 0x011417fb in Gtk::IconTheme::load_icon () #11 0x00610129 in Inkscape::UI::Widget::DockItem::DockItem (this=0x653e928, dock=@0x4c27200, name=@0xbfffdd40, long_name=@0xbfffdd44, icon_name=@0xbfffdd48, state=Inkscape::UI::Widget::DockItem::DOCKED_STATE) at ui/widget/dock-item.cpp:47 #12 0x004b57e8 in Inkscape::UI::Dialog::Behavior::DockBehavior::DockBehavior (this=0x653e920, dialog=@0x653c61c) at ui/dialog/dock-behavior.cpp:48 #13 0x004b5be9 in Inkscape::UI::Dialog::Behavior::DockBehavior::create (dialog=@0x653c61c) at ui/dialog/dock-behavior.cpp:58 #14 0x004ad8cd in Inkscape::UI::Dialog::Dialog::Dialog (this=0x653c61c, behavior_factory=0x4b5bc0 Inkscape::UI::Dialog::Behavior::DockBehavior::create(Inkscape::UI::Dialog::Dialog&), prefs_path=0x641de1c "/dialogs/documentoptions", verb_num=181, apply_label=@0x72fa46c) at ui/dialog/dialog.cpp:108 #15 0x004b3af7 in Inkscape::UI::Dialog::PanelDialogInkscape::UI::Dialog::Behavior::DockBehavior::PanelDialog (this=0x653c610, panel=@0x72fa400, prefs_path=0x641de1c "/dialogs/documentoptions", verb_num=181, apply_label=@0x72fa46c) at panel-dialog.h:134 #16 0x004b4d44 in Inkscape::UI::Dialog::PanelDialogInkscape::UI::Dialog::Behavior::DockBehavior::createInkscape::UI::Dialog::DocumentProperties () at panel-dialog.h:159 #17 0x004aeceb in Inkscape::UI::Dialog::(anonymous namespace)::create<Inkscape::UI::Dialog::DocumentProperties, Inkscape::UI::Dialog::Behavior::DockBehavior> () at ui/dialog/dialog-manager.cpp:60 #18 0x004ae581 in Inkscape::UI::Dialog::DialogManager::getDialog (this=0x4644070, name=3273) at ui/dialog/dialog-manager.cpp:216 #19 0x004ae691 in Inkscape::UI::Dialog::DialogManager::showDialog () at ui/dialog/dialog-manager.cpp:235 #20 0x004ae691 in Inkscape::UI::Dialog::DialogManager::showDialog (this=0x4644070, name=0x82a9c3 "DocumentProperties") at ui/dialog/dialog-manager.cpp:228 #21 0x0031c940 in sp_action_perform (action=0x42dec78, data=0x0) at helper/action.cpp:181 #22 0x030e2539 in g_closure_invoke () #23 0x030f4163 in signal_emit_unlocked_R () #24 0x030f57f1 in g_signal_emit_valist () #25 0x030f5af9 in g_signal_emit () #26 0x016600d0 in _gtk_action_emit_activate () #27 0x018122f9 in button_clicked () #28 0x030e2539 in g_closure_invoke () #29 0x030f4163 in signal_emit_unlocked_R () #30 0x030f57f1 in g_signal_emit_valist () #31 0x030f5af9 in g_signal_emit () #32 0x0167aa5a in gtk_button_clicked () #33 0x0167cc08 in gtk_real_button_released () #34 0x030e2539 in g_closure_invoke () #35 0x030f3dd8 in signal_emit_unlocked_R () #36 0x030f57f1 in g_signal_emit_valist () #37 0x030f5af9 in g_signal_emit () #38 0x0167a9ba in gtk_button_released () #39 0x0167bc9b in gtk_button_button_release () #40 0x017335fb in _gtk_marshal_BOOLEAN__BOXED () #41 0x030e2539 in g_closure_invoke () #42 0x030f42e8 in signal_emit_unlocked_R () #43 0x030f5537 in g_signal_emit_valist () #44 0x030f5af9 in g_signal_emit () #45 0x01862996 in gtk_widget_event_internal () #46 0x017317f8 in gtk_propagate_event () #47 0x01731d6d in gtk_main_do_event () #48 0x02572b15 in gdk_event_dispatch () #49 0x0319aacd in g_main_context_dispatch () #50 0x0319e5cb in g_main_context_iterate () #51 0x0319e8a7 in g_main_loop_run () #52 0x01730d41 in gtk_main () #53 0x0114feab in Gtk::Main::run () #54 0x0000560c in ~vector [inlined] () at stl_vector.h:986 #55 sp_main_gui (argc=1, argv=0xbffff3b4) at main.cpp:993 #56 0x00004206 in start () (gdb)
On 10/11/10 18:14, ~suv wrote:
Inkscape's issues with current GTK+ 2.22:
- Recent files
https://bugs.launchpad.net/inkscape/+bug/651678 3) Document Properties https://bugs.launchpad.net/inkscape/+bug/658055 4) Text tool: font selector Alert icon for missing fonts is not found, but Inkscape doesn't crash.
Forgot to add:
These issues seem to be caused by a change in GTK+ 2.22 as described in https://bugs.launchpad.net/inkscape/+bug/651678/comments/18
Overview of Changes from GTK+ 2.21.7 to 2.21.8:
- GTK+ now uses standard icon names for stock icons, where applicable
http://mail.gnome.org/archives/gtk-devel-list/2010-September/msg00204.html
Bug 629878 – gtk+ - Missing icons: https://bugzilla.gnome.org/show_bug.cgi?id=629878
~suv
On Nov 10, 2010, at 10:11 AM, ~suv wrote:
On 10/11/10 18:14, ~suv wrote:
Inkscape's issues with current GTK+ 2.22:
- Recent files
https://bugs.launchpad.net/inkscape/+bug/651678 3) Document Properties https://bugs.launchpad.net/inkscape/+bug/658055 4) Text tool: font selector Alert icon for missing fonts is not found, but Inkscape doesn't crash.
Forgot to add:
These issues seem to be caused by a change in GTK+ 2.22 as described in https://bugs.launchpad.net/inkscape/+bug/651678/comments/18
Overview of Changes from GTK+ 2.21.7 to 2.21.8:
- GTK+ now uses standard icon names for stock icons, where applicable
http://mail.gnome.org/archives/gtk-devel-list/2010-September/msg00204.html
Bug 629878 – gtk+ - Missing icons: https://bugzilla.gnome.org/show_bug.cgi?id=629878
I was able to update macports and get this reproduced.
The problem was as I thought; that is there are issues with themeable stock items vs. icon themes and how they fallback and are called.
The document properties bug in 658055 was expressly due to looking in one when the icon is present in the other. There was a quick hack added to prevent outright crashing (via a hail-mary try/catch), but I've got a proper fix now that includes checking the has_icon() call upfront and thus avoiding calls that would trigger an error to be thrown. I correct fix is now in.
The recent files issue is easily fixed, as I suspected. We just need to have a fallback registered in icons.svg and then the crash goes away. And by registering it as a fallback from our icons.svg file it does not take over the users normal defaults. It will only show up as an icon of last resort (which is exactly what we want). Some of the work-arounds, such as adding files in one of the directories, end up taking over the users preferred theme settings. I just need to clean up this code before committing.
The text tool alert icon is caused by the same fallback/missing error. I'll probably have a fix for this one later.
participants (10)
-
Bryan Hoyt | Brush Technology -
Jasper van de Gronde -
Jogchum Reitsma -
Jon Cruz -
Josh Andler -
Krzysztof Kosiński -
Michael Wybrow -
Tavmjong Bah -
Tobias Wolf -
~suv