You may simply remove everything except the util folder,and dom.h domimpl.cpp domimpl.h domptr.cpp domptr.h ucd.cpp ucd.h uri.cpp uri.h
Actually, that's about 50000 lines less :) .
------------------------------------------------------------------------------- Language files blank comment code ------------------------------------------------------------------------------- C++ 797 60098 60211 295830 C/C++ Header 1060 32179 58535 90647
------------------------------------------------------------------------------- Language files blank comment code ------------------------------------------------------------------------------- C++ 782 57002 57216 286170 C/C++ Header 1037 24443 43941 77657
Regards, Markus
-----Ursprüngliche Nachricht----- Von: Martin Owens [mailto:doctormo@...400...] Gesendet: Dienstag, 25. Februar 2014 17:59 An: Bryce Harrington Cc: Inkscape Devel List; Inkscape User Community Betreff: Re: [Inkscape-devel] URI
On Mon, 2014-02-24 at 23:51 -0800, Bryce Harringtonwrote:
- Remove dom/ directory
This directory contains strange code which is barelyused. The only class which is actually used is the URI class.
That's worth knowing, I'll hack that up in my branch as Iadd the data uri support.
Martin,
2014-02-26 3:19 GMT+01:00 Markus Engel <p637777@...1081...>:
You may simply remove everything except the util folder, and dom.h domimpl.cpp domimpl.h domptr.cpp domptr.h ucd.cpp ucd.h uri.cpp uri.h
IIRC, dom.h is only used in ODG import (src/extension/internal/odf.cpp), and even there it looks like only the URI and DOMString classes are actually used. The latter can be trivially replaced with Glib::ustring.
Regards, Krzysztof
Digging into the job, I've ripped away dom/* and most of the code works.
I've ported color-profile.cpp which was using the dom::URI to Inkscape::URI and the same replacement can be done to odf extension.
A missing piece was zipfile support.
src/dom/util/ziptool.cpp/.h was a self-contained zip implementation so I've moved that to src/util/ since it has no equivalent functionality.
That worked well. I've hit a small problem with Inkscape::URI not having a constructor with no-arguments which I think can be solved by adding an OdfOutput constructor which initalises the URI instead of it auto initalising (c++ does this right?), but this seems odd to me as if the Odf shouldn't initalise the URI until it needs it.
Thoughts?
Best Regards, Martin Owens
On Wed, 2014-02-26 at 03:49 +0100, Krzysztof Kosiński wrote:
2014-02-26 3:19 GMT+01:00 Markus Engel <p637777@...1081...>:
You may simply remove everything except the util folder, and dom.h domimpl.cpp domimpl.h domptr.cpp domptr.h ucd.cpp ucd.h uri.cpp uri.h
IIRC, dom.h is only used in ODG import (src/extension/internal/odf.cpp), and even there it looks like only the URI and DOMString classes are actually used. The latter can be trivially replaced with Glib::ustring.
Regards, Krzysztof
participants (3)
-
Krzysztof Kosiński -
Markus Engel -
Martin Owens