Patch for restoring window geom from prefs uploaded
I finished my patch for saving and restoring window geometry from preferences, and uploaded it to sourceforge.
https://sourceforge.net/tracker/?func=detail&atid=604308&aid=1734633...
Comments / suggestions appreciated. --bb
On 6/10/07, Bill Baxter <wbaxter@...400...> wrote:
I finished my patch for saving and restoring window geometry from preferences, and uploaded it to sourceforge.
Thanks! I'm looking at it right now and will let you know if I have any comments or requests.
On 6/13/07, bulia byak <buliabyak@...400...> wrote:
On 6/10/07, Bill Baxter <wbaxter@...400...> wrote:
I finished my patch for saving and restoring window geometry from preferences, and uploaded it to sourceforge.
Thanks! I'm looking at it right now and will let you know if I have any comments or requests.
Thank you for taking a look at it.
One thing that's a little annoying is that the window seems to appear briefly in the wrong position. Can you see an easy way to fix that? It seems like it may be an issue with the current feature of positions saved in documents as well. So maybe I shouldn't worry too much.
--bb
On 6/13/07, Bill Baxter <wbaxter@...400...> wrote:
One thing that's a little annoying is that the window seems to appear briefly in the wrong position. Can you see an easy way to fix that? It seems like it may be an issue with the current feature of positions saved in documents as well. So maybe I shouldn't worry too much.
I would LOVE to fix this but I don't know how. It's just another of GTK's quirks. Without going into too much detail (much of it I don't even remember by now), moving a window only works after the window is shown. Moving it while hidden and then showing it would fix this annoyance but it does not work (or maybe does not work _always_ - again, I don't remember details now).
On 6/10/07, Bill Baxter <wbaxter@...400...> wrote: https://sourceforge.net/tracker/?func=detail&atid=604308&aid=1734633...
Comments / suggestions appreciated.
I tried the patch and the code seems to work fine. However I'm not sure about the UI. Right now it just adds another checkbox so the Windows tab in prefs has two checkboxes side by side: "Save window geometry with documents" and "Remember window geometry". This is very confusing, and the fact that they are both checkboxes means that there are 4 different possible settings, each one potentially with its own quirks and, in any case, each one requiring its own documentation. So what I propose instead is using two radio buttons:
- Save and restore window geometry for each document - Remember and use last window's geometry
I don't think anyone will want to use a combination of these options - it's usually one way or the other.
What do you think?
On 6/14/07, bulia byak <buliabyak@...400...> wrote:
On 6/10/07, Bill Baxter <wbaxter@...400...> wrote:
https://sourceforge.net/tracker/?func=detail&atid=604308&aid=1734633...
Comments / suggestions appreciated.
I tried the patch and the code seems to work fine. However I'm not sure about the UI. Right now it just adds another checkbox so the Windows tab in prefs has two checkboxes side by side: "Save window geometry with documents" and "Remember window geometry". This is very confusing, and the fact that they are both checkboxes means that there are 4 different possible settings, each one potentially with its own quirks and, in any case, each one requiring its own documentation. So what I propose instead is using two radio buttons:
- Save and restore window geometry for each document
- Remember and use last window's geometry
I don't think anyone will want to use a combination of these options - it's usually one way or the other.
What do you think?
Well I could imagine someone wanting to use both (the behavior I implemented uses document-stored positions if available and falls back to prefs otherwise -- if both options are checked). But I think it's fringe enough and difficult enough to explain the connection between those two that the radio is better.
I think the tool-tip helps should say something like:
"Save and restore window geometry for each document (saves geometry in the document)" "Remember and use the last window's geometry (saves geometry to user preferences)"
Otherwise it's not at all obvious that setting 1 will make changes to documents that are visible to other users.
Shall I implement the change or can you do it?
--bb
On 6/13/07, Bill Baxter <wbaxter@...400...> wrote:
Well I could imagine someone wanting to use both (the behavior I implemented uses document-stored positions if available and falls back to prefs otherwise -- if both options are checked). But I think it's fringe enough and difficult enough to explain the connection between those two that the radio is better.
Agreed, let's make it simple
I think the tool-tip helps should say something like:
"Save and restore window geometry for each document (saves geometry in the document)" "Remember and use the last window's geometry (saves geometry to user preferences)"
Yes, sounds good
Shall I implement the change or can you do it?
Please resubmit the patch with this change and I'll commit it - thanks!
Also, please add a detailed note about the change to http://wiki.inkscape.org/wiki/index.php/ReleaseNotes046 (the "UI" section is the most approproate I think)
Patch changes all done and uploaded. I just realized I misspelled your name in the patch tracker though... sorry. Going to try to update the ReleaseNotes now.
--bb
On 6/14/07, bulia byak <buliabyak@...400...> wrote:
On 6/13/07, Bill Baxter <wbaxter@...400...> wrote:
Well I could imagine someone wanting to use both (the behavior I
implemented
uses document-stored positions if available and falls back to prefs otherwise -- if both options are checked). But I think it's fringe enough and difficult enough to explain the connection between those two that the radio is better.
Agreed, let's make it simple
I think the tool-tip helps should say something like:
"Save and restore window geometry for each document (saves geometry
in
the document)" "Remember and use the last window's geometry (saves geometry to user preferences)"
Yes, sounds good
Shall I implement the change or can you do it?
Please resubmit the patch with this change and I'll commit it - thanks!
Also, please add a detailed note about the change to http://wiki.inkscape.org/wiki/index.php/ReleaseNotes046 (the "UI" section is the most approproate I think)
-- bulia byak Inkscape. Draw Freely. http://www.inkscape.org
participants (2)
-
Bill Baxter -
bulia byak