9:58 p.m.
Hi,
Alex Leone has attached a patch which add margin options for the "Fit page to
selection" button in the document properties. I've tested it successfully on
Ubuntu 9.10, but it would be nice if a C++/UI expert review the code before we commit it
(see https://bugs.edge.launchpad.net/inkscape/+bug/499942).
Regards,
--
Nicolas
10:09 p.m.
În data de Marți 29 Decembrie 2009 02:58:37 pm Nicolas Dufour a scris:
Hi,
Alex Leone has attached a patch which add margin options for the "Fit page
to selection" button in the document properties.
Actually, I use this without the margins to keep the grid in place. The grid
is important for my technical drawings (schematic diagrams). If this should be
the default, could you please add an option in the Inkscape preferences so as
to not add a margin if desired.
Thank you.
Arcadie
I've tested it
successfully on Ubuntu 9.10, but it would be nice if a C++/UI expert
review the code before we commit it (see
https://bugs.edge.launchpad.net/inkscape/+bug/499942).
Regards,
--
Nicolas
---------------------------------------------------------------------------
--- This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and
easy Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Inkscape-devel mailing list
Inkscape-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/inkscape-devel
6:07 a.m.
I've submitted an updated UI for this patch - any comments?
It adds a "Fit page to selection of drawing" frame in Document Properties.
Attached is a screenshot.
- Alex
On Tue, Dec 29, 2009 at 4:58 AM, Nicolas Dufour <nicoduf@...48...> wrote:
Hi,
Alex Leone has attached a patch which add margin options for the "Fit page to
selection" button in the document properties. I've tested it successfully on
Ubuntu 9.10, but it would be nice if a C++/UI expert review the code before we commit it
(see https://bugs.edge.launchpad.net/inkscape/+bug/499942).
Regards,
--
Nicolas
7 a.m.
On Sat, Jan 2, 2010 at 5:07 PM, Alex Leone <acleone@...400...> wrote:
I've submitted an updated UI for this patch - any comments?
It adds a "Fit page to selection of drawing" frame in Document Properties.
Attached is a screenshot.
The more we add to it, the clearer it is that all this "Fit" machinery
is out of place in this dialog. This is Document Properties dialog
where you're supposed to view and adjust properties, but "Fit" is not
a property; it's more of a command. If we leave it in this dialog with
all these options, please make it an expandable section, with a
triangle marker, and move it back to the "Custom size" frame.
--
bulia byak
Inkscape. Draw Freely.
http://www.inkscape.org
7:23 a.m.
The original patch used an expandable section in the Custom Size
frame, see attached.
Any more comments?
- Alex
On Sat, Jan 2, 2010 at 2:00 PM, bulia byak <buliabyak@...400...> wrote:
On Sat, Jan 2, 2010 at 5:07 PM, Alex Leone <acleone@...400...>
wrote:
> I've submitted an updated UI for this patch - any comments?
>
> It adds a "Fit page to selection of drawing" frame in Document Properties.
>
> Attached is a screenshot.
The more we add to it, the clearer it is that all this "Fit" machinery
is out of place in this dialog. This is Document Properties dialog
where you're supposed to view and adjust properties, but "Fit" is not
a property; it's more of a command. If we leave it in this dialog with
all these options, please make it an expandable section, with a
triangle marker, and move it back to the "Custom size" frame.
--
bulia byak
Inkscape. Draw Freely.
http://www.inkscape.org
8:05 a.m.
On 01/02/2010 11:23 PM, Alex Leone wrote:
The original patch used an expandable section in the Custom Size
frame, see attached.
Any more comments?
IMHO it would be even more clean if you put the "fit page to selection"
button inside the expandable section, and label the expandable section
"fit to page".
Diederik
9:02 a.m.
2010/1/3 Diederik van Lierop <mail@...1689...>:
IMHO it would be even more clean if you put the "fit page to
selection"
button inside the expandable section, and label the expandable section
"fit to page".
Diederik
It should be "fit page", not "fit to page" - the latter suggests
resizing the drawing to match page size.
The option I like most is an expandable "Fit page" section with the
fit page button inside it. It should remember whether it's expanded or
collapsed.
Regards, Krzysztof
10:58 a.m.
On Sat, Jan 2, 2010 at 7:05 PM, Diederik van Lierop <mail@...1689...> wrote:
On 01/02/2010 11:23 PM, Alex Leone wrote:
> The original patch used an expandable section in the Custom Size
> frame, see attached.
>
> Any more comments?
>
IMHO it would be even more clean if you put the "fit page to selection"
button inside the expandable section, and label the expandable section
"fit to page".
Yes. And also, can we get rid of the second Units chooser inside this
section? Can it use the same chooser as the Custom frame?
--
bulia byak
Inkscape. Draw Freely.
http://www.inkscape.org
2:26 p.m.
On Jan 2, 2010, at 2:00 PM, bulia byak wrote:
The more we add to it, the clearer it is that all this
"Fit" machinery
is out of place in this dialog. This is Document Properties dialog
where you're supposed to view and adjust properties, but "Fit" is not
a property; it's more of a command. If we leave it in this dialog with
all these options, please make it an expandable section, with a
triangle marker, and move it back to the "Custom size" frame.
Yes, I think you're exactly right.
"Fit page to selection" is really an operation in and of itself. It might
warrant a button on the Document Properties page, but...
I think there's a strong argument for making it similar to various raster program who
have a "Image Size" or "Resize Canvas" type operation.
From a usability standpoint keeping things overloaded inside the
"Document Properties" sounds like more and more of a poor choice. Combine this
with the fact that users of most other graphics programs are used to a separate
"Image Size" or "Canvas Size" dialog, and I think you're right and
we really need to go that route.
6:55 a.m.
Another UI version, now with the "Fit page to selection" button moved
into an expandable section in the "Custom size" frame. The expander
remembers it's state if the dialog is closed.
(See attached for screenshots)
Comments?
- Alex
(full patch: https://bugs.launchpad.net/inkscape/+bug/499942 )
8:33 a.m.
On Jan 3, 2010, at 1:55 PM, Alex Leone wrote:
Comments?
Yes,
Especially looking at the "after" mockup, I think all that is in the
"Custom size" pane really needs to be stand-alone in its own dialog.
"Format" perhaps also belongs there.
Compare that to GIMP's
http://docs.gimp.org/en/gimp-image-resize.html
10:20 a.m.
On Sun, Jan 3, 2010 at 7:33 PM, Jon Cruz <jon@...18...> wrote:
Especially looking at the "after" mockup, I think all that
is in the "Custom size" pane really needs to be stand-alone in its own dialog.
I don't like the idea of adding a dialog when we can avoid it. I think
an expandable section is a workable compromise. Changing canvas size
in a bitmap editor is a much more drastic and possibly destructive
operation, so comparison with Gimp is not entirely justified.
--
bulia byak
Inkscape. Draw Freely.
http://www.inkscape.org
10:28 a.m.
On Sun, Jan 3, 2010 at 5:55 PM, Alex Leone <acleone@...400...> wrote:
Another UI version, now with the "Fit page to selection"
button moved
into an expandable section in the "Custom size" frame. The expander
remembers it's state if the dialog is closed.
(See attached for screenshots)
Comments?
Much better, thanks. However, we have three different nouns there that
refer to the same thing: "format", "size", and "page". At
least one of
them must go. I propose to
- rename "Format" section to "Page size"
- remove "Page size:" label
- rename "Page orientation" to "Orientation"
- rename expandable section to "Resize to match content..."
- rename the button to "Resize page to selection/drawing with
margins:" and put it above the margin fields, not below
--
bulia byak
Inkscape. Draw Freely.
http://www.inkscape.org
10:40 p.m.
On 01/03/2010 08:28 PM, bulia byak wrote:
On Sun, Jan 3, 2010 at 5:55 PM, Alex Leone<acleone@...400...>
wrote:
> Another UI version, now with the "Fit page to selection" button moved
> into an expandable section in the "Custom size" frame. The expander
> remembers it's state if the dialog is closed.
>
> (See attached for screenshots)
>
> Comments?
Much better, thanks. However, we have three different nouns there that
refer to the same thing: "format", "size", and "page". At
least one of
them must go. I propose to
- rename "Format" section to "Page size"
- remove "Page size:" label
- rename "Page orientation" to "Orientation"
- rename expandable section to "Resize to match content..."
- rename the button to "Resize page to selection/drawing with
margins:" and put it above the margin fields, not below
Not to be picky, but since we're being picky, I don't think "match" is
the correct verb there. Maybe it would be better if it just said
"Resize page to content"? It's also a bit more concise.
Otherwise, I think Bulia's suggestions will make things make a lot more
sense. I agree that this should all be on one tab - it all seems to go
together to me :)
JF
12:55 a.m.
On Mon, Jan 4, 2010 at 9:40 AM, Joshua Facemyer <jfacemyer@...400...> wrote:
Not to be picky, but since we're being picky, I don't think
"match" is the
correct verb there. Maybe it would be better if it just said "Resize page
to content"? It's also a bit more concise.
Agreed.
--
bulia byak
Inkscape. Draw Freely.
http://www.inkscape.org
10:26 a.m.
Another UI version:
- "Format" header changed to "Page Size"
- Removed "Page Size:" label before list of page sizes (list with A4,
letter, etc)
- Changed "Page orientation:" to "Orientation:"
- The expander is now labelled "Resize page to content..."
- The "Resize page to selection/drawing with margins:" button is the first
thing in the expander
See Attached Screenshots. Any other comments on the UI?
Eventually I would like to add an option to resize the page to content on
save. Does anyone think this would be a useful feature?
- Alex
10:30 a.m.
(Sorry for the double message - Gmail messages won't show in the
archive unless plain text)
Another UI version:
- "Format" header changed to "Page Size"
- Removed "Page Size:" label before list of page sizes (list with A4,
letter, etc)
- Changed "Page orientation:" to "Orientation:"
- The expander is now labelled "Resize page to content..."
- The "Resize page to selection/drawing with margins:" button is the
first thing in the expander
See Attached Screenshots. Any other comments on the UI?
Eventually I would like to add an option to resize the page to content
on save. Does anyone think this would be a useful feature?
- Alex
11:16 a.m.
On Thu, Jan 7, 2010 at 9:30 PM, Alex Leone <acleone@...400...> wrote:
See Attached Screenshots. Any other comments on the UI?
Excellent, thanks. Much cleaner now. I think this can be committed.
Any other comments anyone?
--
bulia byak
Inkscape. Draw Freely.
http://www.inkscape.org
noon
2010/1/8 bulia byak <buliabyak@...400...>:
On Thu, Jan 7, 2010 at 9:30 PM, Alex Leone <acleone@...400...>
wrote:
> See Attached Screenshots. Any other comments on the UI?
Excellent, thanks. Much cleaner now. I think this can be committed.
Any other comments anyone?
The button text is very long and ends with a colon. The "with
margins:" looks very out of place. I have two ideas:
a) Remove "with margins:" from the button text; add a label "Margins"
above the spinboxes.
b) Remove "with margins:" from the button text; change the label
"Top:" to "Top margin:".
Regards, Krzysztof
1:21 p.m.
I think "Top margin:" is cleaner. The button now reads "Resize page
to drawing or selection".
See attached.
- Alex
2010/1/7 Krzysztof Kosiński <tweenk.pl@...400...>
The button text is very long and ends with a colon. The "with
margins:" looks very out of place. I have two ideas:
a) Remove "with margins:" from the button text; add a label
"Margins"
above the spinboxes.
b) Remove "with margins:" from the button text; change the label
"Top:" to "Top margin:".
Regards, Krzysztof
1:44 p.m.
On Jan 7, 2010, at 8:21 PM, Alex Leone wrote:
I think "Top margin:" is cleaner. The button now reads
"Resize page
to drawing or selection".
See attached.
Looking much better... though I do want to second the concerns on height.
I think that is coming out at 621 pixels high. My netbook only gets 480 minus the
statusbar.
10:22 p.m.
Mostly fine, but something still strikes me as wrong with the redundancy
between the label and the button. I can't think of how to make it work
well, though.
I think the problem is that the button shouldn't contain the explanation
of what the button does, if it's not concise (or completely intuitive).
I think a bit more explanation is in order and the button shouldn't
contain it.
Maybe it would be better to have a short note above the button saying
"...if objects are selected, the page will be resized to fit the
selection; otherwise the page will be resized to fit all objects on the
canvas."
Then have the button below labeled "resize".
I think this (or something similar) would be much more useful and clean.
JF
On 01/07/2010 08:26 PM, Alex Leone wrote:
Another UI version:
- "Format" header changed to "Page Size"
- Removed "Page Size:" label before list of page sizes (list with A4,
letter, etc)
- Changed "Page orientation:" to "Orientation:"
- The expander is now labelled "Resize page to content..."
- The "Resize page to selection/drawing with margins:" button is the
first thing in the expander
See Attached Screenshots. Any other comments on the UI?
Eventually I would like to add an option to resize the page to content
on save. Does anyone think this would be a useful feature?
- Alex
4824
days inactive
4834
days old
inkscape-devel@lists.inkscape.org
23 comments
8 participants
participants (8)
-
Alex Leone -
Arcadie M. Cracan -
bulia byak -
Diederik van Lierop -
Jon Cruz -
Joshua Facemyer -
Krzysztof Kosiński -
Nicolas Dufour