Hi! This week I added loading procedural templates into my widget so they could be listed next to the static templates. This required some changes in the current NewFromTemplate code but it's functionality remains unchanged.
Slagvi, Jan Darowski
On 2013-08-24 23:40 +0200, Jan Darowski wrote:
This week I added loading procedural templates into my widget so they could be listed next to the static templates. This required some changes in the current NewFromTemplate code but it's functionality remains unchanged.
A couple of issues I noticed with trunk builds after the commit of the first part ("NewFromTemplate GSoC project for static templates") http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12476 as well as with an up-to-date build of your branch (r12482) https://code.launchpad.net/~slagvi/inkscape/templates:
- UI regression
It is no longer possible to open multiple new documents from within the same inkscape process:
Previous behavior: 'Ctrl+N', or selecting a template from the menu 'File > New' always opens a new document in a new document window
Current behavior (>= r12476): 'Ctrl+N', or selecting a specific template in the new dialog re-uses the current document window unless it has an existing document loaded, or the current new document has been dirtied.
- GUI regression (minor)
After opening a new document (Ctrl+N, or selecting a template in the new dialog), the mouse cursor for canvas stays 'busy' in the original window (or - if it was new and not yet dirtied - in the current resued document window) until a tool switch triggers a new cursor symbol to be used. The cursor symbol is misleading, since the main process is not blocked (inkscape is not actually 'busy'). Does not happen with older builds (< r12476) or stable.
- GUI usability (keyboard)
The new dialog currently forces the use of the mouse, even to trigger a button (or presumed default action). It would be great if the new dialog also supported features like 1) double-click on list item creates new document based on template (see for example the dialog to select path effects) 2) basic keyboard-based navigation (like in all other parts of the GUI) Currently, activation of a focused GUI widget with <Space> or <Return> does not work for both buttons in the new dialog: the buttons are visually pressed, but nothing else happens (no action triggered).
- Backwards compatibility (template names)
All templates whose file names start with 'default' are now ommitted from the list.
This affects a couple of shared templates: Variations of the basic default document with A4 page size, using different base units (mm, pt) are no longer included in the list of available templates: - default_mm.svg - default_pt.svg
as well as user templates: Many of my custom user templates for example had been created based on a simple naming scheme: basename of original file ("default") with a short string appended describing the major difference: - default-400x400.svg - default-dark.svg - default-isometry-1.svg - ... These custom templates are no longer shown in the list of available templates with current trunk builds.
AFAIU the naming scheme for translated templates uses a '.' as separator ('default.xy.svg') - thus none of the mentioned missing templates could (or should) be mistaken as translated versions of the 'default.svg' template.
Please let me know if you would prefer that these issues get reported in the bug tracker (instead of mentioning them here on the mailing list).
(All items have been tested and reproduced with current trunk on Ubuntu 12.04 (PPA), 12.10 (local build), 13.04 (PPA) and on OS X 10.7.5)
I will fix these things so there is no need to report them in the bug tracker. To be honest, behavior described by you as the first problem (UI regression) is done like that on purpose. I believe it's more natural this way but if you wish it changed, there is no problem.
2013/9/2 su_v <suv-sf@...58...>
On 2013-08-24 23:40 +0200, Jan Darowski wrote:
This week I added loading procedural templates into my widget so they could be listed next to the static templates. This required some changes in the current NewFromTemplate code but it's functionality remains unchanged.
A couple of issues I noticed with trunk builds after the commit of the first part ("NewFromTemplate GSoC project for static templates") http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12476 as well as with an up-to-date build of your branch (r12482) https://code.launchpad.net/~slagvi/inkscape/templates:
- UI regression
It is no longer possible to open multiple new documents from within the same inkscape process:
Previous behavior: 'Ctrl+N', or selecting a template from the menu 'File > New' always opens a new document in a new document window
Current behavior (>= r12476): 'Ctrl+N', or selecting a specific template in the new dialog re-uses the current document window unless it has an existing document loaded, or the current new document has been dirtied.
- GUI regression (minor)
After opening a new document (Ctrl+N, or selecting a template in the new dialog), the mouse cursor for canvas stays 'busy' in the original window (or - if it was new and not yet dirtied - in the current resued document window) until a tool switch triggers a new cursor symbol to be used. The cursor symbol is misleading, since the main process is not blocked (inkscape is not actually 'busy'). Does not happen with older builds (< r12476) or stable.
- GUI usability (keyboard)
The new dialog currently forces the use of the mouse, even to trigger a button (or presumed default action). It would be great if the new dialog also supported features like
- double-click on list item creates new document based on template (see
for example the dialog to select path effects) 2) basic keyboard-based navigation (like in all other parts of the GUI) Currently, activation of a focused GUI widget with <Space> or <Return> does not work for both buttons in the new dialog: the buttons are visually pressed, but nothing else happens (no action triggered).
- Backwards compatibility (template names)
All templates whose file names start with 'default' are now ommitted from the list.
This affects a couple of shared templates: Variations of the basic default document with A4 page size, using different base units (mm, pt) are no longer included in the list of available templates:
default_mm.svg
default_pt.svg
as well as user templates:
Many of my custom user templates for example had been created based on a simple naming scheme: basename of original file ("default") with a short string appended describing the major difference:
- default-400x400.svg
- default-dark.svg
- default-isometry-1.svg
- ...
These custom templates are no longer shown in the list of available templates with current trunk builds.
AFAIU the naming scheme for translated templates uses a '.' as separator ('default.xy.svg') - thus none of the mentioned missing templates could (or should) be mistaken as translated versions of the 'default.svg' template.
Please let me know if you would prefer that these issues get reported in the bug tracker (instead of mentioning them here on the mailing list).
(All items have been tested and reproduced with current trunk on Ubuntu 12.04 (PPA), 12.10 (local build), 13.04 (PPA) and on OS X 10.7.5)
It is not up to me to decide how to implement NewFromTemplate in detail - this one change in behavior of 'Ctrl+N' simply struck me as odd quite early on while testing trunk with the new templates dialog. Why would Inkscape suddenly prevent me from opening multiple new documents in one go? It felt like an unintentional change to me.
What do others think about this?
On 2013-09-02 15:36 +0200, Jan Darowski wrote:
I will fix these things so there is no need to report them in the bug tracker. To be honest, behavior described by you as the first problem (UI regression) is done like that on purpose. I believe it's more natural this way but if you wish it changed, there is no problem.
2013/9/2 su_v <...>
On 2013-08-24 23:40 +0200, Jan Darowski wrote: > This week I added loading procedural templates into my widget so they > could be listed next to the static templates. This required some changes > in the current NewFromTemplate code but it's functionality remains > unchanged. A couple of issues I noticed with trunk builds after the commit of the first part ("NewFromTemplate GSoC project for static templates") <http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12476 <http://bazaar.launchpad.net/%7Einkscape.dev/inkscape/trunk/revision/12476>> as well as with an up-to-date build of your branch (r12482) <https://code.launchpad.net/~slagvi/inkscape/templates <https://code.launchpad.net/%7Eslagvi/inkscape/templates>>: - UI regression It is no longer possible to open multiple new documents from within the same inkscape process: Previous behavior: 'Ctrl+N', or selecting a template from the menu 'File > New' always opens a new document in a new document window Current behavior (>= r12476): 'Ctrl+N', or selecting a specific template in the new dialog re-uses the current document window unless it has an existing document loaded, or the current new document has been dirtied.
<...>
On 2-9-2013 16:33, su_v wrote:
It is not up to me to decide how to implement NewFromTemplate in detail
- this one change in behavior of 'Ctrl+N' simply struck me as odd quite
early on while testing trunk with the new templates dialog. Why would Inkscape suddenly prevent me from opening multiple new documents in one go? It felt like an unintentional change to me.
What do others think about this?
Perhaps when trying some new templates, you can kind-off cycle through them that way, without opening a ton of new windows... Just brainstorming here..
-Johan
On 2013-09-02 18:02 +0200, Johan Engelen wrote:
On 2-9-2013 16:33, su_v wrote:
On 2013-09-02 15:36 +0200, Jan Darowski wrote:
I will fix these things so there is no need to report them in the bug tracker. To be honest, behavior described by you as the first problem (UI regression) is done like that on purpose. I believe it's more natural this way but if you wish it changed, there is no problem.
It is not up to me to decide how to implement NewFromTemplate in detail
- this one change in behavior of 'Ctrl+N' simply struck me as odd quite
early on while testing trunk with the new templates dialog. Why would Inkscape suddenly prevent me from opening multiple new documents in one go? It felt like an unintentional change to me.
What do others think about this?
Perhaps when trying some new templates, you can kind-off cycle through them that way, without opening a ton of new windows... Just brainstorming here..
Initial situation: 1) an odd habit of opening one (or even two) additional new documents from within inkscape right after launching it by itself 2) delayed opening of document windows in current trunk (fonts!) 3) a misleading 'busy' cursor 4) an unexpected change in behavior with only a minimal indicator in Inkscape's GUI (the document count in the window title bar)
Picture me spending a couple of minutes trying to figure what is actually going on, after having noticed that Inkscape apparently hangs (without crash) indefinitely when opening a second new document just after launching: no second document window opens, and the cursor in the canvas area of the first window stays busy. I have grown used to the fact that the second window takes a while to open (on my system trunk now is noticeably slower than stable), so initially I'm taking the 'busy' cursor literally (as indicator of inkscape doing its longish font list magic for the second window), and continue working on other things while waiting for the second window to finally open. But it never does. After figuring out that Inkscape actually doesn't hang (the cursor errs) the remaining question was about the still missing second window (there is no external monitor attached, and the window did not open behind any front window(s) nor on a different desktop/workspace either). After a few more attempts I finally realized that the document count in the window title bar increased by one each time I tried again typing 'Ctrl+N', or clicking on the 'New document' icon. At that point I was inclined to view the change in behavior as 'regression'.
My personal use cases are not representative (I'm spending way more time with testing than with actually working on personal projects), but I was and still am puzzled; trying to figure out what Inkscape wants to teach me here about workflow: "Don't multitask; always focus on one new document at a time."? ;-)
tl;dr
I wasn't "trying some new templates", I actually wanted to open a second new document (in its own window) just after launching inkscape.
On 2-9-2013 23:32, su_v wrote:
On 2013-09-02 18:02 +0200, Johan Engelen wrote:
On 2-9-2013 16:33, su_v wrote:
On 2013-09-02 15:36 +0200, Jan Darowski wrote:
I will fix these things so there is no need to report them in the bug tracker. To be honest, behavior described by you as the first problem (UI regression) is done like that on purpose. I believe it's more natural this way but if you wish it changed, there is no problem.
It is not up to me to decide how to implement NewFromTemplate in detail
- this one change in behavior of 'Ctrl+N' simply struck me as odd quite
early on while testing trunk with the new templates dialog. Why would Inkscape suddenly prevent me from opening multiple new documents in one go? It felt like an unintentional change to me.
What do others think about this?
Perhaps when trying some new templates, you can kind-off cycle through them that way, without opening a ton of new windows... Just brainstorming here..
tl;dr
I wasn't "trying some new templates", I actually wanted to open a second new document (in its own window) just after launching inkscape.
Heh, I'd change it back to the old behavior too :-)
Cheers, Johan
Everything is fixed back. Only keyboard navigation left but i think I will manage to do this before the time.
2013/9/3 Johan Engelen <jbc.engelen@...2592...>
On 2-9-2013 23:32, su_v wrote:
On 2013-09-02 18:02 +0200, Johan Engelen wrote:
On 2-9-2013 16:33, su_v wrote:
On 2013-09-02 15:36 +0200, Jan Darowski wrote:
I will fix these things so there is no need to report them in the bug tracker. To be honest, behavior described by you as the first problem (UI regression) is done like that on purpose. I believe it's more natural this way but if you wish it changed, there is no problem.
It is not up to me to decide how to implement NewFromTemplate in detail
- this one change in behavior of 'Ctrl+N' simply struck me as odd quite
early on while testing trunk with the new templates dialog. Why would Inkscape suddenly prevent me from opening multiple new documents in one go? It felt like an unintentional change to me.
What do others think about this?
Perhaps when trying some new templates, you can kind-off cycle through them that way, without opening a ton of new windows... Just brainstorming here..
tl;dr
I wasn't "trying some new templates", I actually wanted to open a second new document (in its own window) just after launching inkscape.
Heh, I'd change it back to the old behavior too :-)
Cheers, Johan
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clk... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (3)
-
Jan Darowski -
Johan Engelen -
su_v