I noticed that, while all of the other 0..1 ranges have been changed to 0..100%, the Layers Dialog opacity has not. I have the code to make this change almost ready, but I wanted to ask two things before I committed anything:
1. Since it's close to a release, should I hold off on this change? 2. The Fill & Stroke dialog for Opacity and Blur places the percent signs outside of the SpinButtons, in the labels. Should the Layer Opacity be the same (the label now becoming "Opacity %:") or should it be like the Zoom control (% in the SpinButton itself)?
Thanks,
John
On Thu, Dec 21, 2006 at 04:38:15PM -0500, John Bintz wrote:
I noticed that, while all of the other 0..1 ranges have been changed to 0..100%, the Layers Dialog opacity has not. I have the code to make this change almost ready, but I wanted to ask two things before I committed anything:
- Since it's close to a release, should I hold off on this change?
It's fine; it sounds like sort of a bug, so it fits in with the current phase.
- The Fill & Stroke dialog for Opacity and Blur places the percent
signs outside of the SpinButtons, in the labels. Should the Layer Opacity be the same (the label now becoming "Opacity %:") or should it be like the Zoom control (% in the SpinButton itself)?
Hmm, well it probably should be made consistent one way or the other. Having it in the spin button itself probably makes the most sense, but I don't know if others have strong preference one way or the other.
Bryce
On 12/21/06, John Bintz <jcoswell@...1414...> wrote:
- Since it's close to a release, should I hold off on this change?
I think it's a safe enough change
- The Fill & Stroke dialog for Opacity and Blur places the percent
signs outside of the SpinButtons, in the labels. Should the Layer Opacity be the same (the label now becoming "Opacity %:") or should it be like the Zoom control (% in the SpinButton itself)?
For consistency, place it in the label. It's also much simpler because it allows you to use the spinbutton unmodified. Appending the % to the editable text requires a lot of extra hassle and (IMHO) makes editing more difficult. With zoom, it's ok because it's rarely edited at all.
participants (3)
-
Bryce Harrington -
bulia byak -
John Bintz