Review: C++ for Inkscape Core
Dear Developers,
I've been asked to review a large patch by Liam which is an attempt to C ++ify the core of inkscape, removing inkscape-private.h and making objects.
I'm going through the code as requested, but I feel this patch will need more than me to give it the OK. Can I request some of the bright peers working on C++ification to give the patch their blessings too?
Merge Request: https://code.launchpad.net/~inkscapebrony/inkscape/inkscape-cppify/+merge/22...
Best Regards, Martin Owens
On 27-6-2014 0:48, Martin Owens wrote:
Dear Developers,
I've been asked to review a large patch by Liam which is an attempt to C ++ify the core of inkscape, removing inkscape-private.h and making objects.
I'm going through the code as requested, but I feel this patch will need more than me to give it the OK. Can I request some of the bright peers working on C++ification to give the patch their blessings too?
Merge Request: https://code.launchpad.net/~inkscapebrony/inkscape/inkscape-cppify/+merge/22...
Already on it, and give Liam some feedback.
There are some weird things going on in the current code that may need to be fixed/clarified later. Overall, I think it is good work and in the right direction. No need to apply it to trunk before release though.
cheers, Johan
On Thu, Jun 26, 2014, at 04:22 PM, Johan Engelen wrote:
There are some weird things going on in the current code that may need to be fixed/clarified later.
Yes! There is definitely a lot of cruft and 'legacy' in there that needs to be addressed. Once we have the release put to bed it probably is a good idea to get together anyone interested in this aspect and give things a good once-over.
Remember... when we started out the codebase had to support Windows 95 and the associated compilers. Not to mention some of the ancient gcc versions we were supporting then.
participants (3)
-
Johan Engelen -
Jon A. Cruz -
Martin Owens