On 27-6-2014 0:48, Martin Owens wrote:
Dear Developers,
I've been asked to review a large patch by Liam which is an attempt to C ++ify the core of inkscape, removing inkscape-private.h and making objects.
I'm going through the code as requested, but I feel this patch will need more than me to give it the OK. Can I request some of the bright peers working on C++ification to give the patch their blessings too?
Merge Request: https://code.launchpad.net/~inkscapebrony/inkscape/inkscape-cppify/+merge/22...
Already on it, and give Liam some feedback.
There are some weird things going on in the current code that may need to be fixed/clarified later. Overall, I think it is good work and in the right direction. No need to apply it to trunk before release though.
cheers, Johan