three patches regarding batch export, layer selection and xml-editor
Hi List,
I've been a happy user of Inkscape, and now I needed some tweaks. I attach the patches against the current svn head, and brief description for them:
(1) mutual_hide_on_png_export.patch
This adds a new checkbox to the Export dialog if multiple selection is present. Ticking it hides not only non-selected items, but also other selected items on export, therefore the different items don't iterfere with each other.
(2) xml_editor_jump_to_element_on_layer_select.patch
If a layer is selected in the Layers dialog, the XML editor jumps to the appropriate svg:g element.
(3) add_layer_to_selection.patch
This is kind of work-in-progress. A new two-state column is added to the Layers dialog, which shows if the layer is selected or not, and also on clicking the row icon can add/remove the layer to/from the selection. I mainly use this for sub-layer selection and moving. Possible improvements: - currently the show/hide eye icon is copied - right-align the column (how is this possible in gtk?) - if multiple layers are selected, trying to grab and move them by clicking on an item inside one of the selected layers moves only that layer. Hack: create a dummy layer with a "control" rectangle, select the control-rect, add the layers to the selection using the new icons, and then grab the control rect and move them all.
I hope you find the patches useful and even improve them if required.
BR, Robin
I found a bug in the patch (1) which doesn't always dealloc the GList created (too strict boolean condition). The updated patch is attached.
BR, Robin
2010.10.08. 23:39 keltezéssel, Robin Palotai írta:
Hi List,
I've been a happy user of Inkscape, and now I needed some tweaks. I attach the patches against the current svn head, and brief description for them:
(1) mutual_hide_on_png_export.patch
This adds a new checkbox to the Export dialog if multiple selection is present. Ticking it hides not only non-selected items, but also other selected items on export, therefore the different items don't iterfere with each other.
(2) xml_editor_jump_to_element_on_layer_select.patch
If a layer is selected in the Layers dialog, the XML editor jumps to the appropriate svg:g element.
(3) add_layer_to_selection.patch
This is kind of work-in-progress. A new two-state column is added to the Layers dialog, which shows if the layer is selected or not, and also on clicking the row icon can add/remove the layer to/from the selection. I mainly use this for sub-layer selection and moving. Possible improvements:
- currently the show/hide eye icon is copied
- right-align the column (how is this possible in gtk?)
- if multiple layers are selected, trying to grab and move them by
clicking on an item inside one of the selected layers moves only that layer. Hack: create a dummy layer with a "control" rectangle, select the control-rect, add the layers to the selection using the new icons, and then grab the control rect and move them all.
I hope you find the patches useful and even improve them if required.
BR, Robin
On Oct 9, 2010, at 10:39 AM, Robin Palotai wrote:
I found a bug in the patch (1) which doesn't always dealloc the GList created (too strict boolean condition). The updated patch is attached.
Thanks. I'll take a look at them.
In general it is handy to attach patches to a pertinent Inkscape bug in launchpad[1], creating one if necessary. That's also a handy way to update individual ones with new patches.
But the main thing I wanted to mention was a question I had about source. You mention basing them on the current svn head, but we switched to Bazaar[2] a while back. Did you just misspeak about the source, or are these based on our older tree? (We do have some notes on getting started with it [3])
Thanks again for the work.
[1] https://bugs.launchpad.net/inkscape [2] https://code.launchpad.net/inkscape [3] http://wiki.inkscape.org/wiki/index.php/Working_with_Bazaar
On 9/10/10 19:39, Robin Palotai wrote:
2010.10.08. 23:39 keltezéssel, Robin Palotai írta:
I've been a happy user of Inkscape, and now I needed some tweaks. I attach the patches against the current svn head, and brief description for them:
I found a bug in the patch (1) which doesn't always dealloc the GList created (too strict boolean condition). The updated patch is attached.
(...)
Index: src/dialogs/export.cpp
--- src/dialogs/export.cpp (revision 22775) +++ src/dialogs/export.cpp (working copy)
Please note that Inkscape moved the source code repository from SVN at sf.net to BZR at launchpad.net right after the release of 0.47 in December 2009. The SVN repository hasn't been updated since then.
I haven't tested if the patches would apply to current trunk head without changes. Providing patches against current development branch might help ...
See http://inkscape.org/bzr.php?lang=en and http://wiki.inkscape.org/wiki/index.php/Working_with_Bazaar for more details.
hth, ~suv
Oh, I see. I missed this then. I clicked Developers/Documentation on the site which had a "working with SVN" section, that's why I used it. Maybe a note could be dropped there :) I'll try to have some time this week to check the bzr repository, will check back once done.
BR, Robin
2010.10.09. 20:40 keltezéssel, ~suv írta:
On 9/10/10 19:39, Robin Palotai wrote:
2010.10.08. 23:39 keltezéssel, Robin Palotai írta:
I've been a happy user of Inkscape, and now I needed some tweaks. I attach the patches against the current svn head, and brief description for them:
I found a bug in the patch (1) which doesn't always dealloc the GList created (too strict boolean condition). The updated patch is attached.
(...)
Index: src/dialogs/export.cpp
--- src/dialogs/export.cpp (revision 22775) +++ src/dialogs/export.cpp (working copy)
Please note that Inkscape moved the source code repository from SVN at sf.net to BZR at launchpad.net right after the release of 0.47 in December 2009. The SVN repository hasn't been updated since then.
I haven't tested if the patches would apply to current trunk head without changes. Providing patches against current development branch might help ...
Seehttp://inkscape.org/bzr.php?lang=en and http://wiki.inkscape.org/wiki/index.php/Working_with_Bazaar for more details.
hth, ~suv
participants (3)
-
Jon Cruz
-
Robin Palotai
-
~suv