0.45 Release - Patches to include
There are a lot of patches in the patch tracker right now. Some have been in there quite a long time. We really ought to try to include or resolve as many of these for 0.45 as we can. And we should include them now rather than later, to ensure there's plenty of time to test them and work out any bugs.
Please take a look through these and indicate if you have concerns for any of them that should be addressed before we include them. I've indicated below which seem ready for inclusion and which need further testing or work first. I think it'd be a good goal to reduce the number of open patches to less than half a dozen, for the 0.45 release.
1567964 "Unknown error for pclose" when using effects fintatartaruga Assigned to: acspike Simple bugfix. Looks fine to me, although I'm curious why it is checking the return code to be >= 0 rather than == 0.
1539297 Export of clip-paths to Ps/Pdf ulferikson Assigned to: bulia It sounds like this one is probably good to go; Ulf is asking if someone could review it beforehand, so bulia or mental, if you could take a peek and give a yea or nay, that'd help.
1536990 [STABLE] Pdf fixes ulferikson Assigned to: mental Collection of bug fixes. Sound very much worth including. Mental, do you see any issues with incorporating this one?
1535878 palette converters (.acf and .bcf to .gpl) nitrofurano Assigned to: acspike Sounds like these converters should be wrapped up as extensions and included.
1535875 .ai example tests for import nitrofurano Assigned to: kidproto These tests would be well worth inclusion, although I'm not certain where they would fit into the codebase. Should they be set up to run with make check, or should they be collected into a standalone testsuite? In either case I think this is of moderate importance, so if it waits until post-release that could be okay.
1533789 ill2svg.pl replacement in python nitrofurano Assigned to: bulia Sounds like the python replacement has some problems, so this patch may need to wait until a future release.
1521963 fix for build problems with autoconf 2.60 sk1p Assigned to: bulia Sounds like this needs a bit more work before it can be committed, but would be a good one to get in for this release. Getting Inkscape to be happy with many different versions of autoconf will make life easier for a lot of folks.
1519675 export to pdf via cairo-pdf from miklos theadib Assigned to: miklosh If this isn't applied already, we should get this in ASAP. We're planning to advertise cairo pdf export, so it's very important we make sure all of miklosh's work is incorporated for 0.45.
1517872 OSX: script for building universal dependencies dhimelright Assigned to: mjwybrow I'm not sure if this is still needed for use on OSX, but if so let's get it reviewed and applied.
1511066 Pref to enable or disable extended input. zeimusu Assigned to: kidproto No patch was attached; we'll be closing it unless a patch gets attached.
1495826 pstoedit and svg with latex render extension dniepper Fixes a compatibility issue with pstoedit; probably fine to include.
1493939 Easter Egg Tutorial skarg Assigned to: scislac The author was asked to convert it to docbook format, but we haven't heard back from him. Still, I think it would be worthwhile to include, so if someone has a chance, please work on converting this to the proper format for inclusion. Even if that can't be done, it'd be nice to have this included in the share directory or something.
1483543 inkview mouse navigation mimooh Assigned to: kidproto This one is an incomplete functionality; the submitter was having trouble figuring out how to get mouse events to be seen by SPView. I don't think this patch is ready for incorporation, but someone with gtk / SPView knowledge should share a few tips to the author, as this could be a very handy feature for inkview users in the future.
1475143 EMF input/output (Windows only) ulferikson Assigned to: bryce Even though this is windows-only, I think it'd be fine to incorporate this, as long as it can be made to compile properly on Linux. EMF is mainly of interest to Windows users anyway.
1466048 Inkscape Buttons johncoswell Assigned to: bryce These are buttons for the website. Rejon or I can take care of adding them to the site.
1463483 Inkscape icons for SVG files boldewyn The icons are fine and probably can be accepted. Packagers will need to look into getting these installed for the respective filetypes, but that's a separate issue from this patch.
1387386 add Tru64/osf1 isNaN/isFinite definitions enchanter Sounds similar to the IRIX patch
1382904 Small patch for mkfiles.pl atwupack Applied by rejon. Thanks!
1379041 patch for SGI IRIX build Simple 3-line patch; I don't know if anyone has access to an IRIX system, but if this makes Inkscape compileable there, it's worth getting applied. It's almost a year old so we really ought to either include it or close it.
1219308 [EPS export] Unicode print - type 1 font embedding Looks good to me if we don't already have this functionality. The patch is over a year old and needs resolution.
Bryce
On 10/22/06, Bryce Harrington <bryce@...961...> > 1539297 Export of clip-paths to Ps/Pdf ulferikson
Assigned to: bulia It sounds like this one is probably good to go; Ulf is asking if someone could review it beforehand, so bulia or mental, if you could take a peek and give a yea or nay, that'd help.
1536990 [STABLE] Pdf fixes ulferikson Assigned to: mental Collection of bug fixes. Sound very much worth including. Mental, do you see any issues with incorporating this one?
I had an impression that these are already in SVN and were submitted as patches only for 0.44.1. Am I wrong?
1535875 .ai example tests for import nitrofurano Assigned to: kidproto These tests would be well worth inclusion, although I'm not certain where they would fit into the codebase. Should they be set up to run with make check, or should they be collected into a standalone testsuite? In either case I think this is of moderate importance, so if it waits until post-release that could be okay.
1533789 ill2svg.pl replacement in python nitrofurano Assigned to: bulia Sounds like the python replacement has some problems, so this patch may need to wait until a future release.
Even if we don't hear back from the author, I would like to ask someone proficient in Python to have a look at the problems found. They are probably not difficult to fix. This patch has the great advantage that AI import will (at least somehow) work via Python without Perl, which means Windows (we carry Python with us but not Perl).
On 2006-October-22 , at 22:44 , bulia byak wrote: [...]
1533789 ill2svg.pl replacement in python nitrofurano Assigned to: bulia Sounds like the python replacement has some problems, so this patch may need to wait until a future release.
Even if we don't hear back from the author, I would like to ask someone proficient in Python to have a look at the problems found. They are probably not difficult to fix. This patch has the great advantage that AI import will (at least somehow) work via Python without Perl, which means Windows (we carry Python with us but not Perl).
... and OS X where perl extensions do not work either (because of a problem in detecting OS X existing perl installation).
JiHO --- http://jo.irisson.free.fr/
On Sun, 2006-10-22 at 17:44 -0300, bulia byak wrote:
On 10/22/06, Bryce Harrington <bryce@...961...> > 1539297 Export of clip-paths to Ps/Pdf ulferikson
Assigned to: bulia It sounds like this one is probably good to go; Ulf is asking if someone could review it beforehand, so bulia or mental, if you could take a peek and give a yea or nay, that'd help.
1536990 [STABLE] Pdf fixes ulferikson Assigned to: mental Collection of bug fixes. Sound very much worth including. Mental, do you see any issues with incorporating this one?
I had an impression that these are already in SVN and were submitted as patches only for 0.44.1. Am I wrong?
Yes, I have gone through and closed, committed or commented all that exist.
1535875 .ai example tests for import nitrofurano Assigned to: kidproto These tests would be well worth inclusion, although I'm not certain where they would fit into the codebase. Should they be set up to run with make check, or should they be collected into a standalone testsuite? In either case I think this is of moderate importance, so if it waits until post-release that could be okay.
1533789 ill2svg.pl replacement in python nitrofurano Assigned to: bulia Sounds like the python replacement has some problems, so this patch may need to wait until a future release.
Even if we don't hear back from the author, I would like to ask someone proficient in Python to have a look at the problems found. They are probably not difficult to fix. This patch has the great advantage that AI import will (at least somehow) work via Python without Perl, which means Windows (we carry Python with us but not Perl).
This is good to know...please comment on :)
Jon
On Sun, 2006-10-22 at 13:34 -0700, Bryce Harrington wrote:
There are a lot of patches in the patch tracker right now. Some have been in there quite a long time. We really ought to try to include or resolve as many of these for 0.45 as we can. And we should include them now rather than later, to ensure there's plenty of time to test them and work out any bugs.
Please take a look through these and indicate if you have concerns for any of them that should be addressed before we include them. I've indicated below which seem ready for inclusion and which need further testing or work first. I think it'd be a good goal to reduce the number of open patches to less than half a dozen, for the 0.45 release.
1567964 "Unknown error for pclose" when using effects fintatartaruga Assigned to: acspike Simple bugfix. Looks fine to me, although I'm curious why it is checking the return code to be >= 0 rather than == 0.
1539297 Export of clip-paths to Ps/Pdf ulferikson Assigned to: bulia It sounds like this one is probably good to go; Ulf is asking if someone could review it beforehand, so bulia or mental, if you could take a peek and give a yea or nay, that'd help.
1536990 [STABLE] Pdf fixes ulferikson Assigned to: mental Collection of bug fixes. Sound very much worth including. Mental, do you see any issues with incorporating this one?
1535878 palette converters (.acf and .bcf to .gpl) nitrofurano Assigned to: acspike Sounds like these converters should be wrapped up as extensions and included.
1535875 .ai example tests for import nitrofurano Assigned to: kidproto These tests would be well worth inclusion, although I'm not certain where they would fit into the codebase. Should they be set up to run with make check, or should they be collected into a standalone testsuite? In either case I think this is of moderate importance, so if it waits until post-release that could be okay.
I put these into our svn module inkscape_testfiles and closed it.
1533789 ill2svg.pl replacement in python nitrofurano Assigned to: bulia Sounds like the python replacement has some problems, so this patch may need to wait until a future release.
1521963 fix for build problems with autoconf 2.60 sk1p Assigned to: bulia Sounds like this needs a bit more work before it can be committed, but would be a good one to get in for this release. Getting Inkscape to be happy with many different versions of autoconf will make life easier for a lot of folks.
1519675 export to pdf via cairo-pdf from miklos theadib Assigned to: miklosh If this isn't applied already, we should get this in ASAP. We're planning to advertise cairo pdf export, so it's very important we make sure all of miklosh's work is incorporated for 0.45.
1517872 OSX: script for building universal dependencies dhimelright Assigned to: mjwybrow I'm not sure if this is still needed for use on OSX, but if so let's get it reviewed and applied.
1511066 Pref to enable or disable extended input. zeimusu Assigned to: kidproto No patch was attached; we'll be closing it unless a patch gets attached.
1495826 pstoedit and svg with latex render extension dniepper Fixes a compatibility issue with pstoedit; probably fine to include.
I added notes to this one. It appears to conflict with changes to layers after he committed.
1493939 Easter Egg Tutorial skarg Assigned to: scislac The author was asked to convert it to docbook format, but we haven't heard back from him. Still, I think it would be worthwhile to include, so if someone has a chance, please work on converting this to the proper format for inclusion. Even if that can't be done, it'd be nice to have this included in the share directory or something.
Should I just commit this one and then hopefully visibility will drive its cleanup/conversion.
1483543 inkview mouse navigation mimooh Assigned to: kidproto This one is an incomplete functionality; the submitter was having trouble figuring out how to get mouse events to be seen by SPView. I don't think this patch is ready for incorporation, but someone with gtk / SPView knowledge should share a few tips to the author, as this could be a very handy feature for inkview users in the future.
The author abadoned this patch, so I closed it.
1475143 EMF input/output (Windows only) ulferikson Assigned to: bryce Even though this is windows-only, I think it'd be fine to incorporate this, as long as it can be made to compile properly on Linux. EMF is mainly of interest to Windows users anyway.
1466048 Inkscape Buttons johncoswell Assigned to: bryce These are buttons for the website. Rejon or I can take care of adding them to the site.
I added them to the inkscape_marketing module in the web folder. Would someone like to add these to our website so everyone can advertise their usage of Inkscape?
1463483 Inkscape icons for SVG files boldewyn The icons are fine and probably can be accepted. Packagers will need to look into getting these installed for the respective filetypes, but that's a separate issue from this patch.
I added to the share/icons folder in the main inkscape svn repository and followed up with the author about filing an RFE about how to include in distros, etc.
1387386 add Tru64/osf1 isNaN/isFinite definitions enchanter Sounds similar to the IRIX patch
committed and closed
1382904 Small patch for mkfiles.pl atwupack Applied by rejon. Thanks!
committed and closed
1379041 patch for SGI IRIX build Simple 3-line patch; I don't know if anyone has access to an IRIX system, but if this makes Inkscape compileable there, it's worth getting applied. It's almost a year old so we really ought to either include it or close it.
committed and closed
1219308 [EPS export] Unicode print - type 1 font embedding Looks good to me if we don't already have this functionality. The patch is over a year old and needs resolution.
Bryce
Cool...after other ppl. check stuff out, things will be a lot better off...
Jon
Jon Phillips wrote:
On Sun, 2006-10-22 at 13:34 -0700, Bryce Harrington wrote:
1495826 pstoedit and svg with latex render extension dniepper Fixes a compatibility issue with pstoedit; probably fine to include.
I added notes to this one. It appears to conflict with changes to layers after he committed.
Not sure whether this conflicts with the the layers changes, but it has a more sensible method for importing the SVG output of plotutils/pstoedit. Sorry it's not in the tracker, I haven't had a chance to submit it.
Cheers, Marcus
On Sun, 2006-10-22 at 23:38 -0400, Marcus Brubaker wrote:
Jon Phillips wrote:
On Sun, 2006-10-22 at 13:34 -0700, Bryce Harrington wrote:
1495826 pstoedit and svg with latex render extension
dniepper
Fixes a compatibility issue with pstoedit; probably fine to include.
I added notes to this one. It appears to conflict with changes to
layers
after he committed.
Not sure whether this conflicts with the the layers changes, but it has a more sensible method for importing the SVG output of plotutils/pstoedit. Sorry it's not in the tracker, I haven't had a chance to submit it.
Cheers, Marcus
Cool...I applied your patch and added you to the AUTHORS file. If you submit one more patch that we accept, you can ask for access to our subversion repository. Thanks for you cool patch! We want more of your great work :)
Jon
Jon Phillips
San Francisco, CA USA PH 510.499.0894 jon@...235... http://www.rejon.org
MSN, AIM, Yahoo Chat: kidproto Jabber Chat: rejon@...896... IRC: rejon@...897...
On Sun, 2006-10-22 at 23:38 -0400, Marcus Brubaker wrote:
Jon Phillips wrote:
On Sun, 2006-10-22 at 13:34 -0700, Bryce Harrington wrote:
1495826 pstoedit and svg with latex render extension dniepper Fixes a compatibility issue with pstoedit; probably fine to include.
I added notes to this one. It appears to conflict with changes to layers after he committed.
Not sure whether this conflicts with the the layers changes, but it has a more sensible method for importing the SVG output of plotutils/pstoedit. Sorry it's not in the tracker, I haven't had a chance to submit it.
Cheers, Marcus
plot-svg is not available as an option in Fedora's pstoedit (it does seem to be available with Debian, at least it is listed on the Debian pstoedit man page). Since Inkscape already requires skencil for PS and EPS import, wouldn't it be better to use the chain pstoedit -> skencil -> svg? A patch is attached.
Tav
On 2006-October-23 , at 12:59 , Tavmjong Bah wrote:
On Sun, 2006-10-22 at 23:38 -0400, Marcus Brubaker wrote:
Jon Phillips wrote:
On Sun, 2006-10-22 at 13:34 -0700, Bryce Harrington wrote:
1495826 pstoedit and svg with latex render extension dniepper Fixes a compatibility issue with pstoedit; probably fine to include.
I added notes to this one. It appears to conflict with changes to layers after he committed.
Not sure whether this conflicts with the the layers changes, but it has a more sensible method for importing the SVG output of plotutils/pstoedit. Sorry it's not in the tracker, I haven't had a chance to submit it.
Cheers, Marcus
plot-svg is not available as an option in Fedora's pstoedit (it does seem to be available with Debian, at least it is listed on the Debian pstoedit man page). Since Inkscape already requires skencil for PS and EPS import, wouldn't it be better to use the chain pstoedit -> skencil -> svg? A patch is attached.
plot-svg is available in my Fedora install: plot-svg: .svg: svg via GNU libplot (/ usr/lib64/pstoedit/libp2edrvlplot.so) It is FC 5 with nothing special. Apparently GNU lipplot is in package plotutils. Do you have this package installed? I would be in favor or dropping skencil and using pstoedit only (for PS and EPS too) because pstoedit + plotutils is a smaller and easier to install dependency than pstoedit+skencil. I modifed PS and EPS extensions accordingly a while ago but didn't post the patch before because it was said that there should be a check for the availability of plot-svg in it. It is currently possible to check for the availability of an executable with current extension syntax. Could it be made to work with a library? The other solution would be to wrap the call to pstoedit in a shell script that check for the availability of plot-svg and returns an error at run time. But won't write anything in extensions-errors.log. Here is a suggestion for such a script, I just don't know how to return an error message from an extension...
#!/bin/sh # # Checks for the availability of plot-svg in pstoedit and converts ps to svg this way #
plotsvg=`pstoedit 2>/dev/null -help | grep plot-svg` rc=0
if [[ "$plotsvg" = "" ]] then # How to return an error message? #echo "Plot-svg format not available in pstoedit. Please install package plotutils" rc=1 else TMPDIR="${TMPDIR-/tmp}" TEMPFILENAME=`mktemp 2>/dev/null || echo "$TMPDIR/tmp-ps-$$.ps"` pstoedit -f plot-svg "$1" "${TEMPFILENAME}" > /dev/null 2>&1 cat < "${TEMPFILENAME}" || rc=1 rm -f "${TEMPFILENAME}" fi
exit $rc
and ps_input.inx should be modified accordingly: <inkscape-extension> <_name>Postscript Input</_name> <id>org.inkscape.input.ps</id> <dependency type="executable">pstoedit</dependency> <input> <extension>.ps</extension> <mimetype>image/x-postscript</mimetype> <_filetypename>Postscript (*.ps)</_filetypename> <_filetypetooltip>Postscript</_filetypetooltip> <output_extension>org.inkscape.output.ps</output_extension> </input> <script> <command reldir="path">ps2svg.sh</command> </script> </inkscape-extension>
what do people think?
JiHO --- http://jo.irisson.free.fr/
Tavmjong Bah wrote:
On Sun, 2006-10-22 at 23:38 -0400, Marcus Brubaker wrote:
Jon Phillips wrote:
On Sun, 2006-10-22 at 13:34 -0700, Bryce Harrington wrote:
1495826 pstoedit and svg with latex render extension dniepper Fixes a compatibility issue with pstoedit; probably fine to include.
I added notes to this one. It appears to conflict with changes to layers after he committed.
Not sure whether this conflicts with the the layers changes, but it has a more sensible method for importing the SVG output of plotutils/pstoedit. Sorry it's not in the tracker, I haven't had a chance to submit it.
Cheers, Marcus
plot-svg is not available as an option in Fedora's pstoedit (it does seem to be available with Debian, at least it is listed on the Debian pstoedit man page). Since Inkscape already requires skencil for PS and EPS import, wouldn't it be better to use the chain pstoedit -> skencil -> svg? A patch is attached.
Actually, it is available now in Fedora Extras, it was added ~2 months ago. See http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196510
Cheers, Marcus
On Mon, 2006-10-23 at 11:19 -0400, Marcus Brubaker wrote:
Actually, it is available now in Fedora Extras, it was added ~2 months ago. See http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196510
I stand corrected. I was using a self-compiled pstoedit from six months ago which did not take advantage of plotutils.
Tav
<topPost />
This all sounds good, but would prefer you guys to move this code over to the patch tracker as its hard to track what is up.
Please let me/us know what the resolution is and I'll commit once it looks good.
Jon
On Mon, 2006-10-23 at 14:49 +0200, jiho wrote:
On 2006-October-23 , at 12:59 , Tavmjong Bah wrote:
On Sun, 2006-10-22 at 23:38 -0400, Marcus Brubaker wrote:
Jon Phillips wrote:
On Sun, 2006-10-22 at 13:34 -0700, Bryce Harrington wrote:
1495826 pstoedit and svg with latex render extension dniepper Fixes a compatibility issue with pstoedit; probably fine to include.
I added notes to this one. It appears to conflict with changes to layers after he committed.
Not sure whether this conflicts with the the layers changes, but it has a more sensible method for importing the SVG output of plotutils/pstoedit. Sorry it's not in the tracker, I haven't had a chance to submit it.
Cheers, Marcus
plot-svg is not available as an option in Fedora's pstoedit (it does seem to be available with Debian, at least it is listed on the Debian pstoedit man page). Since Inkscape already requires skencil for PS and EPS import, wouldn't it be better to use the chain pstoedit -> skencil -> svg? A patch is attached.
plot-svg is available in my Fedora install: plot-svg: .svg: svg via GNU libplot (/ usr/lib64/pstoedit/libp2edrvlplot.so) It is FC 5 with nothing special. Apparently GNU lipplot is in package plotutils. Do you have this package installed? I would be in favor or dropping skencil and using pstoedit only (for PS and EPS too) because pstoedit + plotutils is a smaller and easier to install dependency than pstoedit+skencil. I modifed PS and EPS extensions accordingly a while ago but didn't post the patch before because it was said that there should be a check for the availability of plot-svg in it. It is currently possible to check for the availability of an executable with current extension syntax. Could it be made to work with a library? The other solution would be to wrap the call to pstoedit in a shell script that check for the availability of plot-svg and returns an error at run time. But won't write anything in extensions-errors.log. Here is a suggestion for such a script, I just don't know how to return an error message from an extension...
#!/bin/sh # # Checks for the availability of plot-svg in pstoedit and converts ps to svg this way #
plotsvg=`pstoedit 2>/dev/null -help | grep plot-svg` rc=0
if [[ "$plotsvg" = "" ]] then # How to return an error message? #echo "Plot-svg format not available in pstoedit. Please install package plotutils" rc=1 else TMPDIR="${TMPDIR-/tmp}" TEMPFILENAME=`mktemp 2>/dev/null || echo "$TMPDIR/tmp-ps-$$.ps"` pstoedit -f plot-svg "$1" "${TEMPFILENAME}" > /dev/null 2>&1 cat < "${TEMPFILENAME}" || rc=1 rm -f "${TEMPFILENAME}" fi
exit $rc
and ps_input.inx should be modified accordingly:
<inkscape-extension> <_name>Postscript Input</_name> <id>org.inkscape.input.ps</id> <dependency type="executable">pstoedit</dependency> <input> <extension>.ps</extension> <mimetype>image/x-postscript</mimetype> <_filetypename>Postscript (*.ps)</_filetypename> <_filetypetooltip>Postscript</_filetypetooltip> <output_extension>org.inkscape.output.ps</output_extension> </input> <script> <command reldir="path">ps2svg.sh</command> </script> </inkscape-extension>
what do people think?
JiHO
Bryce Harrington schrieb:
There are a lot of patches in the patch tracker right now. Some have been in there quite a long time. We really ought to try to include or resolve as many of these for 0.45 as we can. And we should include them now rather than later, to ensure there's plenty of time to test them and work out any bugs.
...
1519675 export to pdf via cairo-pdf from miklos theadib Assigned to: miklosh If this isn't applied already, we should get this in ASAP. We're planning to advertise cairo pdf export, so it's very important we make sure all of miklosh's work is incorporated for 0.45.
... Miklosh had included some cairo-pdf renderer into the SVN sources because my inkscape from SVN shows some pdf as well as cairo-pdf exporter. So this patch is not longer valid.
Miklosh, should we close this patch as "out of date" ?
Adib. ---
I get the following error message when using the latex render extension:
** (inkscape:32574): CRITICAL **: Last <defs> removed
No SVG is imported into the Inkscape file. This is with FC5 and todays SVN. Opening the SVG file produced by pstoedit (using plot-svg) shows that the equation is rendered correctly (but with the equation shifted from the background rectangle). Any ideas of what is going wrong?
Tav
On 10/24/06, Tavmjong Bah <tavmjong@...8...> wrote:
I get the following error message when using the latex render extension:
** (inkscape:32574): CRITICAL **: Last <defs> removed
I saw this too. This warning was added to the code years ago by Mental:
http://svn.sourceforge.net/viewvc/inkscape/inkscape/trunk/src/sp-root.cpp?r1...
but it started to fire only recently. Mental, do you have an idea of why this became a problem? And is it really a problem - maybe we can just remove the g_warning?
This thing happens when you run any document-changing extension, apparently when the old document is being destroyed (by unparenting everything under root?) to be replaced by the new one created by the extension.
On Tue, 2006-10-24 at 17:01 -0300, bulia byak wrote:
but it started to fire only recently. Mental, do you have an idea of why this became a problem? And is it really a problem - maybe we can just remove the g_warning?
As long as nobody tries to do anything with root->defs until the document has been reconstructed, you're okay, but if anyone tries anything in the interim you're kind of screwed, whether it's crashing or failing to create needed gradient/whatever objects.
For example, try dragging svg:defs away from root to become a child of some other element (thus breaking the root->defs link). [There are some simplistic checks in place to prevent direct accidental deletion of it.] Then draw a shape and try to open the fill and stroke dialog...
FWIW, that commit you linked to didn't change any fundamental behavior in this regard. I just added the warning then because I first noticed the potential for problems when I was working in that area of the code.
In the particular case of tearing down and recreating the document, is it a problem right now? No. Can we offer a strong guarantee that if some order of operations is later changed somewhere in SPObject/SPItem that it will still be okay? No.
There isn't really a simple fix -- our whole handling of svg:defs is fundamentally broken by design, and needs to be systematically rethought. We can certainly remove the warning if it's doing more harm than good, but...
-mental
Hi all,
i'm pretty sure there are a few Mac users running Inkscape. On User-Fr mailing-list, someone has complained he can't set the French translation. Maybe someone having experienced this problem can provide some feedback. The user has already checked the FAQ, but it doesn not seem to solve the problem. Thanks in advance,
Regards, matiphas
On 2006-October-27 , at 22:24 , Géraud Gazal wrote:
i'm pretty sure there are a few Mac users running Inkscape.
I hope there are more than a few ;-)
On User-Fr mailing-list, someone has complained he can't set the French translation. Maybe someone having experienced this problem can provide some feedback. The user has already checked the FAQ, but it doesn not seem to solve the problem.
What version is he/she using? It appears indeed that the release version do not switch to languages other than English even though locale information and localized tutorials are included correctly in the application bundle. The mechanism for switching languages for X11 programs on OS X is the same than for other programs: System Preferences > International and drag the language you want to use to the top of the list. It means that if the rest of his/her system is in French, Inkscape should be in French too. I appears that X11.app handles the language change itself and do not care about what is told by the command "locale" (i.e. locale can output LANG="en_US" but X11 and Inkscape start in French if the language selected in the International Preference Pane is French). International settings are correctly respected in latest SVN trunk but another bug makes Inkscape unusable. It has to be fixed before producing a development package. In the meantime, I'll try to check out the release branch and compile it to test what happens.
Cheers,
JiHO --- http://jo.irisson.free.fr/
participants (9)
-
Adib Taraben
-
Bryce Harrington
-
bulia byak
-
Géraud Gazal
-
jiho
-
Jon Phillips
-
Marcus Brubaker
-
MenTaLguY
-
Tavmjong Bah