On 30-10-2014 16:48, Alex Valavanis wrote:
The xfail stuff was just a hack I made to stop old tests from killing the PPA builds... they are definitely not supposed to fail, so it's a bit of an abuse of the xfail flag and should be fixed before the release. As I understand it, they're mostly failures that appeared with changes in 2geom... I suspect they're very easy to fix for people who are familiar with the code. The relevant bug reports I made are here:
Thanks for the explanation Alex.
Browsing through our history, the matrix writing tests ("translate(1)", "skew...") never passed. There is no code anywhere that would output such strings. So what to do? Change the bug report to a wishlist item, change title to "implement special matrix shorthand output" and remove/comment the tests?
-Johan
Hope it's of some use!
AV
On 30 October 2014 15:05, Johan Engelen <jbc.engelen@...2592...> wrote:
On 21-10-2014 21:06, Johan Engelen wrote:
On 21-10-2014 2:34, Bryce Harrington wrote:
Johan, would you be willing to hammer on getting 'make distcheck' to be passing 100% clean? Last I checked it was pretty close but there's a few warnings and other cleanups of the sort you like to tackle.
OK :)
I was hoping to work on this during some downtime at the mentor summit, but...
It is the first time I ran 'make distcheck', on my Mac, and... it just works? :) I see that the unit tests are set to "expect to fail", so that obviously always passes (I don't know why it is set to xfail).
In short: do I need to do anything here? Or is it already good?
cheers, Johan
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel