I've just merged the first code drop from Nick into SVN; I was hoping to avoid any regressions, but at this point I think it's more important to start merging now since Niko and Nick are starting to touch the same code and I want to avoid too much divergence.
Things that work: - blend modes can now easily be selected for objects, just like blur - background accumulation buffer is enabled as-needed - the filter UI dialog has very very basic filter editing capabilities
Regressions: - Niko's work in r15171 (non-destructive filter update) needs to be re-integrated with the new filter metawidget, which replaces the old blur slider - the blur slider in the filter metawidget needs to be made percentage like the slider it replaced
Todo: - add filter metawidget to layers dialog too, for layers - fix flakiness for "Filter" "blend mode" - flesh out filters dialog, parameter editing/connections, etc.
I think we'll need to work out who wants to work on what with the metawidget at this point, depending on what you guys are each most comfortable spending time doing, and on your respective current states of progress.
-mental
Sun, 24 Jun 2007 15:51:33 -0400 MenTaLguY <mental@...3...> kirjoitti:
Regressions:
- Niko's work in r15171 (non-destructive filter update) needs to be re-integrated with the new filter metawidget, which replaces the
old blur slider
Considering, that now it can be handle blend modes as well as blurs, the need for non-destructive updates is smaller. As there is also a more generic UI in development, I don't know if re-integrating would be worth the effort. (well, filter-chemistry.cpp is a bit hairy and filled with unused code, so that might be a good enough reason)
I think we'll need to work out who wants to work on what with the metawidget at this point, depending on what you guys are each most comfortable spending time doing, and on your respective current states of progress.
As the UI is not what I'm supposed to be working on and Nick seems to be advancing on his project, I think I'll get back working on the hidden parts that make the filters tick.
For a short update, what I'm planning to do next: new filter primitives. feCompose, feMerge, feTurbulence and lighting effects are on my list. (not necessarily in that order or all of them)
On Sun, 2007-06-24 at 23:58 +0300, Niko Kiirala wrote:
Considering, that now it can be handle blend modes as well as blurs, the need for non-destructive updates is smaller.
I wouldn't say that -- there's a significant performance hit from tearing down and recreating the SPFilter for every slider change.
That said, it's not critical, and I'm not asking you to do it yourself unless you want to.
-mental
On 6/24/07, MenTaLguY wrote:
I've just merged the first code drop from Nick into SVN; I was hoping to avoid any regressions, but at this point I think it's more important to start merging now since Niko and Nick are starting to touch the same code and I want to avoid too much divergence.
Things that work:
- blend modes can now easily be selected for objects, just like blur
- background accumulation buffer is enabled as-needed
- the filter UI dialog has very very basic filter editing capabilities
Things that do not work: http://pastebin.ca/587866 :)
This is revision 15182
Alexandre
On Mon, 25 Jun 2007 08:30:54 +0400, "Alexandre Prokoudine" <alexandre.prokoudine@...400...> wrote:
Things that do not work: http://pastebin.ca/587866 :)
This is revision 15182
Try reconfiguring and/or building from a fresh checkout. I did verify that it built correctly (and I tested it) as of r15181.
-mental
Hi,
Is there any remaining work to be done for the filter UI?
Could you outline some steps for testers to follow?
Bryce
On Sun, Jun 24, 2007 at 03:51:33PM -0400, MenTaLguY wrote:
Things that work:
- blend modes can now easily be selected for objects, just like blur
- background accumulation buffer is enabled as-needed
- the filter UI dialog has very very basic filter editing capabilities
Regressions:
- Niko's work in r15171 (non-destructive filter update) needs to be re-integrated with the new filter metawidget, which replaces the old blur slider
- the blur slider in the filter metawidget needs to be made percentage like the slider it replaced
Todo:
- add filter metawidget to layers dialog too, for layers
- fix flakiness for "Filter" "blend mode"
- flesh out filters dialog, parameter editing/connections, etc.
I think we'll need to work out who wants to work on what with the metawidget at this point, depending on what you guys are each most comfortable spending time doing, and on your respective current states of progress.
-mental
participants (4)
-
Alexandre Prokoudine
-
Bryce Harrington
-
MenTaLguY
-
Niko Kiirala