handling of bugfixes for particular cases
Hi,
I just fixed bug #190424 and #168777. These are about incorrect font size when creating text in a document, that has a viewBox attribute. My patch does not fix the lack of viewBox handling in general, but only for text tool. Actually Inkscape needs a proper generic implementation of viewBox handling I think, but this is probably a larger piece of work.
I'd like to know how our policy is for such cases. Go for the easy fix now, and revert it once the proper general fix is done? Or postpone the whole issue until it is properly fixed?
Thomas
On Sat, Nov 29, 2008 at 9:26 AM, Thomas Holder <speleo3@...58...> wrote:
I'd like to know how our policy is for such cases. Go for the easy fix now, and revert it once the proper general fix is done? Or postpone the whole issue until it is properly fixed?
If there's no one working actively on this area right now, there's no need to postpone a partial fix. Just add a detailed comment to your fix describing why it is not optimal and what is needed for a better fix.
Thanks for the fixes!
bulia byak wrote:
If there's no one working actively on this area right now, there's no need to postpone a partial fix. Just add a detailed comment to your fix describing why it is not optimal and what is needed for a better fix.
thanks bulia.
I've started a wiki page for the "detailed comment" that analysis viewBox problems in inkscape.
http://wiki.inkscape.org/wiki/index.php/ViewBoxToDo
The wiki home page is locked, so I can't add a link there.
Thomas
Thomas Holder wrote:
bulia byak wrote:
If there's no one working actively on this area right now, there's no need to postpone a partial fix. Just add a detailed comment to your fix describing why it is not optimal and what is needed for a better fix.
thanks bulia.
I've started a wiki page for the "detailed comment" that analysis viewBox problems in inkscape.
Just added a note about Inkscape might wanting to add the viewBox attribute itself as well (to prevent similar problems when viewing documents in other applications).
(There was a discussion about this years ago as well.)
participants (3)
-
bulia byak -
Jasper van de Gronde -
Thomas Holder