Hi,
Following raster effects crash Inkscape here (Ubuntu Gutsy Gibbon) on most recent SVN trunk:
convolve shade wave raise
And a couple of notes:
1. Do we really need flop effect since we can already flip raster images horizontally and vertically, while flop does it only horizontally and in a destructive way? 2. Types of noises in "Noise" effect are not translatable. 3. Names of channels in Channel and Level Channel effects are not tranlsatable. 4. Does Threshold actually work? I tried it on several images but didn't see any effect whatever value I specified (0-100). 5. Should raster effects probably provide some hints to tell range of possible values for each variable? 6. We seem to use "Variable: [value]" convention in GUI, but no (boh raster and path) effect uses ":" after name of variable. Should it be fixed?
Alexandre
Alexandre,
I don't have SVN commit privileges, so Ted Gould has just been uploading the code I've produced for me. The final code, though, has not made it into SVN yet because Ted is away from home for a few days.
Using the final code, on my machine, I tested every effect on Ubuntu and a few on Windows, and they work.
I took convolve out because I couldn't figure out how it's supposed to be used. The codefiles are still in the source, but they're not loaded into the menu.
1. You're right, flop ought to be taken out. 2. & 3. I'll ask Ted about this -- I don't know how to make strings translatable. I think that C++ effects should be able to use the same format of .inx files as the Python/Perl/Bash effects, but I wasn't able to load external effect definitions for my effects. 4. Like convolve, I couldn't figure out what Threshold was supposed to do. Even using ImageMagick via the command line "convert" I couldn't make sense of it. 5. Most of the extensions have a min and max value for the numeric parameters. Do you mean something for the user to read? 6. All the effects use the same extension framework, so if this is agreed on, it will be a matter of minutes to go through the paramcolor.cpp, paramint.cpp, paramfloat.cpp etc. files and add a colon after the parameter labels.
-Christopher
On 8/26/07, Alexandre Prokoudine <alexandre.prokoudine@...400...> wrote:
Hi,
Following raster effects crash Inkscape here (Ubuntu Gutsy Gibbon) on most recent SVN trunk:
convolve shade wave raise
And a couple of notes:
- Do we really need flop effect since we can already flip raster
images horizontally and vertically, while flop does it only horizontally and in a destructive way? 2. Types of noises in "Noise" effect are not translatable. 3. Names of channels in Channel and Level Channel effects are not tranlsatable. 4. Does Threshold actually work? I tried it on several images but didn't see any effect whatever value I specified (0-100). 5. Should raster effects probably provide some hints to tell range of possible values for each variable? 6. We seem to use "Variable: [value]" convention in GUI, but no (boh raster and path) effect uses ":" after name of variable. Should it be fixed?
Alexandre
This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On 8/26/07, Christopher Brown wrote:
Alexandre,
I don't have SVN commit privileges, so Ted Gould has just been uploading the code I've produced for me. The final code, though, has not made it into SVN yet because Ted is away from home for a few days.
Using the final code, on my machine, I tested every effect on Ubuntu and a few on Windows, and they work.
Okay, I'm on revision 15901 and I'll check back when he code s in :)
I took convolve out because I couldn't figure out how it's supposed to be used. The codefiles are still in the source, but they're not loaded into the menu.
From what I remember, In graphics convolution usually blurs or sharpens.
http://docs.gimp.org/en/gimp-tool-convolve.html
- Like convolve, I couldn't figure out what Threshold was supposed to do.
Even using ImageMagick via the command line "convert" I couldn't make sense of it.
http://docs.gimp.org/en/gimp-tool-threshold.html
- Most of the extensions have a min and max value for the numeric
parameters. Do you mean something for the user to read?
Yes, some hint that pops up when a user hovers mouse cursor on spinbox.
- All the effects use the same extension framework, so if this is agreed
on, it will be a matter of minutes to go through the paramcolor.cpp, paramint.cpp, paramfloat.cpp etc. files and add a colon after the parameter labels.
Would be neat :)
Alexandre
On Sun, 2007-08-26 at 10:36 -0500, Christopher Brown wrote:
I don't have SVN commit privileges, so Ted Gould has just been uploading the code I've produced for me. The final code, though, has not made it into SVN yet because Ted is away from home for a few days.
I plan on working on this this week. Who knows, LA may just melt this week though :)
I took convolve out because I couldn't figure out how it's supposed to be used. The codefiles are still in the source, but they're not loaded into the menu.
I think this might still be useful. I'm a DSP freak though -- so it may be to just me ;)
- You're right, flop ought to be taken out.
- & 3. I'll ask Ted about this -- I don't know how to make strings
translatable. I think that C++ effects should be able to use the same format of .inx files as the Python/Perl/Bash effects, but I wasn't able to load external effect definitions for my effects.
For the INX files that are built into the codebase you'll need a _() surrounding the strings to be translated.
- Like convolve, I couldn't figure out what Threshold was supposed to
do. Even using ImageMagick via the command line "convert" I couldn't make sense of it.
Take it out then? Anyone object? Chris, do you think it makes sense to e-mail the Imagemagick lists on this?
- All the effects use the same extension framework, so if this is
agreed on, it will be a matter of minutes to go through the paramcolor.cpp, paramint.cpp, paramfloat.cpp etc. files and add a colon after the parameter labels.
This is an interesting point. Should we do this globally and take it out of the INX files? Would that be easier or harder to translate? Does every language use ":"?
--Ted
On 9/2/07, Ted Gould <ted@...11...> wrote:
On Sun, 2007-08-26 at 10:36 -0500, Christopher Brown wrote:
I don't have SVN commit privileges, so Ted Gould has just been uploading the code I've produced for me. The final code, though, has not made it into SVN yet because Ted is away from home for a few days.
I plan on working on this this week. Who knows, LA may just melt this week though :)
I took convolve out because I couldn't figure out how it's supposed to be used. The codefiles are still in the source, but they're not loaded into the menu.
I think this might still be useful. I'm a DSP freak though -- so it may be to just me ;)
Okay, I'll try to figure it out.
- You're right, flop ought to be taken out.
- & 3. I'll ask Ted about this -- I don't know how to make strings
translatable. I think that C++ effects should be able to use the same format of .inx files as the Python/Perl/Bash effects, but I wasn't able to load external effect definitions for my effects.
For the INX files that are built into the codebase you'll need a _() surrounding the strings to be translated.
Okay. Might take awhile, but I can do that.
- Like convolve, I couldn't figure out what Threshold was supposed to
do. Even using ImageMagick via the command line "convert" I couldn't make sense of it.
Take it out then? Anyone object? Chris, do you think it makes sense to e-mail the Imagemagick lists on this?
I guess I sort of know what it's supposed to do -- it's supposed to convert every pixel above the specified intensity to white and everything below to black. I just couldn't get it to do that. I can look into this too -- school doesn't start until the 5th.
- All the effects use the same extension framework, so if this is
agreed on, it will be a matter of minutes to go through the paramcolor.cpp, paramint.cpp, paramfloat.cpp etc. files and add a colon after the parameter labels.
This is an interesting point. Should we do this globally and take it out of the INX files? Would that be easier or harder to translate? Does every language use ":"?
Personally I never found the lack of a colon hard to understand, but for solidarity's sake, I can insert colons when I go through with the _( )'s, if that's what's needed.
-Christopher
On 9/3/07, Christopher Brown wrote:
- All the effects use the same extension framework, so if this is
agreed on, it will be a matter of minutes to go through the paramcolor.cpp, paramint.cpp, paramfloat.cpp etc. files and add a colon after the parameter labels.
This is an interesting point. Should we do this globally and take it out of the INX files? Would that be easier or harder to translate? Does every language use ":"?
Personally I never found the lack of a colon hard to understand, but for solidarity's sake, I can insert colons when I go through with the _( )'s, if that's what's needed.
Well, that's rather for consistency sake :) Thank you!
Alexandre
On Sun, 2007-08-26 at 18:32 +0400, Alexandre Prokoudine wrote:
Following raster effects crash Inkscape here (Ubuntu Gutsy Gibbon) on most recent SVN trunk:
<snip>
- Do we really need flop effect since we can already flip raster
images horizontally and vertically, while flop does it only horizontally and in a destructive way? 2. Types of noises in "Noise" effect are not translatable. 3. Names of channels in Channel and Level Channel effects are not tranlsatable.
I believe all of these are fixed with my most recent commit. Please verify.
- We seem to use "Variable: [value]" convention in GUI, but no (boh
raster and path) effect uses ":" after name of variable. Should it be fixed?
Is this something that can be done pragmatically? Or does it need to be added into the translatable string because different languages use different characters and/or placement.
--Ted
participants (3)
-
Alexandre Prokoudine -
Christopher Brown -
Ted Gould