Fix for [ 1679367 ] no icon to justify text in dialog
My first bug is done and ready to go! It seems that I can't actually upload my patch as an attachment to the bug itself, so mental suggested creating a new entry in the patch tracker. Because I have never had a need for patches in the past, this is the first one I've made. As such, I'd like to have somebody double check that it worked ok before I officially upload it.
http://gbanaszk.oasis.nexus.carleton.ca/SummerOfCode/patch-bug1679367.txt
All I did here was add the justify button to the text dialog.
Gail
Hello Gail,
could you change the editor settings so that diff shows only changed lines ? Maybe there are some differences in the white-space settings.
Thx,
Adib. ---
Gail Banaszkiewicz schrieb:
My first bug is done and ready to go! It seems that I can't actually upload my patch as an attachment to the bug itself, so mental suggested creating a new entry in the patch tracker. Because I have never had a need for patches in the past, this is the first one I've made. As such, I'd like to have somebody double check that it worked ok before I officially upload it.
http://gbanaszk.oasis.nexus.carleton.ca/SummerOfCode/patch-bug1679367.txt
All I did here was add the justify button to the text dialog.
Gail
Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=D... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Hey Adib, can you check again? I made a mistake with the diff and got a really big yucky one at first. I have since re-uploaded to the same link. Let me know if the problem you are talking about is still there.
Gail
Adib Taraben wrote:
Hello Gail,
could you change the editor settings so that diff shows only changed lines ? Maybe there are some differences in the white-space settings.
Thx,
Adib.
Gail Banaszkiewicz schrieb:
My first bug is done and ready to go! It seems that I can't actually upload my patch as an attachment to the bug itself, so mental suggested creating a new entry in the patch tracker. Because I have never had a need for patches in the past, this is the first one I've made. As such, I'd like to have somebody double check that it worked ok before I officially upload it.
http://gbanaszk.oasis.nexus.carleton.ca/SummerOfCode/patch-bug1679367.txt
All I did here was add the justify button to the text dialog.
Gail
Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=D...
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Gail, now the patch looks better :-)
icon is there and it does the same as the one in the toolbar :-))
Good !
Adib. ---
Gail Banaszkiewicz schrieb:
Hey Adib, can you check again? I made a mistake with the diff and got a really big yucky one at first. I have since re-uploaded to the same link. Let me know if the problem you are talking about is still there.
Gail
Adib Taraben wrote:
Hello Gail,
could you change the editor settings so that diff shows only changed lines ? Maybe there are some differences in the white-space settings.
Thx,
Adib.
Gail Banaszkiewicz schrieb:
My first bug is done and ready to go! It seems that I can't actually upload my patch as an attachment to the bug itself, so mental suggested creating a new entry in the patch tracker. Because I have never had a need for patches in the past, this is the first one I've made. As such, I'd like to have somebody double check that it worked ok before I officially upload it.
http://gbanaszk.oasis.nexus.carleton.ca/SummerOfCode/patch-bug1679367.txt
All I did here was add the justify button to the text dialog.
Gail
Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=D...
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On 3/24/07, Gail Banaszkiewicz <gbanaszk@...1686...> wrote:
My first bug is done and ready to go! It seems that I can't actually upload my patch as an attachment to the bug itself, so mental suggested creating a new entry in the patch tracker. Because I have never had a need for patches in the past, this is the first one I've made. As such, I'd like to have somebody double check that it worked ok before I officially upload it.
http://gbanaszk.oasis.nexus.carleton.ca/SummerOfCode/patch-bug1679367.txt
Thanks, works ok so I committed it and closed the bug.
Actually it works a bit unintuitively in that it requires that one presses Apply to have any effect, but oh well, that's the problem with the entire dialog. Let's work on the toolbar to make it richer and more usable so that the dialog is needed less often.
participants (3)
-
Adib Taraben
-
bulia byak
-
Gail Banaszkiewicz