Submission Process
Hey guys,
I'm not sure I can remember if I need to do anything special for my recent submission of a branch on launchpad for review and merge. Does Inkscape follow the normal launchpad workflow since it's on launchpad?
https://code.launchpad.net/~doctormo/inkscape/barcode-refactor/+merge/44768
Let me know if there is anything special I need to do to make sure this gets put into the right pile.
Martin,
Martin,
Hey guys,
I'm not sure I can remember if I need to do anything special for my recent submission of a branch on launchpad for review and merge. Does Inkscape follow the normal launchpad workflow since it's on launchpad?
https://code.launchpad.net/~doctormo/inkscape/barcode-refactor/+merge/44768
Wow great work! I approve it seems to be an overhaul. I'm not an Admin but if possible add the shebang. "#!/usr/bin/env python"
Let me know if there is anything special I need to do to make sure this gets put into the right pile.
Yes seems to be in the right place, but I think it should be added to all versions.
Martin,
Regards, Leo Jackson
On Wed, 2010-12-29 at 13:19 -0800, Leo Jackson wrote:
Wow great work! I approve it seems to be an overhaul. I'm not an Admin but if possible add the shebang. "#!/usr/bin/env python"
Python shebangs shouldn't be in modules, I removed them to comply with general python coding practice. If there is a reason to add them back I will, but the modules are none functional when executed and in a separate directory so shouldn't be executed anyway.
Thanks for reviewing.
Martin,
Martin,
We had a bug on this which in turn we decided to add shebangs. Following bug: https://bugs.launchpad.net/inkscape/+bug/602005 Yes it might or might not be in a tool box of sorts, but if we decide to add it to a toolbox or command line tool set to spit out barcodes which I do myself the shebands work great.
Python shebangs shouldn't be in modules, I removed them to comply with general python coding practice. If there is a reason to add them back I will, but the modules are none functional when executed and in a separate directory so shouldn't be executed anyway.
Thanks for reviewing.
Martin,
participants (2)
-
Leo Jackson -
Martin Owens