December 2003 - Inkscape Devel

RE: [Inkscape-devel] non-ASCII chars
by bulia byak 09 Dec '03

09 Dec '03

On the other hand, why do we have to guard against any control chars at all? If we get a string in UTF8, suffices it to check that it's valid UTF8, and complain if it's not. If it is valid, we can insert it without any further checks. Any objections? >From: "bulia byak" <archiver_1@...19...> >To: inkscape-devel(a)lists.sourceforge.net >Subject: RE: [Inkscape-devel] non-ASCII chars >Date: Tue, 09 Dec 2003 06:09:38 +0000 > >OK, I solved this one. Indeed the problem was gchar (i.e. signed) - which >was treated as less-than-zero when it run into this stupid bit of code: > >if ((spnew[i] < 32) && ((spnew[i] != 9) && (spnew[i] != 10) && (spnew[i] != >13))) spnew[i] = 32; > >which was meant to replace control chars with spaces, but ended up >replacing all non-ascii chars with spaces when used with gchar instead of >guchar. > >I'll now rewrite this brain damage properly, using g_unichar_iscntrl(). > > >>From: "bulia byak" <archiver_1@...19...> >>To: inkscape-devel(a)lists.sourceforge.net >>Subject: [Inkscape-devel] non-ASCII chars >>Date: Tue, 09 Dec 2003 05:36:50 +0000 >> >>I have merged the interesting parts of 0.33's sp-text.c and >>text-context.c, but this did not help with the cyrillic chars being >>untypeable. I started to dig into this specifically and now I have a >>strong suspicion that the culprit is the inkscape's change from guchar to >>gchar in functions that insert new chars into the string as they are >>typed. I cannot test it quickly because it requires changing in lots of >>places (and they cannot be simply cast, at least not with g++), but this >>seems likely. For example sp_text_insert used to receive the char to >>insert as a guchar, but now it gets gchar. As it is supposed to be in >>UTF8, perhaps the encoding goes wrong and the result is the space >>characters in the string (or at least something that looks like spaces). >> >>So: >> >>- Does anyone else think that guchar/gchar replacement could break this? >> >>- Why was this replacement necessary in the first place? >> >>- Is it OK if I reverse it in the text code? >> >>_________________________________________________________________ >>Add photos to your e-mail with MSN 8. Get 2 months FREE*. >>http://join.msn.com/?page=features/photos&pgmarket=en-ca&RU=http%3a%2f%2fjo… >> >> >> >>------------------------------------------------------- >>This SF.net email is sponsored by: SF.net Giveback Program. >>Does SourceForge.net help you be more productive? Does it >>help you create better code? SHARE THE LOVE, and help us help >>YOU! Click Here: http://sourceforge.net/donate/ >>_______________________________________________ >>Inkscape-devel mailing list >>Inkscape-devel(a)lists.sourceforge.net >>https://lists.sourceforge.net/lists/listinfo/inkscape-devel > >_________________________________________________________________ >The new MSN 8: smart spam protection and 2 months FREE* >http://join.msn.com/?page=features/junkmail >http://join.msn.com/?page=dept/bcomm&pgmarket=en-ca&RU=http%3a%2f%2fjoin.ms… > > > >------------------------------------------------------- >This SF.net email is sponsored by: SF.net Giveback Program. >Does SourceForge.net help you be more productive? Does it >help you create better code? SHARE THE LOVE, and help us help >YOU! Click Here: http://sourceforge.net/donate/ >_______________________________________________ >Inkscape-devel mailing list >Inkscape-devel(a)lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/inkscape-devel _________________________________________________________________ The new MSN 8: smart spam protection and 2 months FREE* http://join.msn.com/?page=features/junkmail http://join.msn.com/?page=dept/bcomm&pgmarket=en-ca&RU=http%3a%2f%2fjoin.ms…

3 2

RE: [Inkscape-devel] non-ASCII chars
by bulia byak 09 Dec '03

09 Dec '03

>On Tue, 2003-12-09 at 01:26, bulia byak wrote: > > On the other hand, why do we have to guard against any control chars at >all? > > If we get a string in UTF8, suffices it to check that it's valid UTF8, >and > > complain if it's not. If it is valid, we can insert it without any >further > > checks. Any objections? > >Well, define "complains"? Issue a g_warning and insert nothing. Actually this cannot happen unless there's a bug somewhere else. _________________________________________________________________ Help STOP SPAM with the new MSN 8 and get 2 months FREE* http://join.msn.com/?page=dept/bcomm&pgmarket=en-ca&RU=http%3a%2f%2fjoin.ms…

1 0

sodipodi diff
by bulia byak 09 Dec '03

09 Dec '03

(sorry my gaim keeps segfaulting, no idea why, never used it before... email is more reliable anyway :) I did a diff between the hydra branch and Sodipodi 0.33 (only /src). It's 450Kb so I cannot even put it on the tracker - maybe put into CVS? Where's the best place? Anyway, I would propose that everyone would review the diff and delete those parts that are already in Inkscape, or those that make to sense, or are already resimplemented differently, etc. Anything worth transferring should be transferred (and then deleted from the diff). Hopefully we can thus eventually reduce it to zero. I have already removed some small things that I copied to Inkscape. What I'd like to discuss is this: - arikkei_* functions are now used extensively all over the codebase, for things like number to string conversions. Are they worth borrowing? What are their advantages compared to atoi and snprintf used before? - Sodipodi 0.33 can type Cyrillic characters in the text tool. Inkscape cannot. Sodipodi also can display fancy chars such as em-dash (ctrl-u 2014), Inkscape cannot. I think this is due to all the Unicode new stuff in 0.33. We must have this too. Unfortunately it's quite big and complex and I'm not sure I can transfer this correctly. Any takers? - The "duplicate" checkbox in transformation dialog is nice. It looks simple so I will transfer it (after 0.36 release). _________________________________________________________________ Add photos to your messages with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=dept/features&pgmarket=en-ca&RU=http%3a%2f%2fjoin…

5 9

RE: [Inkscape-devel] non-ASCII chars
by bulia byak 09 Dec '03

09 Dec '03

OK, I solved this one. Indeed the problem was gchar (i.e. signed) - which was treated as less-than-zero when it run into this stupid bit of code: if ((spnew[i] < 32) && ((spnew[i] != 9) && (spnew[i] != 10) && (spnew[i] != 13))) spnew[i] = 32; which was meant to replace control chars with spaces, but ended up replacing all non-ascii chars with spaces when used with gchar instead of guchar. I'll now rewrite this brain damage properly, using g_unichar_iscntrl(). >From: "bulia byak" <archiver_1@...19...> >To: inkscape-devel(a)lists.sourceforge.net >Subject: [Inkscape-devel] non-ASCII chars >Date: Tue, 09 Dec 2003 05:36:50 +0000 > >I have merged the interesting parts of 0.33's sp-text.c and text-context.c, >but this did not help with the cyrillic chars being untypeable. I started >to dig into this specifically and now I have a strong suspicion that the >culprit is the inkscape's change from guchar to gchar in functions that >insert new chars into the string as they are typed. I cannot test it >quickly because it requires changing in lots of places (and they cannot be >simply cast, at least not with g++), but this seems likely. For example >sp_text_insert used to receive the char to insert as a guchar, but now it >gets gchar. As it is supposed to be in UTF8, perhaps the encoding goes >wrong and the result is the space characters in the string (or at least >something that looks like spaces). > >So: > >- Does anyone else think that guchar/gchar replacement could break this? > >- Why was this replacement necessary in the first place? > >- Is it OK if I reverse it in the text code? > >_________________________________________________________________ >Add photos to your e-mail with MSN 8. Get 2 months FREE*. >http://join.msn.com/?page=features/photos&pgmarket=en-ca&RU=http%3a%2f%2fjo… > > > >------------------------------------------------------- >This SF.net email is sponsored by: SF.net Giveback Program. >Does SourceForge.net help you be more productive? Does it >help you create better code? SHARE THE LOVE, and help us help >YOU! Click Here: http://sourceforge.net/donate/ >_______________________________________________ >Inkscape-devel mailing list >Inkscape-devel(a)lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/inkscape-devel _________________________________________________________________ The new MSN 8: smart spam protection and 2 months FREE* http://join.msn.com/?page=features/junkmail http://join.msn.com/?page=dept/bcomm&pgmarket=en-ca&RU=http%3a%2f%2fjoin.ms…

1 0

RE: [Inkscape-devel] unlimited undo
by bulia byak 09 Dec '03

09 Dec '03

>Okay, unlimited undo is now in CVS. I've added that to the release notes - please check if it's correct. _________________________________________________________________ Add photos to your e-mail with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/photos&pgmarket=en-ca&RU=http%3a%2f%2fjo…

1 0

non-ASCII chars
by bulia byak 09 Dec '03

09 Dec '03

I have merged the interesting parts of 0.33's sp-text.c and text-context.c, but this did not help with the cyrillic chars being untypeable. I started to dig into this specifically and now I have a strong suspicion that the culprit is the inkscape's change from guchar to gchar in functions that insert new chars into the string as they are typed. I cannot test it quickly because it requires changing in lots of places (and they cannot be simply cast, at least not with g++), but this seems likely. For example sp_text_insert used to receive the char to insert as a guchar, but now it gets gchar. As it is supposed to be in UTF8, perhaps the encoding goes wrong and the result is the space characters in the string (or at least something that looks like spaces). So: - Does anyone else think that guchar/gchar replacement could break this? - Why was this replacement necessary in the first place? - Is it OK if I reverse it in the text code? _________________________________________________________________ Add photos to your e-mail with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/photos&pgmarket=en-ca&RU=http%3a%2f%2fjo…

1 0

unlimited undo
by MenTaLguY 09 Dec '03

09 Dec '03

Okay, unlimited undo is now in CVS. It's always kind of cool when you add a new feature by _deleting_ code. ^_^ -mental

1 0

button.c again
by bulia byak 09 Dec '03

09 Dec '03

So what's the resolution with button.c? I still cannot compile it, now with one more error: button.c:62: error: invalid conversion from `void (*)(SPAction*, int, void*)' to `void (*)(SPAction*, unsigned int, void*)' button.c: In function `void sp_button_toggle_set_down(SPButton*, int)': button.c:189: error: invalid conversion from `void (*)()' to `void*' button.c:191: error: invalid conversion from `void (*)()' to `void*' _________________________________________________________________ Protect your PC - get McAfee.com VirusScan Online http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963

2 1

Re: [Inkscape-devel] sodipodi diff
by bulia byak 09 Dec '03

09 Dec '03

>>I can at least have a look at it... I think as part of the merge it >>might be important to understand why it doesn't currently work, too. >> >> > >I can lend a hand looking into this a little. Though it's been ages since >I've done MSVC stuff here, I have worked in i18n on and off for the past 10 >years. That would be fantastic! This is an important issue, as it makes the program almost useless unless you only do English-language art. We must get it right. Fortunately, it may be that the Unicode fonts stuff is not relevant to the issue. This is because I can actually type cyrillic (or paste fancy chars from other programs) into the text dialog, and when applied, it is properly displayed on the canvas. This may mean that only the text tool is somehow broken, but font display works right. I will look into it but I would welcome anyone's help too. I've filed a detailed bug so we don't forget about this: https://sourceforge.net/tracker/index.php?func=detail&aid=856528&group_id=9… It would be very nice to have this fixed before the release. _________________________________________________________________ STOP MORE SPAM with the new MSN 8 and get 2 months FREE* http://join.msn.com/?page=dept/bcomm&pgmarket=en-ca&RU=http%3a%2f%2fjoin.ms…

2 1

reduce, reuse, recycle
by Jonathan Phillips 09 Dec '03

09 Dec '03

In terms of getting ready for the 0.36 release of Inkscape, what do you all think about commenting out a few unimplemented features. IMO I think we should comment out: print preview (in the file menu) about modules (in the help menu) No use in confusing the new users. Jon -- Jonathan Phillips <jon@...15...>

3 3