removing trivial wrappers
by Robert Crosbie
There are some wrappers that I'm not sure what to do with:
This one below returns a value, but it is never checked. I assume a
straight replacement is fine in this case and ignore the return value.
inline unsigned int sp_repr_add_child(Inkscape::XML::Node *repr,
Inkscape::XML::Node *child, Inkscape::XML::Node *ref)
{
repr->addChild(child, ref);
return true;
}
There are others like this one below, where the value is actually
checked somewhere. Should the ckeck be removed since it will always
be true anyway?
inline unsigned int sp_repr_remove_child(Inkscape::XML::Node *repr,
Inkscape::XML::Node *child) {
repr->removeChild(child);
return true;
}
...
ok = sp_repr_remove_child (NODE_DATA (old_parent)->repr, NODE_DATA
(node)->repr) &&
sp_repr_add_child (NODE_DATA (new_parent)->repr, NODE_DATA
(node)->repr, ref);
...
sp_repr_set_attr is another one that always returns true, but is used
as a return value and in conditionals in a number of places.
Should all instances of append_child be replaced with addChild? There
are many, but it could be a Janitor item.
void addChild(Inkscape::XML::Node *child, Inkscape::XML::Node *ref);
void appendChild(Inkscape::XML::Node *child) { addChild(child,
_last_child); }
Cheers,
--
Rob.
http://woodpendant.com
18 years, 3 months
NEW: on-canvas gradient editing
by bulia byak
Now in CVS:
Gradient editing on canvas is now available, much more convenient and
powerful than the old way of dragging gradient knots in the
Fill&Stroke dialog.
o Any number of selected objects can simultaneously display
handles and direction lines for their linear and radial gradients (in
the objects' fills or strokes). You can drag these handles directly in
the drawing, to interactively adjust gradient positions.
o Gradient handles can be enabled in the Node tool, shape
tools, Text tool, and Dropper tool (on by default), as well as in
Selector and Zoom tools (off by default). Use the Inkscape Preferences
dialog to change this.
o Any gradient handle, if dragged close to a handle of
another gradient, will merge with that handle (drag with Shift to
prevent merging). Dragging such a merged handle will adjust any number
of gradients attached to it. To separate merged handles, drag them
away one by one with Shift.
o Radial gradients display handles in the center and at the
ends of two radii, which allows you to move, rotate, squeeze, or
stretch the gradient to form an arbitrary ellipse. Also, you can
independently adjust the focus of the gradient; drag the central
handle with Shift to separate the focus handle.
o When dragged, handles will snap to the edges and the
central axes of the bounding boxes of all selected objects (drag with
Shift to prevent snapping).
o Dragging with Ctrl will snap the angle of the linear or
radial gradient to the user-settable angle increments (default is 15
degrees). The center of a radial gradient, dragged with Ctrl, will be
constrained to horizontal and vertical movement relative to its
previous position. When dragged with Ctrl+Alt, a handle moves along
the gradient direction or its perpendiculars, allowing you e.g. to
stretch or squeeze a linear gradient without disturbing its angle.
Overall, this is a major usability milestone, something I dreamed to
do since Sodipodi times. Gradients are one of the most widely used
features in Inkscape, and now they are finally made usable (well,
almost - see below).
The old gradient position widget in Fill&stroke remains for now (and
still works), but I plan to remove it as soon as the new on-canvas
editing is sufficiently tested. I would welcome any feedback on the
new feature.
Next in my plans: A Gradient tool, which will allow you to actually
create new gradients by dragging (at the moment you still need to open
Fill&stroke to switch an object to gradient) as well as adjust most
gradient settings in its controls bar at the top of the window. In
that tool, the selected gradient handle will be moveable by arrow keys
(with all the usual modifiers), and setting any color via Fill&stroke,
palette, dropper, or Paste style will be applied to the selected
handle's gradient stop (instead of the entire selected object).
18 years, 3 months
cxxtestgen.pl
by Robert Crosbie
I'm getting this trying to compile from latest CVS has cxxtestgen.pl
been checked in, or did I just not update correctly?
cxxtestgen.pl -part -o libnr/test-nr.cpp ./libnr/nr-types-test.h
./libnr/nr-translate-test.h ./libnr/nr-rotate-test.h
./libnr/nr-scale-test.h ./libnr/nr-point-fns-test.h
./libnr/nr-rotate-fns-test.h ./libnr/in-svg-plane-test.h
./libnr/nr-matrix-test.h
make[2]: cxxtestgen.pl: Command not found
make[2]: *** [libnr/test-nr.cpp] Error 127
...
Cheers,
--
Rob.
http://woodpendant.com
18 years, 3 months
Nightly build service statistics
by Mike Hearn
Hi,
The nightly autopackage is currently being downloaded approximately 10
times per day, that is, there have been slightly more than 100 downloads
in the past ten days.
It's too bad the SF statistics system is offline at the moment, I'd be
curious to know how many people were downloading the official packages. Oh
well.
thanks -mike
18 years, 3 months
canvas border dropshadow
by Jakub Steiner
Hi there fellas!
How would you feel about dropping the dropshadow for the document canvas
border? It's visually distracting for small icons. While I'd like to
have a very light outline to see where the edge is, I don't like the
border taking too much attention away from the actual artwork and that's
what happens thanks to its non-symmetric look.
cheers
--
Jakub Steiner <jimmac@...659...>
Novell, Inc.
18 years, 3 months
Wiki change notices
by Bryce Harrington
Hey Kees,
Can you set up that nifty weekly wiki-change notice you did at work, for
use with Inkscape?
Bryce
18 years, 3 months
Re: [Inkscape-devel] Setting physical resolution and exporting
by unknown@example.com
Hello!
Thanks for the answer, but that did not work in the version I had used.
I had just modified the generated postscript files instead.
Best regards,
Artur
> <start-nasty-hack>
>
> Turns out, that the EPS save uses the Postscript output module, just
> with it's own set of parameters. So, if you printed the file using the
> postscript output, changing the values in that dialog. Then, you saved
> as EPS, it would use the settings you just set in the print.
>
> I'm not saying this is a good thing, but I'm pretty sure that will work.
>
> </start-nasty-hack>
>
>
> --Ted
18 years, 3 months
OSX packaging
by Kees Cook
Well, with help from many people and activity on the IRC channel, I've
blindly cobbled together some stuff for an OSX .app package.
This basically works a lot like our Win32 package: all the libraries
come along for the ride. (Which makes it giant: installed >100M, .dmg
is 32M)
New things in the CVS tree:
- configure has --enable-osxapp which turns on my guesses at path
locations in src/path-prefix.h
- packaging/osx-app.sh attempts to create a .app package from a built inkscape
- Info.plist is built from Info.plist.in. I have no idea if this file
is valid.
To compile inkscape on OSX, with modern fink, everything is available
except gc 6.4. I updated the wiki here:
http://www.inkscape.org/cgi-bin/wiki.pl?CompilingMacOsX
I didn't get into the gc details, but if you build your own gc, and
install it in ~/sw, you can build inkscape with:
SW=~/sw
export CPPFLAGS="-I$SW/include -I/sw/include"
export LDFLAGS="-L$SW/include -L/sw/lib"
./configure --prefix=$SW
After a "make install", you can build your Inkscape.app with:
bash packaging/osx-app.sh Inkscape ~/sw/bin/inkscape Info.plist
which should also build the Inkscape.dmg
This is all completely untested. The only thing I know for sure is that
the library resolution works right (I can run inkscape from the .app
directory -- via command line). I have no idea what happens from within
OSX itself (I'm ssh'd into a friend's machine). But I'm pretty sure
whatever goes wrong can be fixed via src/path-prefix.h and Info.plist.in
Good luck! I'm going to sleep! :)
--
Kees Cook @outflux.net
18 years, 3 months
Re: [Inkscape-devel] NEW: on-canvas gradient editing
by Alexandre Prokoudine
On Sun, 20 Feb 2005 07:36:37 -0800, Kees Cook <kees@...62...> wrote:
> ? http://www.inkscape.org/cvs-snap/
>
> That URL gets updated every 20 minutes. Or does that not get you
> something you're looking for? (And daniel's has been working since
> yesterday afternoon)
Hmm, they were not updated for quite a long while earlier, so I didn't
even care to look there. Thank you for fixing my /dev/brain symlink :)
Alexandre
18 years, 3 months