March 2013 - Inkscape Devel - Inkscape Mailman

Re: [Inkscape-devel] C++ification of the SPObject tree
by Markus Engel 28 Mar '13

28 Mar '13

Oh I see it deleted my attachment... But when my patch is uncompressed it doesn't like it either, as it's too big... Here's a link then: http://dl.dropbox.com/u/37427492/virtual_pads.patch Markus

2 1

C++ification of the SPObject tree
by Markus Engel 28 Mar '13

28 Mar '13

Hi, I'm new here ;) . As I really like Inkscape I thought I'd help out programming. In order to gain some insight I started with a janitorial task, I put the virtual function calls in the SPObject tree into C++ classes. I found the procedure of porting the tree to C++ described in the wiki: http://wiki.inkscape.org/wiki/index.php/CPlusPlus This works quite well. In the attached patch you can find those "virtual pads". At the moment I'm turning all the other functions into real member functions and I'm playing around with a new factory that is independent of glib. Tell me what you think about it. Markus

1 0

Something special about Cairo glyph draws?
by mathog 27 Mar '13

27 Mar '13

There is something strange going on related to glyph draws through Cairo which I have not been able to figure out. Hopefully fresh eyes will spot the problem. In drawing-text.cpp this is the code that outputs the series of glyphs which put text on the screen, slightly modified to put a line over the glyphs (my changes all start at the first character on the line and end with "//"): Geom::Affine aff; // bool aff_set = false; // for (ChildrenList::iterator i = _children.begin(); i != _children.end(); ++i) { if(!aff_set){ // aff = g->_ctm; // aff_set=true; // } // DrawingGlyphs *g = dynamic_cast<DrawingGlyphs *>(&*i); if (!g) throw InvalidItemException(); Inkscape::DrawingContext::Save save(ct); if (g->_ctm.isSingular()) continue; ct.transform(g->_ctm); ct.path(*g->_font->PathVector(g->_glyph)); } // draw a rectangle over all of the glyphs, tsp_width_adj has the correct value if(aff_set){ // ct.transform(aff); // ct.rectangle( Geom::Rect(Geom::Point(0.0,0.0),Geom::Point(tsp_width_adj, 0.1)) ); // } // The strange thing is that the rectangle draw results in an XOR against the underlying glyphs. (Overlaps are not filled.) The reason this is bizarre is that when the code is modified so that the glyphs overlap each other (easy to do, just change the "g->_ctm" in ct.transform() to "aff") the glyphs do not XOR against each other. Use a string like "XO" to see this. Instead they just draw over each other, as one would expect for all of these draws. I thought the XOR might have something to do with the ct.rectangle() call, so made an alternate version where the rectangle is first converted to a (closed) PathVector "rectpath" and then this is done: ct.transform(aff); // ct.path(rectpath); // Unfortunately, this also had the XOR effect. I am puzzled. Where is the XOR effect coming from? More to the point, what is special about the glyph paths so that if they overlap there is no XOR, but a glyph and a rectangle or another path do XOR? By placing a DEBUG print statement at the top of _renderItem() one can see that this method is called twice for every string (actually <tspan>) in the document which is updated/changed. I suppose the XOR effect might have something to do with that, but it does not really make sense either, since the glyphs are drawn as many times as the overlapping line. Thanks, David Mathog mathog@...1176... Manager, Sequence Analysis Facility, Biology Division, Caltech

2 2

Crediting Tango icons for Inkscape
by Peter Uithoven 27 Mar '13

27 Mar '13

Hi Inkscape Developers and Designers, I'm involved with the application VisiCut, an opensource and more userfriendly application to talk to Lasercutters. http://visicut.org/ One of the things I'd like to do is introduce better icons. I really like you guys work on the Tango icons for Inkscape. So I'd like to properly credit the authors / designers. Could you guys help me out on how to do that? At the moment I would use: Tango Icon Library 0.8.90 (tango) link: http://tango.freedesktop.org/Tango_Icon_Library license: Public Domain Inkscape (inkscape) link: http://www.inkscape.org/ license: GPLv2 I found the icons in the Open Icon Library<http://openiconlibrary.sourceforge.net/>, but it's a bit unclear which icon is from which source. Great work on Inkscape btw, I'm involved with Fablab Amersfoort<http://www.fablabamersfoort.nl/nl> and it's one of the tools we advocate. Thanks in advance, Best regards, Peter Uithoven

5 6

Gtk+ backend target
by Alex Valavanis 26 Mar '13

26 Mar '13

Hi All, Why do we explicitly check for the Gtk+ backend target in configure.ac? The resulting $gtk_backend_target variable isn't used anywhere except for deciding whether to link the -lX11 library or not. In fact, this seems unnecessary too, because gtk+ reports whether it needs -lX11 via pkg-config so we should pick up the dependency automatically. Our method of checking the backend target isn't supported by gtk+ 3 in any case, so can we get rid of the test? AV

4 10

Suggestion of Recolor-Artwork Tool.
by Arshdeep Singh 26 Mar '13

26 Mar '13

Dear devs, Need some advice on my suggestion of recolor-artwork tool based on Illustrator's similar tool. *Advantages of the tool: *1.) Lets you manage interdependence of colors. For example, you select a circle and a rectangle respectively colored RED and ORANGE. For some reason you want to port the whole 'tone' to something cooler. You select the two objects on the canvas, lock their nodes on the color wheel and rotate the rays of the objects to the blue wedge area of the wheel. Now with a single step you can manage the color tones and relationship of different objects. This should prove very beneficial for designers/artists. *My Blueprint: *[image: Inline image 1] *Steps:* 1.) Get the colorwheel drawn using the source files "gimpcolorwheel.c" as reference. 2.) Get the GUI for selected objects (based on the XML Tree) [First prototype will only handles solid colors] 3.) Functions for locking the nodes, rotation, dragging etc. Any inputs / advice / suggestions are heartily welcome. -- demicoder

1 0

Symbols Dialog
by Tavmjong Bah 26 Mar '13

26 Mar '13

Hi, I've checked into trunk a Symbols dialog. A description of the dialog can be found on a Wiki page at: http://wiki.inkscape.org/wiki/index.php/SymbolsDialog There are still some issues that need to be resolved. They are listed in Wiki page. Tav

6 18

documentation on the Perl component?
by Bric 26 Mar '13

26 Mar '13

I can't find any documentation on the Perl component. When I compiled 0.48.4 I used --with-perl, which looked promising. How do I use this component? thanks

5 6

units (revisited)
by Bric 25 Mar '13

25 Mar '13

Hi Not sure if this belongs to the "devel" mailing list (maybe tangentially, if it leads to enhancements?) I know this has been addressed before, but I couldn't find the final resolution to all the questions (here's a related post that doesn't seem to clinch it: http://www.inkscapeforum.com/viewtopic.php?f=5&t=10646) I have the same problem: via the command line I'm getting one type of value, but in the SVG document a different value is listed. COMMAND LINE: inkscape -f doc.svg --query-x --query-id=rect4487-1-7 139.43438 inkscape -f doc.svg --query-y --query-id=rect4487-1-7 128.13251 WITHIN THE SVG DOCUMENT: <rect id="rect4487-1-7" ry="0.53296167" height="1.0654094" width="10.142718" y="72.914459" x="79.345848" style="fill:currentColor" /> Also, within the svg doc, the dimensions are: width="315" height="206" And thus the above can't seem to account for the discrepancy, by means of origin position adjustment (width - x, height - y) So far, it looks like different units are used. thanks

1 1

Re: [Inkscape-devel] New contributor (we have new code!) that we need to help
by Ted Janeczko 24 Mar '13

24 Mar '13

Hi, Thank you so much for the very warm welcome! I look forward to working with you and contributing more code upstream! Josh, I subscribed to the mailing list, but for some reason I haven't been getting emails from it... I tried to resubscribe, hopefully that works! Tav, that sounds like a fantastic birthday party! I've done quite a bit of looking into the internal workings of SPObjects when I created the objects dialog, and I think I have a decent understanding of how everything is updated, but it does get very confusing due to gobject obscurities... If it would help out, I can take a closer look into this and start documenting the process so that it will be easier to work with in the future. When I created the objects dialog patch to submit upstream, I went through my code, added comments, reorganized, and fixed as many bugs as I could find. The blurring crash that you're referring to is most likely due to a linked-list error, which I also encountered in my testing and hopefully fixed in the patch. I also reworked styling the buttons, so the up/down arrows should hopefully now have tooltips (although it may still be unclear as to what they do, so a more descriptive tooltip may be needed). The random hiding of objects with drag-and-drop appears to be a weird side effect of the workaround for supporting multiple items. To fix this, I added a flag in the patch which gets set if the mouse-down event occurs over the visible column. When the mouse is released, if this flag is not set the visibility toggle will not be triggered. In my tests, it seemed that only the visibility column was being triggered, so I didn't add flags for the other columns, but they could easily be added if issues pop up in the future. In the latest Ponyscape release, there is an issue with re-selecting items when they've been moved via drag-and-drop that causes a lot of assertion errors (which may be the errors that you were seeing). I store the source SPItems in a vector, which I iterate over and move on a drop operation. I was also using this vector to select the items post-move, but they no longer referred to the correct SPItem (due to how SPObjects are built and moved). In the patch, I now store the ID's of the items before they're moved in a different vector and use that for fetching and selecting the items after the move. Moving items between layers and into and out of groups is currently only able to be done through drag-and-drop... It would be possible to add buttons similar to the XML editor, but that may overcrowd the UI. This functionality could also be added to the right-click menu, which might be a better solution. You can already group and ungroup items using the right-click menu (along with clipping and masking items). If you notice anything else or have any suggestions on improving things, let me know and I'll take a look into it! I am planning on doing the same process of reviewing, commenting, and bugfixing my code before creating a patch for the tags dialog, and will definitely be sure to keep in mind all of the points you brought up about it. In the top revision of Ponyscape I have already added the ability to rename objects in the tags dialog, and I will look into the rest of the items that you have brought up! I may eventually move Ponyscape development into a branch on launchpad... For the time being I am using a repository on a local server, which has been working out so far, but I can definitely see where it would be beneficial to have a public branch as well. Looking forward to working more with the development team! Ted Janeczko On Tue, Mar 19, 2013 at 12:13 PM, Josh Andler <scislac@...400...> wrote: > I'm sending this to you only because I don't know that you've > subscribed to our developer list yet. :) > > > ---------- Forwarded message ---------- > From: Tavmjong Bah <tavmjong@...8...> > Date: Tue, Mar 19, 2013 at 6:27 AM > Subject: Re: [Inkscape-devel] New contributor (we have new code!) that > we need to help > To: Josh Andler <scislac@...400...> > Cc: Inkscape Devel List <inkscape-devel(a)lists.sourceforge.net> > > > > Hi, > > First, let me say this really sounds great! Welcome Ted! I could have > used Ponyscape a couple of months ago when I was preparing a Pony party > for my older daughter's sixth birthday. The guests played pin the horn > on Fluttershy and the birthday cake was a Pony Carousel. > > Here are some random thoughts: > > Let's be honest, 0.49 isn't going to happen soon. There is no sign that > anybody is tackling the bitmap scaling problem from either the Inkscape > or the Cairo side. And even if Cairo were to have the API's needed today > it will be awhile before there is a Cairo release with them. > > Given that, I don't think we need to be overly worried about changes to > the Inkscape code base. (But I do think new features should be > reasonably complete.) > > I am intrigued by Ted's comment about using an XmlNodeObserver for > handling updates. It would be good to have someone really understand how > updates are handled by Inkscape. When I put in random print statements I > often see the same code being executed multiple times when it should > only be executed once. We seem to have quasi-circular loops going on. > > Playing with the Object dialog in Ponyscape: > > * Blurring an object crashes Ponyscape. > * It's not clear what all the icons are for... no tooltips. What are > the up/down icons for? > * Clicking on the "domino" shaped icon brings up a color picker which I > can't seem to get rid of. I have to restart the program. > * Layers and objects seem to be randomly hidden when dragging them up > and down. > * Can't move objects between layers using arrows. > * Not easy to move objects into and out of groups (like in the XML > editor). > * I see lots of error messages. > > In summary, it's a good start but needs polishing before merging (note: > I haven't tested the patch, just Ponyscape). > > Playing with the Tagging dialog: > > * Needs tooltips or other hints on how to use. > * The items list is auto opened... maybe should also be auto closed? > * Would be useful to be able to rename objects in dialog. > * Might be good to integrate with symbols dialog (create custom symbols > from tagged objects). > > If Ted plans on submitting patches routinely, it might make sense for > him to keep his code repository as a branch of Inkscape. It would make > it easier to follow his work. > > Tav > > > On Tue, 2013-03-19 at 00:18 -0700, Josh Andler wrote: > > Hey all, > > > > I submitted a new "report" based around a patch submitted from the > > primary developer of Ponyscape (an Inkscape derivative project focused > > on making life easier for artists interested in creating My Little > > Pony fan art). > > > > Check out the first new patch he has submitted upstream at: > > https://bugs.launchpad.net/inkscape/+bug/1157024 > > > > I've talked with him a bit and he's really doing some good work at a > > rapid pace, but as we know, we don't have the same leeway upstream to > > add features that may change on a regular basis. So, he sees Ponyscape > > as a good testing ground to let things have some time to mature and > > ripen and then he will submit patches upstream. He also doesn't want > > to step on any toes or anything. > > > > That first patch is for a long awaited feature. If others would be > > willing to test and do some code review, it will help us to establish > > a tighter relationship with Ted. He's already met the 2 patch > > requirement and has commit access, but he really wants feedback and to > > get things right before stuff is committed. > > > > My guess is with the amount of divergence and level of changes he > > makes, this patch vs direct commit paradigm might be around for a > > while (he has a lot of irons in the fire for new/improved features). > > My view is that I don't mind doing this side of things provided other > > devs will be willing to help test and give feedback. > > > > Cheers, > > Josh > > > > > ------------------------------------------------------------------------------ > > Everyone hates slow websites. So do we. > > Make your web apps faster with AppDynamics > > Download AppDynamics Lite for free today: > > http://p.sf.net/sfu/appdyn_d2d_mar > > _______________________________________________ > > Inkscape-devel mailing list > > Inkscape-devel(a)lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/inkscape-devel >

7 8