- Inkscape Devel - Inkscape Mailman

Re: [Inkscape-devel] W3C SVG test suite and trunk
by Guiu Rocafort 17 Oct '13

17 Oct '13

Hi. Sorry, my fault. Actually I thought i was sending the messages to the mailing list, but by mistake i only sent them to martin and alex. I send the messages again. ============ Email 1 ================== 2013/10/10 Alex Valavanis <valavanisalex@...400...>: > Well, I guess the easiest thing would be to organise the svg input > files for the rendering tests into two separate subfolders in > known-pass/testcases and known-fail/testcases. We can then just tell > the test runner to look in the appropriate folder: > > # cat run-svg-tests-good > runtests.py --directory=known-pass > > # cat run-svg-tests-bad > runtests.py --directory=known-fail > Ok, if I understood correctly, the idea here is to have known pass tests, and known fail tests. All test with the respective pass/fail test. If a known pass test changes from the reference image then we can assume we have a regression. If a known fail test changes from the reference we might have solved the problem, but since we can't automatically decide if it is already solved, we would need to check manually and add it to the known pass test if required. That sounds to me like a good compromise between automation and some manual work. The regressions would be detected automatically but the improvements would need to be checked manually. Thoughts about this ? ============ Email 2 ================== 2013/10/10 Martin Owens <doctormo@...400...>: > On Thu, 2013-10-10 at 16:14 +0100, Alex Valavanis wrote: >> two separate executable scripts > > Not yet. And while the python is pretty hairy (needs some code review) > it should be possible to make it do what you want without too many > issues. > > Guiu, Tav; what do you think? Would it be easy enough to modify and > would you like to patch it or should I? Yes, I think I could be able to modify the code to fit the current code to be added to the testings. I sent a message trying to shade some light on what needs to be done and trying to define the problem exactly. If we're happy with what I propose, I can start making the changes soon. There is some hairy code and rewriting some can do very good in the readibility of the code. Guiu > Martin, ========= Message 3 ============== Ok, sorry for sending that much messages, I just wanted to make a little summary about the work that would be needed. 1. Get the SVG 1.1 Second edition test files and extract the text. Jasper, in the link [1] you sent the files are from the Second edition of the test suite or the first one ? Are they up to date ? btw, I do actually think that removing the text is good, because if there is a problem with the text rendering code, it would affect a lot of tests. Removing the text from the tests we can isolate better what we are testing with each file. 2. Then, we would need to manually separate the tests in pass/fail. 3. Implement the code as explained in the message I sent before. Then add it to the tests in the current inkscape trunk to be executed every time someone makes a commit. 4. Then a way to make this information public would need to be done. But we can discuss this while the first points are made. [1] https://svn.code.sf.net/p/inkscape/code/gsoc-testsuite/tester/testcases/svg… If we're happy with that and we agree that this is a good solution, I can start working on this soon. Cheers Guiu Rocafort I'm sorry about that Guiu 2013/10/11 Martin Owens <doctormo@...400...>: > On Fri, 2013-10-11 at 01:01 +0200, Guiu Rocafort wrote: >> If we're happy with that and we agree that this is a good solution, I >> can start working on this soon. > > You need to send this information to the devel mailing list. I recommend > compiling your two emails into one and replying to all as it fits to > have this sent to everyone. > > Martin, > -- Please avoid sending me Word or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html

5 9

Weird bitfield declaration?
by Johan Engelen 16 Oct '13

16 Oct '13

Hi all, I just found this in sp-root.h: class SPRoot : public SPGroup { ... bool viewBox_set : true; I do not know what it means. Does it mean: bool viewBox_set : 1; If so, let's change it to a more recognizable format? Cheers, Johan

5 4

C++ify workflow
by Markus Engel 16 Oct '13

16 Oct '13

Hi, regardingr12593 „C++ify calling a few SPLPEItem functions, much more work thanexpected... slowly slowly…”: I don’tknow what software you are using, with Eclipse my “optimized” workflow is asfollows: 1. Movefunction declaration in the header file into the class, remove the firstparameter 2. Go tothe function definition in the cpp-file, right click and select “Open CallHierarchy” 3. AddSPClass:: in front of the definition 4. Selectthe first parameter, press Shift+Alt+R and rename it to “this” 5. 6. Removethe first parameter, the function is c++ified 6. In theCall Hierarchy window go through the list and adjust the calls 7. Selectany occurrence of the function, again Shift+Alt+R and rename it But I agreethat it’s a lot of boring, monotonous, repetitive work :) . It took me tons ofcoffee and some really long nightly sessions. Scripting this process isn’t thateasy either. At least now I’ve got some deeper understanding of how the partsfit together… and how not to write code. There were some really nice code partsin these files, e. g. marker.cpp, parsing the viewbox attribute by movingaround a char-pointer. This code appears 1:1 in sp-root.cpp ;) . Regards, Markus

8 14

make -n blows up in trunk
by mathog 15 Oct '13

15 Oct '13

There is something wrong with the way make works in trunk. A regular "make" completes, but doing touch (a source file) make -n results in ... Making all in po make[2]: Entering directory `/usr/local/src/inkscape_trunk/po' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/usr/local/src/inkscape_trunk/po' make[2]: Entering directory `/usr/local/src/inkscape_trunk' if perl ./po/check-markup ./po/*.po; [ $? = 1 ]; then \ echo "WARNING: Bad markup found in translations. Please consider fixing the above problems." >&2; \ fi if test ! -f config.h; then rm -f stamp-h1; else :; fi if test ! -f config.h; then make stamp-h1; else :; fi make[2]: Leaving directory `/usr/local/src/inkscape_trunk' make[1]: Leaving directory `/usr/local/src/inkscape_trunk' Just me or does that happen for other people too? I need make -n to work so that I can see which compiler flags are being used on certain files. Thanks, David Mathog mathog@...1176... Manager, Sequence Analysis Facility, Biology Division, Caltech

1 1

lib2geom bug in elliptical-arc.cpp
by Tavmjong Bah 14 Oct '13

14 Oct '13

Hi, I just fixed a lib2geom bug in Inkscape's code (r12687). Don't know the proper way to report it to the lib2geom team. Tangents for counter-clockwise arcs were being calculated 180 degrees off causing markers to be drawn wrong. Tav

2 1

SVG insights
by LRN 14 Oct '13

14 Oct '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I'm doing some research for an application that i might write. It would use cairo to draw some complex graphics (using math!), and users would want to export these graphics + some text and numbers (derived from the same math) into something printable (pdf is the obvious choice, but svg should be OK too - it's highly desirable that graphic object should be in a vector format, not raster, otherwise it doesn't print well). You know, like generating a report - that sort of thing. Now, the graphic object should probably go as-is (no one really needs to alter it in any way; scale it maybe - that's all), but the layout of the page is something users should be able to change. Which means that there should be some kind of mechanism for creating page templates, and my application would just paste graphics and numbers into them. Thus PDF is out of the question. That leaves SVG. When i started writing this message, i thought that i was going to ask about clipboard formats Inkscape understands. I thought that it would be enough to just swap the cairo-gdk surface used in my drawing function for a cairo-svg surface, write svg into memory, put it into clipboard and somehow paste into Inkscape. Now, don't get me wrong, that would _still_ be awesome. So if you know how to do it - i'm all ears. But that, of course, won't do anything about the rest of the contents that should go into page. So now i'm thinking of something different: create a template SVG document in Inkscape (putting placeholders in places where stuff should be inserted), give it to my application, and it will replace placehonders with real stuff (i hope i know XML well enough to just insert proper XML elements into right places) and save the result as an SVG. However, Inkscape does not seem to be terribly good at layout out text either, and copy-pasting drawings from Inkscape to OpenOffice produced mixed results (and i still don't know how to do it programmatically). So...what would you advise me to do? - -- O< ascii ribbon - stop html email! - www.asciiribbon.org -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (MingW32) iQEcBAEBAgAGBQJSXB5nAAoJEOs4Jb6SI2Cw+IsH/2gYQhInPCJU8nuTvWq0zALE 20FSDyy67gqwzBidSqPfyvuUMVfVQTjlpZ2SDVef/Uo2qLbuVTpKA1b6UyNNtjqL i2bebrrwZfrifAK29wc0nqtMJYakqmcLQAfc/LHbZVInRrO4CvMxKTplHHEG4XhQ Ay8shUuUnqhyUP0Bwo+1JHiB3zZoC5UtZZ2Vz+YYe2HarP/JynDIDE2yQCllLFrS wYQ7S2r2jhBH1BcyW4NeCfM4oDrQRjyb/IsG7Mar+VGygttSnrDe1dGcFMHMmxNi cdTJwwhTdQHXQzZU5f9S9iN35irvmH90UgX8gk0ZjR793EZGuCc47zG+hSL2a6c= =3Hhc -----END PGP SIGNATURE-----

2 1

Trunk Problems
by Martin Owens 14 Oct '13

14 Oct '13

Hey devs, I've been trying to make some art using the trunk inkscape build. There is some weird problems going on. * Rotating objects mis-transforming after certain number of degrees. * Broken Path 'Difference' producing very odd results. * Non-working load dialog (might be my computer though because it fails in 0.48.4 too which is odd, might be related to the preview) Are these known problems or should I report them all? I'd like to continue to push for a release, so I think we need to get a freeze of some kind in. We can do objectification, code clean up etc later. For now I think the focus needs to be back on functional bugs. Best Regards, Martin Owens

2 2

Setting a gdb breakpoint in Inkscape
by Guiu Rocafort 13 Oct '13

13 Oct '13

Hi list ! I'm trying to set a breakpoint in the function cssReader::parseFile() using gdb. I've tried several’s ways to do that in gdb, including: "break cssReader::parseFile" then I read this ( http://stackoverflow.com/questions/6892395/set-breakpoint-for-class-member-…) and tried: "break org::w3c::dom::css::parseFile" I also attempted to use the "file:line" method trying: "break cssreader.cpp:1591" "break dom/cssreader.cpp:1591" In the gdb documentation I was not able to find anything related to debugging class methods in C++. I didn't find any useful info in the inkscape debugging wiki page. So anyone can point me the right way to do this ? Thank you. -- *Please avoid sending me Word or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html*

7 10

Crash on start rev 12550 : TypeNotRegistered
by Yann Papouin 13 Oct '13

13 Oct '13

Hi, Launching a clean build on a Win7 64bits raises an exception: terminate called after throwing an instance of 'FactoryExceptions::TypeNotRegistered what(): svg:svg

7 10

Please don't reformat code and fix things in same commit!
by Johan Engelen 13 Oct '13

13 Oct '13

Hi all, Please don't fix a bug or change code in a commit where you reformat a lot of the code aswell. As an example, it is extremely hard to see what part of this commit actually changed code: http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/12548 Thanks! Johan

2 1

Code style question
by Johan Engelen 13 Oct '13

13 Oct '13

Hi all, Now with the change to C++ objects (very happy about it!), is it OK to change this if (SP_IS_LPE_ITEM(item)) { SPLPEItem *lpeitem = SP_LPE_ITEM(item); to this: A. if (SPLPEItem *lpeitem = dynamic_cast<SPLPEItem *>(item)) { I prefer it over the two other options I can think of: B. SPLPEItem *lpeitem = dynamic_cast<SPLPEItem *>(item); if (lpeitem) { or C. if (dynamic_cast<SPLPEItem *>(item)) { SPLPEItem *lpeitem = dynamic_cast<SPLPEItem *>(item); I like A (more than B or C) because it limits the scope of lpeitem, and avoids duplicating the long dynamic_cast<> thing. Downside is that it makes the if-statement rather long. We use option A in 2geom if I remember correctly. Please discuss, or add better implementations! I think it is worthwhile to add the outcome to the coding style page for reference. Thanks, Johan

3 3

Serious problems resulting from the units improvement GSoC merge
by Krzysztof Kosiński 13 Oct '13

13 Oct '13

https://bugs.launchpad.net/inkscape/+bug/1234216 - large perfomance regression https://bugs.launchpad.net/inkscape/+bug/1235279 - loss of precision These problems should be addressed soon, or the unit-related work might need to be reverted before release. The concept of using a viewBox that makes user units equivalent to inches or other large units is severely broken, because currently we use only 6 digits of precision for all coordinates. That was sufficient for pixels, but is definitely not sufficient for a lossless conversion between pixels and inches. Regards, Krzysztof

3 6

W3C SVG test suite and trunk
by Tavmjong Bah 11 Oct '13

11 Oct '13

Hi, I've run the W3C SVG 1.1 2nd Edition test suite using both Inkscape 0.48 and trunk. There are quite a few improvements in test compliance with trunk but some tests show regressions: http://tavmjong.free.fr/INKSCAPE/W3C_SVG_0.49/htmlInkscapeHarness/coords-un… http://tavmjong.free.fr/INKSCAPE/W3C_SVG_0.49/htmlInkscapeHarness/pservers-… http://tavmjong.free.fr/INKSCAPE/W3C_SVG_0.49/htmlInkscapeHarness/pservers-… http://tavmjong.free.fr/INKSCAPE/W3C_SVG_0.49/htmlInkscapeHarness/text-altg… http://tavmjong.free.fr/INKSCAPE/W3C_SVG_0.49/htmlInkscapeHarness/text-tref… Tav

7 26

Offsetting elliptical arcs
by Markus Engel 10 Oct '13

10 Oct '13

Hi devs, I changed the code that generates ellipses and arcs to using true elliptical arcs instead of cubic Bezier curves. Now there's a little problem: When you create for example a pizza slice and a linked offset, you will see that elliptical arcs are somehow "degenerated", i. e. the number of points decreases with increasing radius. (https://bugs.launchpad.net/inkscape/+bug/1236830) Note that the code for offsetting elliptical arcs has been there for quite some time. I'm not sure now whether this is how "offset" is intended to work. What do you think? Regards, Markus

3 4

Re: [Inkscape-devel] W3C SVG test suite and trunk
by Tavmjong Bah 09 Oct '13

09 Oct '13

On Wed, 2013-10-09 at 11:28 +0200, Guiu Rocafort wrote: > 2013/10/9 Tavmjong Bah <tavmjong@...8...> > > > > On Wed, 2013-10-09 at 00:51 +0200, Guiu Rocafort wrote: > > > Hi ! I've been looking at the GSOC and after solving a few problems I > > > can run the tests now. Now I have to find out a way to update the > > > tests. > > > > I was able to run the tests without too much trouble... however I did > > not have a set of "good" PNGs to test against... so I gave up and went > > back to using the latest SVG 1.1 test suite. > > > > To update the tests, I think you just need to put the new SVG files into > > the directory with the existing SVG files and then create reference PNGs > > in the appropriate files (known good rendering, known bad rendering). > > You can't just use the reference PNG files from the SVG test suite for > > doing automated pixel-by-pixel comparison as the results depend on the > > font used. (The SVG2 test suite will use a WOFF font, I think, to avoid > > this problem.) The existing files from the SVG test suite should be > > replaced by the files from the latest version of the SVG 1.1 2nd Ed test > > suite. > > I see, I wasn't aware of that problems with the fonts. Is the problem > related to the use of the SVGFreeSans font ? I saw this font in some > tests so I'm guessing it's being used in all of them. I noticed this > font is not in my system, so installing it in the machine is going to > perform the tests should solve the problem ? No. A search through the SVG files shows all kinds of different fonts being used. SVGFreeSans is required for some tests as is a number of other specially constructed fonts. > But since we're maybe going to use that ppa automated thing to perform > the tests that probably is not an option. Would it be safe to replace > all the fonts in the test by one of these safe fonts ? [1] No. If you look carefully you'll see that each proposed font-family is actually a list of fonts. For example: "Times New Roman", Times, serif. If the first font "Times New Roman" isn't found, then Times is search for. If that is not found then the generic fallback font serif is used. While "Times New Roman" and Times are similar, they are not exactly the same. For the use on the web they are probably acceptable equivalents but for pixel by pixel comparison, they wont work. The solution is to generate the PNG reference images on the same machine that the tests are going to be run on. Then the same font will be used for both the reference and the test images. > Tavmjong, i saw you're running some tests in [2], so, how are you > solving these font problems ? > > [1] http://www.w3schools.com/cssref/css_websafe_fonts.asp > [2] http://tavmjong.free.fr/INKSCAPE/W3C_SVG_0.49/htmlInkscapeHarness/index.html I look at each test manually and just filter out the differences in font. This is OK for a once in a while check but not for automated testing. Also, a few of the text tests really do need special fonts (found in the 'resources' directory). > > > I've set a personal branch in my launchpad account with the changes I > > > made to the original code. > > > https://code.launchpad.net/~neandertalspeople/+junk/inkscape-testsuite > > > > > > > > > After updating the test I'll try to find a way to automate the tests, > > > and perform them regulaly. What do you think about that ? Any idea > > > about how that could be done ? Maybe it is possible to set some kind > > > of trigger when there is a commit in the launchpad inkscape trunk ? > > > > This would be awesome. > > > > Tav > > > > > > > > > > Guiu >

2 1

Ellipses, Circles, and Arcs, oh my!
by unknown＠example.com 08 Oct '13

08 Oct '13

Hi, I see some action on rewriting Inkscape's General Ellipse code. It would be very nice if Inkscape could directly create the SVG circle and ellipse elements rather than use the SVG path element. I realize that this may be outside the scope of the current work but there is one thing that I should bring attention to: The SVG Working Group decided to allow markers on SVG shape elements.[1] Inkscape will actually already draw markers on shapes if there already are markers placed on the shapes in the SVG file (but doesn't draw them "correctly"), however Inkscape does not allow one to add markers to shapes through the GUI. (I'm sure that the drawing of the markers is accidental and not intentional.) It was fairly clear to the SVG WG that for rectangles, there are four markers (one for each corner) and for rounded rectangles, there are eight markers (one at each start and end of a corner arc). See attachment.[2] It wasn't as clear what to do for circles and ellipses. The group decided that there should be four markers on circles and ellipses, located at the 0, 90, 180, and 270 degree points. Inkscape currently represents circles and arcs as two path elliptical arc segments. In order to have four markers, it should be using four elliptical arc segments. I also noticed that the Object->Path command converts a circle/ellipse to a path using eight Bezier curves (and would thus have eight markers). It seems to me that it should be converting to four elliptical arc segments. (After all, converting a rectangle to a path doesn't produce four straight Bezier curves!) Tav [1] http://www.w3.org/2013/06/03-svg-minutes.html#item03 [2] Top row: expected behavior, bottom row: test. Green: Start marker, Yellow: Mid marker, Red: End marker.

6 16

Please Remove Dev Website
by Martin Owens 05 Oct '13

05 Oct '13

Hey Devs, We still have dev.inkscape.org running, I think we should shut it down since staging.inkscape.org takes over from that. I only just noticed because dev is appearing in google search results for inkscape downloads. I forget where it's being hosted though. Ian? Martin,

1 0

More C++ify?
by Johan Engelen 04 Oct '13

04 Oct '13

Hi Markus, all, Markus has done a great job of C++ifying a ton of our C-classes, but... there are still a few left. knot.h display/sp-canvas-item.h ... Are we taking up that task too? :-)) Cheers, Johan

4 4

Changing SpinEdit width
by Yann Papouin 04 Oct '13

04 Oct '13

Hi, For my daily use of Inkscape, SpinEdit controls are too small for quick value reading. http://ftpmerou.free.fr/inkscape/inkscape-widget-size.jpg I'm would like to know where their min width is set. I took a look into "src/widgets/widget-sizes.h" and trying to change these values but even after a clean build it does not seems to have any effect : #define AUX_SPINBUTTON_WIDTH #define AUX_SPINBUTTON_WIDTH_SMALL #define AUX_OPTION_MENU_WIDTH #define AUX_MENU_ITEM_WIDT

1 0

select node fron pathvector
by Jabiertxo Arraiza Cenoz 04 Oct '13

04 Oct '13

Hi to all. Im attemping to get a node element from a Pathvector. Anybody know what to do? I find this obsolete function "sp_nodepath_get_node_by_index". Thanks in advance, Jabier.

2 1

Report #10
by Vinícius dos Santos Oliveira 03 Oct '13

03 Oct '13

So, GSoC coding period is over and now is documentation period. I've sent two more commits to the Inkscape repository earlier today. Nathan convinced me to think "why is the project great?" and then I decided to make two more videos (mic is bad, but understandable, I think): https://vimeo.com/75245148 https://vimeo.com/75247946 My strong accent is bad, but I don't have much people to talk to in english, so you guys will need bear it. I hope you guys like the videos. Tell me if this happens. =) So, this is "documentation week" and I'll write more blog posts regarding technical details (and group them under some folder in the repository). I'll also write the so wanted tutorial (I accept hints about its format). After the week is over, so is GSoC 2013 and my responsibilities will move from "GSoC 2013 student" to "lib2geom and Inkscape developer". The first thing I should do is unify the construction of d attributes of path elements and move this abstraction to the 2geom library, then Inkscape and libdepixelize will share more code (always a good thing). Second thing I'll do is prepare a new stable release of 2geom (need to be discussed with the other of you devs) and create a package for the ArchLinux User Repositories. So, something to tease you guys. Me and Nathan (this guy always have ideas. lucky me for having him as mentor) have some ideas about how to improve the Kopf-Lischinski image quality and we decided to publish a paper. Another cool three-months project to work on. I may finish the harmonic maps triangulation (and put it inside 2geom) before implement the new cool ideas. Anyway, I'll have to delay this project for one week, because the community of my other open source project misses me and have some issues demanding my attention. So, another thing: if you guys have a hand-chosen collection of pixel art images with Alpha Channel, please send me. They will help me in the research project. Jabier did the first step and send me a bunch of this images already, but the more the better (and mainly if they are carefully chosen one-by-one). It was an awesome experience to work with the Inkscape community. -- Vinícius dos Santos Oliveira https://about.me/vinipsmaker

2 9

Staging Website: Offline for Upgrade
by Martin Owens 03 Oct '13

03 Oct '13

Hey devs, This is only the staging server, so I'm only letting devs know. The staging server is down while I move us from apache2 to enginx; most of the work is complete already, there's just some last minute configuring to do. Hopefully I'll be ready to release some cool features by the start of next week. Martin,

1 0

GSOC 2013 Results
by Tavmjong Bah 02 Oct '13

02 Oct '13

The 2013 version of Google Summer of Code has ended. All five projects were successful. Congratulations students (and mentors)! The projects were (* indicates code already merged with trunk): 1) An interactive tool for recoloring artwork. Arshdeep Singh (demicoder), mentored by Ted Gould.[1] 2) Improved units support and consolidating units handling to one place.* Matthew Petroff, mentored by Johan Engelen.[2] 3) Electronics CAD support, focusing on improving connectors and symbols. Sebastian Götte (jaseg), mentored by Tavmjong Bah.[3] 4) A new dialog to create documents from templates.* Jan Darowski (Slagvi), mentored by Krzysztof Kosiński.[4] 5) A new raster-to-vector algorithm focusing on small images.* Vinícius dos Santos Oliveira (vinipsmaker), mentored by Nathan Hurst.[5] The new raster-to-vector algorithm even has a new tutorial included inside of Inkscape! I would like to remind students that haven't already done so, to upload their sample code submissions. This can be done on your Melange project page. Tav [1]https://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/arshd… [2]https://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/mpetr… [3]https://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/jaseg… [4]https://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/slagv… [5]https://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/vinip…

2 1

hack-tweaking a filter ?
by Bric 02 Oct '13

02 Oct '13

A lot of the fancy filters do not have any user parameters; i am looking at Filters -> Materials -> Gold splatter, for example. How can I tweak the colors this produces ? (the "gold" is too green for my purposes) Is it a python extension script? I'm failing to find that in the extensions directory. thanks.

2 1

rasterize an object?
by Bric 02 Oct '13

02 Oct '13

i started a new thread, even though this stems from the same task that made me start the previous thread (hack-tweaking a filter) Is there a way to rasterize an object or a selection in inkscape? That might also accomplish my goal — I could then apply raster color manipulations... currently, that's impossible, if my gold-splatter is in vector form. (AFAICT)

2 1