- Inkscape Devel - Inkscape Mailman

Re: [Inkscape-devel] Extended input issues with later GTK2
by Jasper van de Gronde 11 Jan '12

11 Jan '12

On 11-01-12 16:22, jbc.engelen@...2731... wrote: > ---- Jasper van de Gronde <th.v.d.gronde@...528...> wrote: >> I usually just download the latest TDM GCC from this site: >> http://tdm-gcc.tdragon.net/download >> I would recommend taking the 32 bit bundle installer. >> >> Any objections if I update the Wiki page to point to the site above >> instead of the direct download? > > Not at all. We should always be able to build with latest TDM GCC. > Done.

1 0

Re: [Inkscape-devel] NULL vs. 0
by Jon Cruz 09 Jan '12

09 Jan '12

On Jan 7, 2012, at 11:39 AM, Tomaz Canabrava wrote: > Stroustrup answer to that: > > Should I use NULL or 0? > > In C++, the definition of NULL is 0, so there is only an aesthetic > difference. I prefer to avoid macros, so I use 0. Another problem with > NULL is that people sometimes mistakenly believe that it is different > from 0 and/or not an integer. Actually, for a modern compiler NULL is not an integer. C++ did a bit of a change, and 0 gained special meaning. I believe that most of the systems where it made an actual difference are now gone, but it did. However... the main reason I made the code change is that when I updated to gcc 4.5.2, it started warning on that constructor. It complained that we were setting a pointer value into a non-pointer variable. So we probably have NULL defined as some pointerish macro or value and which should not be assigned to integer variables, while '0' is a magical constant that the compiler knows to just do the right thing with for both pointers and integers. '0' by the C++ language definition works in all cases, but NULL does not. This and the associated warning start to become very important for 64-bit code. Mixing integers and pointers leads to major problems. Bottom line, though, is that we need to remove warnings by fixing the code. The pointer assignments in that initializer could be changed to "NULL", but the integer ones need to stay changed to zero.

5 5

Janitorial tasks
by Kris De Gussem 08 Jan '12

08 Jan '12

Hi all I like to go on with the replacement of the deprecated wrapper functions in src/xml/repr.h with direct calls to their respective functions (as listed in the first section on http://wiki.inkscape.org/wiki/index.php/Janitorial_tasks). Any objections? Kind regards Kris

4 8

Unweirdification of preferences button location in toolbar ; )
by Johan Engelen 08 Jan '12

08 Jan '12

Hi all, With the unweirdification of the preferences dialog in place... shall we exchange the locations of the document properties and inkscape preferences buttons in the toolbar? I am always confused to see them in the order they are in now. Ciao, Johan

1 0

NULL vs. 0
by Johan Engelen 07 Jan '12

07 Jan '12

Hi all, Before reading on, have a look at this code fragment, and ask yourself the question "what type is _desktop, _verb_t, _css, _tool_obs, etc.?" StyleSwatch::StyleSwatch(SPCSSAttr *css, gchar const *main_tip) : _desktop(0), _verb_t(0), _css(0), _tool_obs(0), _style_obs(0), _table(2, 6), _sw_unit(0) The correct answer is: _desktop is a pointer _verb_t is an int _css is a pointer _tool_obs is a pointer _style_obs is a pointer _sw_unit is a pointer Please STOP changing NULL into 0. It makes the code completely unreadable and makes me want to quit Inkscape. I am not kidding. Thanks, Johan

1 0

New: add nodes at extreme values
by Johan Engelen 05 Jan '12

05 Jan '12

Hi all, To help font designers, I just added new functionality to the node tool. It adds a node at the extreme values of a path, if there is not already a node there. (because of a bug in 2geom, it does not work for some special cases, we are working on it) At the moment, this new feature adds 4 buttons to the node tool. Way too much of course. The plan is to move them into a submenu of the Add nodes button. This should not be too hard, the first step is to rewrite in /src/widget/toolbox.cpp: " <toolitem action='NodeInsertAction' />" " <toolitem action='NodeInsertActionMinX' />" " <toolitem action='NodeInsertActionMaxX' />" " <toolitem action='NodeInsertActionMinY' />" " <toolitem action='NodeInsertActionMaxY' />" to " <toolitem action='NodeInsertAction'>" " <menu action='NodeInsertActionMenu'>" " <menuitem action='NodeInsertActionMinX' />" " <menuitem action='NodeInsertActionMaxX' />" " <menuitem action='NodeInsertActionMinY' />" " <menuitem action='NodeInsertActionMaxY' />" " </menu>" " </toolitem>" or so I learn from a gtk demo [1]. It uses a new GtkMenuToolButton [2]. But, alas, if you rewrite it, you get GTK errors and Inkscape terminates... I hope someone can find the time and spirit to work on this. Thanks! Cheers, Johan [1] http://git.gnome.org/browse/gtk+/tree/demos/gtk-demo/appwindow.c?id=2.24.8 [2] http://developer.gnome.org/gtk/2.24/GtkMenuToolButton.html

2 3

Deep Ungroup
by Matěj Cepl 05 Jan '12

05 Jan '12

Hi, in view of https://bugs.launchpad.net/inkscape/+bug/171117 I have created this small extension for recursive ungrouping https://gitorious.org/various-small-stuff/inkscape-ungroup-deep/ (tarball should be available at https://gitorious.org/various-small-stuff/inkscape-ungroup-deep/trees/0.1). It is just proof-of-concept (version 0.1) but seems to work for me. Bug reports, or (even better) patches and pull requests are more than welcome! I was told on #inkscape IRC channel that I cannot add my extension on http://wiki.inkscape.org/wiki/index.php/Extension_repository so if anybody would be able and willing to put it there, I would really appreciate it. Thanks a lot (and happy New Year!) Matěj -- http://www.ceplovi.cz/matej/, Jabber: mcepl<at>ceplovi.cz GPG Finger: 89EF 4BC6 288A BF43 1BAB 25C3 E09F EF25 D964 84AC "Anything essential is invisible to the eyes", the little prince repeated, in order to remember. "It's the time you spent on your rose that makes your rose so important." "It's the time I spent on my rose ...," the little prince repeated, in order to remember. "People have forgotten this truth." the fox said. "But you mustn't forget it. You become responsible forever for what you've tamed. You're responsible for your rose..." "I'm responsible for my rose...," the little prince repeated, in order to remember. -- Antoine de Saint-Exup?ry: The Little Prince

2 1

Wiki !!!
by Johan Engelen 04 Jan '12

04 Jan '12

I need ours! :) Thanks for fixing it, Johan

3 5

GSEAL issues (lots of them!)
by Alex Valavanis 03 Jan '12

03 Jan '12

Hi All, I thought it would be worth mentioning that we need to get rid of all direct access to private fields of objects as part of our GTK+ 3 migration. i.e. foo->bar = bar_val; // NO!! gtk_foo_set_bar (foo, bar_val); //Yes! bar_val = foo->bar; // NO!! bar_val = gtk_foo_get_bar (foo); //Yes! To check for these issues, you can compile inkscape with: make CFLAGS+="-DGSEAL_ENABLE" CXXFLAGS+="-DGSEAL_ENABLE" Note that there are probably hundreds of such problems, so any help with the cleanup would be appreciated! Usually there is a suitable GTK/GDK accessor function to fix the problem. Sometimes (e.g. [1]) there isn't, which I guess implies that we're doing something the "wrong" way. Cheers, Alex [1] https://bugs.launchpad.net/inkscape/+bug/911174

1 0

Bazaar advice
by Johan Engelen 03 Jan '12

03 Jan '12

Hi all, A recent commit to lib2geom compressed almost all commits since februari into one. Very annoying, although I know you can find out what those individual commits were with some more clicking. These mistakes don't surprise me; I am scared of the bzr tool that does things I do not understand. So to make people aware of the dangers of bzr, I'd like to give advice to simple folks like me: ************************************* I strongly advise you to not work in branches and merge it into trunk, and stay away from any other so-called convenient advanced functionality of bzr, like push-pull-whatever. Simply use it in 'svn mode'. http://wiki.inkscape.org/wiki/index.php/Working_with_Bazaar#Using_a_central… ************************************* If you have fully understood how bzr works, perhaps you can try to use the extra functionality. In that case, learn how to foul up the history (like rev2000 in lib2geom) so you don't type in such commands. Thank you very very very much, Johan (PS. no hard feelings to the committer of course! I blame the tool that allows these things to happen)

4 5