February 2005 - Inkscape Devel

0.41pre1 tarball is up
by Kees Cook 06 Feb '05

06 Feb '05

Ted and are both having harddrive and filesystem problems tonight, it seems. I've managed to get the 0.41pre1 tarball up on sourceforge, emulating the prior prerelease notes, etc. -- Kees Cook @outflux.net

1 0

RE: [Inkscape-devel] Inkboard linking/dependencies
by Montgomery, Steven S 06 Feb '05

06 Feb '05

They were actually listed under libinkpre_a_SOURCES. Just removing them from there fixed the issue. Thanks for the help on this! Steven -----Original Message----- From: inkscape-devel-admin(a)lists.sourceforge.net [mailto:inkscape-devel-admin@lists.sourceforge.net] On Behalf Of Bryce Harrington Sent: Saturday, February 05, 2005 1:27 PM To: Montgomery, Steven S Cc: inkscape-devel(a)lists.sourceforge.net Subject: RE: [Inkscape-devel] Inkboard linking/dependencies On Sat, 5 Feb 2005, Montgomery, Steven S wrote: > I've went ahead and included the extern lines: however, that's a > different issue than what we were having. The undefined reference we > have is to functions we wrote in inkboard.cpp. Here they are from the > most recent attempt: > dialogs/libspdialogs.a(InkboardMsg.o)(.text+0xa7a): In function > `sp_inkBMsg_ObjectAddedChild': > dialogs/InkboardMsg.cpp:436: undefined reference to `sendChange(char*)' > dialogs/libspdialogs.a(InkboardMsg.o)(.text+0xc92): In function > `sp_inkBMsg_ObjectRemovedChild': > dialogs/InkboardMsg.cpp:519: undefined reference to `sendChange(char*)' > dialogs/libspdialogs.a(InkboardMsg.o)(.text+0xe4d): In function > `sp_inkBMsg_ObjectChanged': > dialogs/InkboardMsg.cpp:624: undefined reference to `sendChange(char*)' > dialogs/libspdialogs.a(inkboard-connect.o)(.text+0xa97): In function > `sp_inkboardConnect_dialog_inkboardConnect(_GObject*, _GObject*)': > dialogs/inkboard-connect.cpp:228: undefined reference to > `connect_and_auth(char*, char*, char*)' > dialogs/libspdialogs.a(inkboard-connect.o)(.text+0xacf):dialogs/inkboard > -connect.cpp:238: undefined reference to `setRecipient(char const*)' > dialogs/libspdialogs.a(inkboard-connect.o)(.text+0x138f): In function > `sp_inkboardConnect_dialog_inkboardShareUser(_GObject*, _GObject*)': > dialogs/inkboard-connect.cpp:393: undefined reference to > `send_connect_request_to_user(char const*, char*)' > > I suspect you didn't get that error when you checked out of the CVS. > Line 8 of inkboard.cpp should be #include "dialogs/InkboardMsg.h" > instead of #include "dialogs/InkboardMsg.cpp". I hesitate to upload > that change since we've been following the convention of only committing > changes after we ensure that it at least compiles. > > For a reason I don't fully understand, including that .cpp somehow > informs the linker of where our new functions are defined. Well, by including the .cpp you essentially are pasting the contents of that file in, so it's getting the full definition of all the functions. However, having multiple definitions of functions in your binary will cause trouble later, so we should solve the problem more directly... Try this. Move your two main files to the inkpost.a section, i.e.: libinkpost_a_SOURCES = \ ... inkboard.cpp inkboard.h \ This forces those objects to be compiled last in the link chain, so if link ordering is the issue, this might fix it. Bryce ------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ Inkscape-devel mailing list Inkscape-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel

1 0

g_file_test
by Kees Cook 06 Feb '05

06 Feb '05

I've been playing with Jon Cruz's updates to the profile_path and mkdir stuff. Short story: it works. Long story: g_file_test isn't utf sane. *bang head* So, the test for the directory fails, but making it works just fine. -- Kees Cook @outflux.net

5 8

[0.41] Fix link: Move functions from splivarot.cpp to xml/
by Peter Moulder 06 Feb '05

06 Feb '05

A couple of utility functions in splivarot.cpp have become used by xml/repr-util.cpp. The attached patch moves these two functions (LCA and AncetreFils) to new files xml/repr-sorting.{cpp,h} in xml/libspxml.a. This is appropriate for cleanliness, and also fixes a link problem with `make check'. Since we're in hard freeze, I haven't renamed these functions. (N.B. Remember to do `cvs add -ko xml/repr-sorting.{cpp,h}' after applying this patch.) The patch (like the gc one, I should have mentioned in the previous message) is from the src directory. pjrm.

2 2

[0/5]: patches for clean "make check"
by Kees Cook 05 Feb '05

05 Feb '05

Following this email are five patch sets (whose apply order matters). This is a full roll-up of changes Peter and I worked on last night with some additional updates to get "make check" to fully pass. 1/5: compile cleanups only This is makefile goo for getting "make check" to compile correctly. 2/5: test code changes only This is test-code changes only. No core code changes are needed to make these tests pass "make check". 3/5: core code changes for repr-action-test compiling This is a change to the way core code is layed out in the tree, to help compile repr-action-test more easily. The functions are unchanged. 4/5: core code changes for repr-action-test behavior This changes when an undo session is released, down in simple-session. This lets repr-action-test pass its tests. The only caller to sp_repr_rollback is sp_document_cancel. sp_document_cancel isn't easily callable, since the three calls to it currently would only happen during repr tree breakage in the XML editor. I think this is safe. 5/5: win32 file list updates This is just a final sync of all the above file changes, as seen by the win32 file list building tools. "make check" finished, but "make distcheck" does not, as streamtest depends on files local to its directory, which is against build rules for "distcheck". I will fix it later, since I made it relocatable in patch #2. -- Kees Cook @outflux.net

4 4

[4/5]: core code changes for repr-action-test behavior
by Kees Cook 05 Feb '05

05 Feb '05